Re: [PATCH] add fsck passno to dracut --mount args

[Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On Thu, Feb 13, 2014 at 03:50:24PM +0100, Harald Hoyer wrote:
> On 02/13/2014 03:42 PM, Vivek Goyal wrote:
> > On Wed, Feb 12, 2014 at 03:22:30PM +0800, Dave Young wrote:
> >> We are using dracut --mount to pass fstab lines for mounting filesystems
> >> other than rootfs. But we did not provide passno for filesystem checking.
> >>
> >> Add passno '2' for all the --mount targets.
> >>
> >> Tested in F19 guest.
> >>
> >> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >> ---
> >>  mkdumprd |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> --- kexec-tools.orig/mkdumprd
> >> +++ kexec-tools/mkdumprd
> >> @@ -104,7 +104,7 @@ to_mount() {
> >>      _o=$(findmnt -k -f -n -r -o OPTIONS $_dev)
> >>      _o=${_o/#ro/rw} #mount fs target as rw in 2nd kernel
> >>      _o="${_o},nofail" #with nofail set, systemd won't block for mount failure
> >> -    _mntopts="$_t $_o"
> >> +    _mntopts="$_t $_o 0 2"
> > 
> > What is 0 here. I think you are trying to emulate the format of an fstab
> > file and passing 5th and 6th field.
> > 
> > I don't think they are filesystem options. If you trying to mount a file
> > system with 0 and 2 passed as additional parameters, mount will complain
> > that what is 0 and 2 it does not understand.
> 
> yes, kind of... as it is now, it would generate an invalid fstab line
> 
>     while pop fstab_lines line; do
>         printf "%s\n" "$line 0 0" >> "${initdir}/etc/fstab"
>     done
> 
> but most of the tools would accept that and the fsck would be done
> 
> > 
> > I am CCing harald. He might have thoughts on what's the better way to
> > pass the fsck_passno of filesystem being mounted. I would not mind of
> > passno 2 is hardcoded for anything passed in using --mount option in
> > dracut.
> 
> we can also check if those are present, and set "0 0" as the default if nothing
> is given in "--mount"

Ok, so you don't mind being passed in fs_freq and fs_passno as last fields
of --mount option.

In that case, Dave can you please also post a patch to modify dracut to
parse these fields and use default of "0 0" only if use did not pass those.

Also please modify dracut man page and mention that one can pass in
fs_freq and fs_passno as last options.

Dave, in the changelog of this patch, can we also please mention that
why we need to set passno explicitly. We can mention that default is zero
and that means no fsck will be run. But we want to make sure fsck is
run before we try to save dump on filesystem.

Thanks
Vivek