Re: [PATCH] add fsck passno to dracut --mount args

[Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On Fri, Feb 14, 2014 at 10:37:35AM +0800, Dave Young wrote:
> On 02/13/14 at 09:42am, Vivek Goyal wrote:
> > On Wed, Feb 12, 2014 at 03:22:30PM +0800, Dave Young wrote:
> > > We are using dracut --mount to pass fstab lines for mounting filesystems
> > > other than rootfs. But we did not provide passno for filesystem checking.
> > > 
> > > Add passno '2' for all the --mount targets.
> > > 
> > > Tested in F19 guest.
> > > 
> > > Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > > ---
> > >  mkdumprd |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > --- kexec-tools.orig/mkdumprd
> > > +++ kexec-tools/mkdumprd
> > > @@ -104,7 +104,7 @@ to_mount() {
> > >      _o=$(findmnt -k -f -n -r -o OPTIONS $_dev)
> > >      _o=${_o/#ro/rw} #mount fs target as rw in 2nd kernel
> > >      _o="${_o},nofail" #with nofail set, systemd won't block for mount failure
> > > -    _mntopts="$_t $_o"
> > > +    _mntopts="$_t $_o 0 2"
> > 
> > What is 0 here. I think you are trying to emulate the format of an fstab
> > file and passing 5th and 6th field.
> > 
> > I don't think they are filesystem options. If you trying to mount a file
> > system with 0 and 2 passed as additional parameters, mount will complain
> > that what is 0 and 2 it does not understand.
> 
> The _mntopts does not means the real "mount options" it's just a string for
> cancat and create a fstab line then pass to dracut. Currently it contains
> the mount target and mount options, and it contains fs_freq and fs_passno
> after this patch.

That's an implementation detail. dracut does not promise that it is going
to put this in a /etc/fstab file. What if dracut directly decides to
use mount command.

mount -t <filesystem ype> -o <filesystem options> <device> <mountpoint>

In this case mount will fail if you decide to pass 0 and 2. For example
I tried following and it failed. 

mount -t ext4 -o data=ordered,0,2 /dev/sdb /mnt/wd-ssd1/

While following succeeded.

mount -t ext4 -o data=ordered /dev/sdb /mnt/wd-ssd1/

That's why I am insisting that we modify dracut man page and make it
explicit. fs_freq and fs_passno are not mount options. You try to pass
them as mount options, and mount will fail.

> 
> Probably should we change the local variable name to something "_line"?

Or explicity use local variable names as fs_freq and fs_passno (taken
from fstab man page).

Thanks
Vivek