Re: [PATCH] add fsck passno to dracut --mount args

Re: [PATCH] add fsck passno to dracut --mount args

[Vivek Goyal]

On Wed, Feb 12, 2014 at 03:22:30PM +0800, Dave Young wrote:
> We are using dracut --mount to pass fstab lines for mounting filesystems
> other than rootfs. But we did not provide passno for filesystem checking.
> 
> Add passno '2' for all the --mount targets.
> 
> Tested in F19 guest.
> 
> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  mkdumprd |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- kexec-tools.orig/mkdumprd
> +++ kexec-tools/mkdumprd
> @@ -104,7 +104,7 @@ to_mount() {
>      _o=$(findmnt -k -f -n -r -o OPTIONS $_dev)
>      _o=${_o/#ro/rw} #mount fs target as rw in 2nd kernel
>      _o="${_o},nofail" #with nofail set, systemd won't block for mount failure
> -    _mntopts="$_t $_o"
> +    _mntopts="$_t $_o 0 2"

What is 0 here. I think you are trying to emulate the format of an fstab
file and passing 5th and 6th field.

I don't think they are filesystem options. If you trying to mount a file
system with 0 and 2 passed as additional parameters, mount will complain
that what is 0 and 2 it does not understand.

I am CCing harald. He might have thoughts on what's the better way to
pass the fsck_passno of filesystem being mounted. I would not mind of
passno 2 is hardcoded for anything passed in using --mount option in
dracut.

Thanks
Vivek

Re: [PATCH] add fsck passno to dracut --mount args

[Harald Hoyer]

On 02/13/2014 03:42 PM, Vivek Goyal wrote:
> On Wed, Feb 12, 2014 at 03:22:30PM +0800, Dave Young wrote:
>> We are using dracut --mount to pass fstab lines for mounting filesystems
>> other than rootfs. But we did not provide passno for filesystem checking.
>>
>> Add passno '2' for all the --mount targets.
>>
>> Tested in F19 guest.
>>
>> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>>  mkdumprd |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- kexec-tools.orig/mkdumprd
>> +++ kexec-tools/mkdumprd
>> @@ -104,7 +104,7 @@ to_mount() {
>>      _o=$(findmnt -k -f -n -r -o OPTIONS $_dev)
>>      _o=${_o/#ro/rw} #mount fs target as rw in 2nd kernel
>>      _o="${_o},nofail" #with nofail set, systemd won't block for mount failure
>> -    _mntopts="$_t $_o"
>> +    _mntopts="$_t $_o 0 2"
> 
> What is 0 here. I think you are trying to emulate the format of an fstab
> file and passing 5th and 6th field.
> 
> I don't think they are filesystem options. If you trying to mount a file
> system with 0 and 2 passed as additional parameters, mount will complain
> that what is 0 and 2 it does not understand.

yes, kind of... as it is now, it would generate an invalid fstab line

    while pop fstab_lines line; do
        printf "%s\n" "$line 0 0" >> "${initdir}/etc/fstab"
    done

but most of the tools would accept that and the fsck would be done

> 
> I am CCing harald. He might have thoughts on what's the better way to
> pass the fsck_passno of filesystem being mounted. I would not mind of
> passno 2 is hardcoded for anything passed in using --mount option in
> dracut.

we can also check if those are present, and set "0 0" as the default if nothing
is given in "--mount"

> 
> Thanks
> Vivek
> 

Re: [PATCH] add fsck passno to dracut --mount args

[Vivek Goyal]

On Thu, Feb 13, 2014 at 03:50:24PM +0100, Harald Hoyer wrote:
> On 02/13/2014 03:42 PM, Vivek Goyal wrote:
> > On Wed, Feb 12, 2014 at 03:22:30PM +0800, Dave Young wrote:
> >> We are using dracut --mount to pass fstab lines for mounting filesystems
> >> other than rootfs. But we did not provide passno for filesystem checking.
> >>
> >> Add passno '2' for all the --mount targets.
> >>
> >> Tested in F19 guest.
> >>
> >> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >> ---
> >>  mkdumprd |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> --- kexec-tools.orig/mkdumprd
> >> +++ kexec-tools/mkdumprd
> >> @@ -104,7 +104,7 @@ to_mount() {
> >>      _o=$(findmnt -k -f -n -r -o OPTIONS $_dev)
> >>      _o=${_o/#ro/rw} #mount fs target as rw in 2nd kernel
> >>      _o="${_o},nofail" #with nofail set, systemd won't block for mount failure
> >> -    _mntopts="$_t $_o"
> >> +    _mntopts="$_t $_o 0 2"
> > 
> > What is 0 here. I think you are trying to emulate the format of an fstab
> > file and passing 5th and 6th field.
> > 
> > I don't think they are filesystem options. If you trying to mount a file
> > system with 0 and 2 passed as additional parameters, mount will complain
> > that what is 0 and 2 it does not understand.
> 
> yes, kind of... as it is now, it would generate an invalid fstab line
> 
>     while pop fstab_lines line; do
>         printf "%s\n" "$line 0 0" >> "${initdir}/etc/fstab"
>     done
> 
> but most of the tools would accept that and the fsck would be done
> 
> > 
> > I am CCing harald. He might have thoughts on what's the better way to
> > pass the fsck_passno of filesystem being mounted. I would not mind of
> > passno 2 is hardcoded for anything passed in using --mount option in
> > dracut.
> 
> we can also check if those are present, and set "0 0" as the default if nothing
> is given in "--mount"

Ok, so you don't mind being passed in fs_freq and fs_passno as last fields
of --mount option.

In that case, Dave can you please also post a patch to modify dracut to
parse these fields and use default of "0 0" only if use did not pass those.

Also please modify dracut man page and mention that one can pass in
fs_freq and fs_passno as last options.

Dave, in the changelog of this patch, can we also please mention that
why we need to set passno explicitly. We can mention that default is zero
and that means no fsck will be run. But we want to make sure fsck is
run before we try to save dump on filesystem.

Thanks
Vivek

Re: [PATCH] add fsck passno to dracut --mount args

[Dave Young]

On 02/13/14 at 10:08am, Vivek Goyal wrote:
> On Thu, Feb 13, 2014 at 03:50:24PM +0100, Harald Hoyer wrote:
> > On 02/13/2014 03:42 PM, Vivek Goyal wrote:
> > > On Wed, Feb 12, 2014 at 03:22:30PM +0800, Dave Young wrote:
> > >> We are using dracut --mount to pass fstab lines for mounting filesystems
> > >> other than rootfs. But we did not provide passno for filesystem checking.
> > >>
> > >> Add passno '2' for all the --mount targets.
> > >>
> > >> Tested in F19 guest.
> > >>
> > >> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > >> ---
> > >>  mkdumprd |    2 +-
> > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> --- kexec-tools.orig/mkdumprd
> > >> +++ kexec-tools/mkdumprd
> > >> @@ -104,7 +104,7 @@ to_mount() {
> > >>      _o=$(findmnt -k -f -n -r -o OPTIONS $_dev)
> > >>      _o=${_o/#ro/rw} #mount fs target as rw in 2nd kernel
> > >>      _o="${_o},nofail" #with nofail set, systemd won't block for mount failure
> > >> -    _mntopts="$_t $_o"
> > >> +    _mntopts="$_t $_o 0 2"
> > > 
> > > What is 0 here. I think you are trying to emulate the format of an fstab
> > > file and passing 5th and 6th field.
> > > 
> > > I don't think they are filesystem options. If you trying to mount a file
> > > system with 0 and 2 passed as additional parameters, mount will complain
> > > that what is 0 and 2 it does not understand.
> > 
> > yes, kind of... as it is now, it would generate an invalid fstab line
> > 
> >     while pop fstab_lines line; do
> >         printf "%s\n" "$line 0 0" >> "${initdir}/etc/fstab"
> >     done
> > 
> > but most of the tools would accept that and the fsck would be done
> > 
> > > 
> > > I am CCing harald. He might have thoughts on what's the better way to
> > > pass the fsck_passno of filesystem being mounted. I would not mind of
> > > passno 2 is hardcoded for anything passed in using --mount option in
> > > dracut.
> > 
> > we can also check if those are present, and set "0 0" as the default if nothing
> > is given in "--mount"
> 
> Ok, so you don't mind being passed in fs_freq and fs_passno as last fields
> of --mount option.
> 
> In that case, Dave can you please also post a patch to modify dracut to
> parse these fields and use default of "0 0" only if use did not pass those.

Sure, will do

> 
> Also please modify dracut man page and mention that one can pass in
> fs_freq and fs_passno as last options.

Ok.

> 
> Dave, in the changelog of this patch, can we also please mention that
> why we need to set passno explicitly. We can mention that default is zero
> and that means no fsck will be run. But we want to make sure fsck is
> run before we try to save dump on filesystem.

Ok, will do

Thanks
Dave

Re: [PATCH] add fsck passno to dracut --mount args

[Dave Young]

On 02/14/14 at 10:40am, Dave Young wrote:
> On 02/13/14 at 10:08am, Vivek Goyal wrote:
> > On Thu, Feb 13, 2014 at 03:50:24PM +0100, Harald Hoyer wrote:
> > > On 02/13/2014 03:42 PM, Vivek Goyal wrote:
> > > > On Wed, Feb 12, 2014 at 03:22:30PM +0800, Dave Young wrote:
> > > >> We are using dracut --mount to pass fstab lines for mounting filesystems
> > > >> other than rootfs. But we did not provide passno for filesystem checking.
> > > >>
> > > >> Add passno '2' for all the --mount targets.
> > > >>
> > > >> Tested in F19 guest.
> > > >>
> > > >> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > > >> ---
> > > >>  mkdumprd |    2 +-
> > > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >>
> > > >> --- kexec-tools.orig/mkdumprd
> > > >> +++ kexec-tools/mkdumprd
> > > >> @@ -104,7 +104,7 @@ to_mount() {
> > > >>      _o=$(findmnt -k -f -n -r -o OPTIONS $_dev)
> > > >>      _o=${_o/#ro/rw} #mount fs target as rw in 2nd kernel
> > > >>      _o="${_o},nofail" #with nofail set, systemd won't block for mount failure
> > > >> -    _mntopts="$_t $_o"
> > > >> +    _mntopts="$_t $_o 0 2"
> > > > 
> > > > What is 0 here. I think you are trying to emulate the format of an fstab
> > > > file and passing 5th and 6th field.
> > > > 
> > > > I don't think they are filesystem options. If you trying to mount a file
> > > > system with 0 and 2 passed as additional parameters, mount will complain
> > > > that what is 0 and 2 it does not understand.
> > > 
> > > yes, kind of... as it is now, it would generate an invalid fstab line
> > > 
> > >     while pop fstab_lines line; do
> > >         printf "%s\n" "$line 0 0" >> "${initdir}/etc/fstab"
> > >     done
> > > 
> > > but most of the tools would accept that and the fsck would be done
> > > 
> > > > 
> > > > I am CCing harald. He might have thoughts on what's the better way to
> > > > pass the fsck_passno of filesystem being mounted. I would not mind of
> > > > passno 2 is hardcoded for anything passed in using --mount option in
> > > > dracut.
> > > 
> > > we can also check if those are present, and set "0 0" as the default if nothing
> > > is given in "--mount"
> > 
> > Ok, so you don't mind being passed in fs_freq and fs_passno as last fields
> > of --mount option.
> > 
> > In that case, Dave can you please also post a patch to modify dracut to
> > parse these fields and use default of "0 0" only if use did not pass those.
> 
> Sure, will do

Hmm, what Harald mentioned is already in dracut code. I think we only need to
pass them in kdump module.

Thanks
Dave

Re: [PATCH] add fsck passno to dracut --mount args

[Dave Young]

> > > Ok, so you don't mind being passed in fs_freq and fs_passno as last fields
> > > of --mount option.
> > > 
> > > In that case, Dave can you please also post a patch to modify dracut to
> > > parse these fields and use default of "0 0" only if use did not pass those.
> > 
> > Sure, will do
> 
> Hmm, what Harald mentioned is already in dracut code. I think we only need to
> pass them in kdump module.

Rechecking it, dracut still need a fix to parse the extra options because it only
add "0 0" unconditionally.

The previous testing passed of this patch because dracut just regard the "0 2"
as mount options and later fstab-sys mount.sh parse the "2" as pass_no.

Thanks
Dave

Re: [PATCH] add fsck passno to dracut --mount args

[Dave Young]

On 02/13/14 at 09:42am, Vivek Goyal wrote:
> On Wed, Feb 12, 2014 at 03:22:30PM +0800, Dave Young wrote:
> > We are using dracut --mount to pass fstab lines for mounting filesystems
> > other than rootfs. But we did not provide passno for filesystem checking.
> > 
> > Add passno '2' for all the --mount targets.
> > 
> > Tested in F19 guest.
> > 
> > Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > ---
> >  mkdumprd |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- kexec-tools.orig/mkdumprd
> > +++ kexec-tools/mkdumprd
> > @@ -104,7 +104,7 @@ to_mount() {
> >      _o=$(findmnt -k -f -n -r -o OPTIONS $_dev)
> >      _o=${_o/#ro/rw} #mount fs target as rw in 2nd kernel
> >      _o="${_o},nofail" #with nofail set, systemd won't block for mount failure
> > -    _mntopts="$_t $_o"
> > +    _mntopts="$_t $_o 0 2"
> 
> What is 0 here. I think you are trying to emulate the format of an fstab
> file and passing 5th and 6th field.
> 
> I don't think they are filesystem options. If you trying to mount a file
> system with 0 and 2 passed as additional parameters, mount will complain
> that what is 0 and 2 it does not understand.

The _mntopts does not means the real "mount options" it's just a string for
cancat and create a fstab line then pass to dracut. Currently it contains
the mount target and mount options, and it contains fs_freq and fs_passno
after this patch.

Probably should we change the local variable name to something "_line"?

Thanks
dave

Re: [PATCH] add fsck passno to dracut --mount args

[Vivek Goyal]

On Fri, Feb 14, 2014 at 10:37:35AM +0800, Dave Young wrote:
> On 02/13/14 at 09:42am, Vivek Goyal wrote:
> > On Wed, Feb 12, 2014 at 03:22:30PM +0800, Dave Young wrote:
> > > We are using dracut --mount to pass fstab lines for mounting filesystems
> > > other than rootfs. But we did not provide passno for filesystem checking.
> > > 
> > > Add passno '2' for all the --mount targets.
> > > 
> > > Tested in F19 guest.
> > > 
> > > Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > > ---
> > >  mkdumprd |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > --- kexec-tools.orig/mkdumprd
> > > +++ kexec-tools/mkdumprd
> > > @@ -104,7 +104,7 @@ to_mount() {
> > >      _o=$(findmnt -k -f -n -r -o OPTIONS $_dev)
> > >      _o=${_o/#ro/rw} #mount fs target as rw in 2nd kernel
> > >      _o="${_o},nofail" #with nofail set, systemd won't block for mount failure
> > > -    _mntopts="$_t $_o"
> > > +    _mntopts="$_t $_o 0 2"
> > 
> > What is 0 here. I think you are trying to emulate the format of an fstab
> > file and passing 5th and 6th field.
> > 
> > I don't think they are filesystem options. If you trying to mount a file
> > system with 0 and 2 passed as additional parameters, mount will complain
> > that what is 0 and 2 it does not understand.
> 
> The _mntopts does not means the real "mount options" it's just a string for
> cancat and create a fstab line then pass to dracut. Currently it contains
> the mount target and mount options, and it contains fs_freq and fs_passno
> after this patch.

That's an implementation detail. dracut does not promise that it is going
to put this in a /etc/fstab file. What if dracut directly decides to
use mount command.

mount -t <filesystem ype> -o <filesystem options> <device> <mountpoint>

In this case mount will fail if you decide to pass 0 and 2. For example
I tried following and it failed. 

mount -t ext4 -o data=ordered,0,2 /dev/sdb /mnt/wd-ssd1/

While following succeeded.

mount -t ext4 -o data=ordered /dev/sdb /mnt/wd-ssd1/

That's why I am insisting that we modify dracut man page and make it
explicit. fs_freq and fs_passno are not mount options. You try to pass
them as mount options, and mount will fail.

> 
> Probably should we change the local variable name to something "_line"?

Or explicity use local variable names as fs_freq and fs_passno (taken
from fstab man page).

Thanks
Vivek