[radeonsi] si_populate_sq_ramping_values

[radeonsi] si_populate_sq_ramping_values

[Sylvain BERTRAND]

Hi,

In si_dpm.c, si_populate_sq_ramping_values function,

It should be SISLANDS_DPM2_SQ_RAMP_LTI_RATIO instead of
NISLANDS_DPM2_SQ_RAMP_LTI_RATIO.

----

Moreover should it be:
if (SISLANDS_DPM2_SQ_RAMP_LTI_RATIO > (LTI_RATIO_MASK >>
LTI_RATIO_SHIFT))

instead of:
if (NISLANDS_DPM2_SQ_RAMP_LTI_RATIO <= (LTI_RATIO_MASK >>
LTI_RATIO_SHIFT))

----

The previous does disable "sq ramping" for good on all SI,
expected?

regards,

-- 
Sylvain

Re: [radeonsi] si_populate_sq_ramping_values

[Alex Deucher]

On Mon, Feb 17, 2014 at 5:08 PM, Sylvain BERTRAND <sylware@legeek.net> wrote:
> Hi,
>
> In si_dpm.c, si_populate_sq_ramping_values function,
>
> It should be SISLANDS_DPM2_SQ_RAMP_LTI_RATIO instead of
> NISLANDS_DPM2_SQ_RAMP_LTI_RATIO.
>

This is already changed.

> ----
>
> Moreover should it be:
> if (SISLANDS_DPM2_SQ_RAMP_LTI_RATIO > (LTI_RATIO_MASK >>
> LTI_RATIO_SHIFT))
>
> instead of:
> if (NISLANDS_DPM2_SQ_RAMP_LTI_RATIO <= (LTI_RATIO_MASK >>
> LTI_RATIO_SHIFT))
>
> ----
>
> The previous does disable "sq ramping" for good on all SI,
> expected?
>

You are correct.  fixed.

Thanks!

Alex

> regards,
>
> --
> Sylvain
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel