Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate

From: Dave Chinner <david@fromorbit.com>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Namjae Jeon <linkinjeon@gmail.com>,
	tytso@mit.edu, Namjae Jeon <namjae.jeon@samsung.com>,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com, bpm@sgi.com,
	adilger.kernel@dilger.ca, viro@zeniv.linux.org.uk,
	Ashish Sangwan <a.sangwan@samsung.com>,
	linux-fsdevel@vger.kernel.org, jack@suse.cz,
	linux-ext4@vger.kernel.org, mtk.manpages@gmail.com
Subject: Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate
Date: Tue, 18 Feb 2014 20:46:44 +1100	[thread overview]
Message-ID: <20140218094644.GD28666@dastard> (raw)
In-Reply-To: <alpine.LFD.2.00.1402181001530.2216@localhost.localdomain>

On Tue, Feb 18, 2014 at 10:05:49AM +0100, Lukáš Czerner wrote:
> On Wed, 12 Feb 2014, Namjae Jeon wrote:
> 
> > Date: Wed, 12 Feb 2014 11:28:35 +0900
> > From: Namjae Jeon <linkinjeon@gmail.com>
> > To: Lukáš Czerner <lczerner@redhat.com>
> > Cc: viro@zeniv.linux.org.uk, david@fromorbit.com, bpm@sgi.com, tytso@mit.edu,
> >     adilger.kernel@dilger.ca, jack@suse.cz, mtk.manpages@gmail.com,
> >     linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
> >     linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
> >     Namjae Jeon <namjae.jeon@samsung.com>,
> >     Ashish Sangwan <a.sangwan@samsung.com>
> > Subject: Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE
> >     for fallocate
> > 
> > 2014-02-11 20:59 GMT+09:00, Lukáš Czerner <lczerner@redhat.com>:
> > > On Sun, 2 Feb 2014, Namjae Jeon wrote:
> > >
> > >> Date: Sun,  2 Feb 2014 14:44:34 +0900
> > >> From: Namjae Jeon <linkinjeon@gmail.com>
> > >> To: viro@zeniv.linux.org.uk, david@fromorbit.com, bpm@sgi.com,
> > >> tytso@mit.edu,
> > >>     adilger.kernel@dilger.ca, jack@suse.cz, mtk.manpages@gmail.com
> > >> Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
> > >>     linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
> > >>     Namjae Jeon <linkinjeon@gmail.com>, Namjae Jeon
> > >> <namjae.jeon@samsung.com>,
> > >>     Ashish Sangwan <a.sangwan@samsung.com>
> > >> Subject: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE
> > >> for
> > >>     fallocate
> > >>
> > >> From: Namjae Jeon <namjae.jeon@samsung.com>
> > >>
> > >> Add support FALLOC_FL_COLLAPSE_RANGE for fallocate
> > Hi Lukas.
> > >
> > > Description is missing here, please provide FALLOC_FL_COLLAPSE_RANGE
> > > description so people know what it's supposed to be doing.
> > >
> > > more comments bellow.
> > Okay, I will udpate.
> > >
> > > Thanks!
> > > -Lukas
> 
> Hi,
> 
> you may have noticed my patches for new FALLOC_FL_ZERO_RANGE
> fallocate flag. This changes things around the same area as your
> patches does so we should probably figure out which are going to
> land in first and then rebase the other on top of that.
> 
> One concern I have is that I have not seen any tests provided to
> verify the feature. But I just may have missed it. Do you have any
> xfstests test or at least fsx and fsstress patches to provide
> support for testing FALLOC_FL_COLLAPSE_RANGE ? Patches for
> util_linux might also be handy.

There were 5 xfstests patches posted that used the
_test_generic_punch infrastructure to test this functionality.
See the december 08 index here, search for "shared/00[1-5]":

http://oss.sgi.com/archives/xfs/2013-12/index.html

They need a little rework, but otherwise the test code is there.
Having the feature added to fsx and fsstress would probably be a
good idea, though.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs