From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] clk: respect the clock dependencies in of_clk_init
Date: Sun, 23 Feb 2014 20:41:51 -0300 [thread overview]
Message-ID: <20140223234150.GA5343@localhost> (raw)
In-Reply-To: <20140223212040.22529.18650@quantum>
Tomasz, Mike:
On Sun, Feb 23, 2014 at 01:20:40PM -0800, Mike Turquette wrote:
> Quoting Tomasz Figa (2014-02-23 10:46:35)
> > On 10.02.2014 18:42, Gregory CLEMENT wrote:
> > > Until now the clock providers were initialized in the order found in
> > > the device tree. This led to have the dependencies between the clocks
> > > not respected: children clocks could be initialized before their
> > > parent clocks.
> > >
> > > Instead of forcing each platform to manage its own initialization order,
> > > this patch adds this work inside the framework itself.
> > >
> > > Using the data of the device tree the of_clk_init function now delayed
> > > the initialization of a clock provider if its parent provider was not
> > > ready yet.
> >
> > In general this is really great. It's a first step towards sorting out
> > dependencies between clock providers correctly. I have some comments
> > inline, though.
>
> Just to add in here, I think the approach is good but agree with Tomasz'
> review comments.
>
I'm wondering if any of you has followed the discussion that Greg,
Emilio and I had about the need of this change.
If so, can you point out *why* we need to sort out registration
dependency?
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Mike Turquette <mturquette@linaro.org>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2] clk: respect the clock dependencies in of_clk_init
Date: Sun, 23 Feb 2014 20:41:51 -0300 [thread overview]
Message-ID: <20140223234150.GA5343@localhost> (raw)
In-Reply-To: <20140223212040.22529.18650@quantum>
Tomasz, Mike:
On Sun, Feb 23, 2014 at 01:20:40PM -0800, Mike Turquette wrote:
> Quoting Tomasz Figa (2014-02-23 10:46:35)
> > On 10.02.2014 18:42, Gregory CLEMENT wrote:
> > > Until now the clock providers were initialized in the order found in
> > > the device tree. This led to have the dependencies between the clocks
> > > not respected: children clocks could be initialized before their
> > > parent clocks.
> > >
> > > Instead of forcing each platform to manage its own initialization order,
> > > this patch adds this work inside the framework itself.
> > >
> > > Using the data of the device tree the of_clk_init function now delayed
> > > the initialization of a clock provider if its parent provider was not
> > > ready yet.
> >
> > In general this is really great. It's a first step towards sorting out
> > dependencies between clock providers correctly. I have some comments
> > inline, though.
>
> Just to add in here, I think the approach is good but agree with Tomasz'
> review comments.
>
I'm wondering if any of you has followed the discussion that Greg,
Emilio and I had about the need of this change.
If so, can you point out *why* we need to sort out registration
dependency?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-23 23:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 17:42 [PATCH v2] clk: respect the clock dependencies in of_clk_init Gregory CLEMENT
2014-02-10 17:42 ` Gregory CLEMENT
2014-02-11 16:32 ` Thomas Petazzoni
2014-02-11 16:32 ` Thomas Petazzoni
2014-02-17 14:31 ` Gregory CLEMENT
2014-02-17 14:31 ` Gregory CLEMENT
2014-02-23 18:46 ` Tomasz Figa
2014-02-23 18:46 ` Tomasz Figa
2014-02-23 21:20 ` Mike Turquette
2014-02-23 21:20 ` Mike Turquette
2014-02-23 23:41 ` Ezequiel Garcia [this message]
2014-02-23 23:41 ` Ezequiel Garcia
2014-02-24 0:01 ` Mike Turquette
2014-02-24 17:49 ` Gregory CLEMENT
2014-02-24 17:49 ` Gregory CLEMENT
2014-02-25 1:03 ` Mike Turquette
2014-02-25 1:03 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140223234150.GA5343@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.