From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] clk: respect the clock dependencies in of_clk_init
Date: Mon, 24 Feb 2014 17:03:47 -0800 [thread overview]
Message-ID: <20140225010347.22529.41519@quantum> (raw)
In-Reply-To: <530B8627.4020705@free-electrons.com>
Quoting Gregory CLEMENT (2014-02-24 09:49:27)
> On 23/02/2014 19:46, Tomasz Figa wrote:
> > On 10.02.2014 18:42, Gregory CLEMENT wrote:
> >> +
> >> + for (i = 0; i < num_parents; i++) {
> >> + if (of_parse_phandle_with_args(np, "clocks", "#clock-cells", i,
> >> + &clkspec))
> >> + return 1;
> >> +
> >> + /* Check if we have such a provider in our array */
> >> + found = false;
> >> + list_for_each_entry(provider, &of_clk_providers, link) {
> >> + if (provider->node == clkspec.np) {
> >> + found = true;
> >> + break;
> >> + }
> >> + }
> >> +
> >> + if (!found)
> >> + return 0;
> >> + }
> >
> > ...or even better, __of_clk_get_from_provider() could modified to return
> > -EPROBE_DEFER if requested provider is not registered and you could
>
> There is already a patch sent for this "clk: return probe defer when DT clock
> not yet ready": http://article.gmane.org/gmane.linux.kernel/1643466
>
> Mike will you take it?
>
> Then I can use it to implement the suggestion made by Tomasz.
I have just merged it to clk-next. I'll push out an updated clk-next
branch later tonight.
Regards,
Mike
WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette@linaro.org>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>,
"Tomasz Figa" <tomasz.figa@gmail.com>
Cc: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Jason Cooper" <jason@lakedaemon.net>,
linux-kernel@vger.kernel.org,
"Ezequiel Garcia" <ezequiel.garcia@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2] clk: respect the clock dependencies in of_clk_init
Date: Mon, 24 Feb 2014 17:03:47 -0800 [thread overview]
Message-ID: <20140225010347.22529.41519@quantum> (raw)
In-Reply-To: <530B8627.4020705@free-electrons.com>
Quoting Gregory CLEMENT (2014-02-24 09:49:27)
> On 23/02/2014 19:46, Tomasz Figa wrote:
> > On 10.02.2014 18:42, Gregory CLEMENT wrote:
> >> +
> >> + for (i = 0; i < num_parents; i++) {
> >> + if (of_parse_phandle_with_args(np, "clocks", "#clock-cells", i,
> >> + &clkspec))
> >> + return 1;
> >> +
> >> + /* Check if we have such a provider in our array */
> >> + found = false;
> >> + list_for_each_entry(provider, &of_clk_providers, link) {
> >> + if (provider->node == clkspec.np) {
> >> + found = true;
> >> + break;
> >> + }
> >> + }
> >> +
> >> + if (!found)
> >> + return 0;
> >> + }
> >
> > ...or even better, __of_clk_get_from_provider() could modified to return
> > -EPROBE_DEFER if requested provider is not registered and you could
>
> There is already a patch sent for this "clk: return probe defer when DT clock
> not yet ready": http://article.gmane.org/gmane.linux.kernel/1643466
>
> Mike will you take it?
>
> Then I can use it to implement the suggestion made by Tomasz.
I have just merged it to clk-next. I'll push out an updated clk-next
branch later tonight.
Regards,
Mike
next prev parent reply other threads:[~2014-02-25 1:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 17:42 [PATCH v2] clk: respect the clock dependencies in of_clk_init Gregory CLEMENT
2014-02-10 17:42 ` Gregory CLEMENT
2014-02-11 16:32 ` Thomas Petazzoni
2014-02-11 16:32 ` Thomas Petazzoni
2014-02-17 14:31 ` Gregory CLEMENT
2014-02-17 14:31 ` Gregory CLEMENT
2014-02-23 18:46 ` Tomasz Figa
2014-02-23 18:46 ` Tomasz Figa
2014-02-23 21:20 ` Mike Turquette
2014-02-23 21:20 ` Mike Turquette
2014-02-23 23:41 ` Ezequiel Garcia
2014-02-23 23:41 ` Ezequiel Garcia
2014-02-24 0:01 ` Mike Turquette
2014-02-24 17:49 ` Gregory CLEMENT
2014-02-24 17:49 ` Gregory CLEMENT
2014-02-25 1:03 ` Mike Turquette [this message]
2014-02-25 1:03 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225010347.22529.41519@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.