From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: phy: add suspend_halted module param
Date: Wed, 26 Feb 2014 20:10:09 +0100 [thread overview]
Message-ID: <20140226191009.GC14907@lunn.ch> (raw)
In-Reply-To: <CAGVrzcYUfq84ryVET9qNJvyFCnhFdU4c0fOHbNN4eE8_w6qsAQ@mail.gmail.com>
> > As to the comment from davem about not using a kernel parameter. How
> > about turning it all around. Put a boolean parameter into DT PHY node
> > to indicate when it is safe to power down an idle phy?
>
> Ah ah, nice try, but I do not think this belongs in DT, this is purely
> a software issue here, powering up/down the PHY itself works as
> expected.
>
> How about we have this knob a sysfs parameter? This should be easy
> enough to tweak at runtime and debug in case thing go wrong.
With a kernel parameter i can place it into the bootargs of the chosen
node in DT. Solves the problem for everybody with a QNAP box. Same
goes for topkick and any other board which has a broken u-boot. A
sysfs parameter needs setting from user space, so it is not something
we can solve within the kernel.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] net: phy: add suspend_halted module param
Date: Wed, 26 Feb 2014 20:10:09 +0100 [thread overview]
Message-ID: <20140226191009.GC14907@lunn.ch> (raw)
In-Reply-To: <CAGVrzcYUfq84ryVET9qNJvyFCnhFdU4c0fOHbNN4eE8_w6qsAQ@mail.gmail.com>
> > As to the comment from davem about not using a kernel parameter. How
> > about turning it all around. Put a boolean parameter into DT PHY node
> > to indicate when it is safe to power down an idle phy?
>
> Ah ah, nice try, but I do not think this belongs in DT, this is purely
> a software issue here, powering up/down the PHY itself works as
> expected.
>
> How about we have this knob a sysfs parameter? This should be easy
> enough to tweak at runtime and debug in case thing go wrong.
With a kernel parameter i can place it into the bootargs of the chosen
node in DT. Solves the problem for everybody with a QNAP box. Same
goes for topkick and any other board which has a broken u-boot. A
sysfs parameter needs setting from user space, so it is not something
we can solve within the kernel.
Andrew
next prev parent reply other threads:[~2014-02-26 19:10 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 16:58 [PATCH] net: phy: add suspend_halted module param Sebastian Hesselbarth
2014-02-23 16:58 ` Sebastian Hesselbarth
2014-02-23 16:58 ` Sebastian Hesselbarth
2014-02-24 18:20 ` Florian Fainelli
2014-02-24 18:20 ` Florian Fainelli
2014-02-24 23:05 ` David Miller
2014-02-24 23:05 ` David Miller
2014-02-24 23:05 ` David Miller
2014-02-24 23:34 ` Sebastian Hesselbarth
2014-02-24 23:34 ` Sebastian Hesselbarth
2014-02-24 19:15 ` Andrew Lunn
2014-02-24 19:15 ` Andrew Lunn
2014-02-24 19:37 ` Florian Fainelli
2014-02-24 19:37 ` Florian Fainelli
2014-02-24 19:39 ` Andrew Lunn
2014-02-24 19:39 ` Andrew Lunn
2014-02-25 22:38 ` Sebastian Hesselbarth
2014-02-25 22:38 ` Sebastian Hesselbarth
2014-02-26 18:21 ` Andrew Lunn
2014-02-26 18:21 ` Andrew Lunn
2014-02-26 18:30 ` Florian Fainelli
2014-02-26 18:30 ` Florian Fainelli
2014-02-26 19:10 ` Andrew Lunn [this message]
2014-02-26 19:10 ` Andrew Lunn
2014-02-26 19:35 ` Florian Fainelli
2014-02-26 19:35 ` Florian Fainelli
2014-02-26 20:22 ` Andrew Lunn
2014-02-26 20:22 ` Andrew Lunn
2014-03-07 11:34 ` [PATCH] net: phy: Add sysfs attribute to prevent PHY suspend Sebastian Hesselbarth
2014-03-07 11:34 ` Sebastian Hesselbarth
2014-03-08 1:09 ` Florian Fainelli
2014-03-08 1:09 ` Florian Fainelli
2014-03-09 23:12 ` David Miller
2014-03-09 23:12 ` David Miller
2014-03-09 23:25 ` Sebastian Hesselbarth
2014-03-09 23:25 ` Sebastian Hesselbarth
2014-03-10 0:30 ` David Miller
2014-03-10 0:30 ` David Miller
2014-03-10 0:37 ` Sebastian Hesselbarth
2014-03-10 0:37 ` Sebastian Hesselbarth
2014-03-10 0:41 ` David Miller
2014-03-10 0:41 ` David Miller
2014-03-10 0:53 ` Sebastian Hesselbarth
2014-03-10 0:53 ` Sebastian Hesselbarth
2014-03-10 3:40 ` David Miller
2014-03-10 3:40 ` David Miller
2014-03-10 10:28 ` Sebastian Hesselbarth
2014-03-10 10:28 ` Sebastian Hesselbarth
2014-03-10 14:25 ` One Thousand Gnomes
2014-03-10 14:25 ` One Thousand Gnomes
2014-03-10 16:56 ` Florian Fainelli
2014-03-10 16:56 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226191009.GC14907@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.