From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: phy: Add sysfs attribute to prevent PHY suspend
Date: Mon, 10 Mar 2014 01:53:33 +0100 [thread overview]
Message-ID: <531D0D0D.4050703@gmail.com> (raw)
In-Reply-To: <20140309.204101.47552917508273123.davem@davemloft.net>
On 03/10/2014 01:41 AM, David Miller wrote:
> From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Date: Mon, 10 Mar 2014 01:37:32 +0100
>
>> The mechanism is manual, no automatic way to determine it.
>
> We recognize BIOS and ACPI bugs and work around them, by looking at
> version information and whatnot, so you really can't convince me that
> something similar can't be done here perhaps in the platform code.
Hmm, if the is a way to determine the version of that particual u-boot
I'd be happy to exploit that information. But I honestly doubt that.
Compared to u-boot bootloader and kernel interaction, BIOS and ACPI
are well-defined protocols.
I personally, would prefer everybody should update his broken
bootloaders, but that will just not happen.
Anyway, at least for the two boards in question, we know a bootloader
workaround. The version does support user commands to re-enable the PHY
by writing the corresponding registers.
Unfortunately, the is a bug in phy_ethtool_get_wol that up to now,
prevents most PHYs (without .wol callbacks) from being suspended.
I wanted to get in a way to disable suspend before sending a fix.
If you are that against a sysfs knob, I guess, we will just see how
many more bootloaders are broken and some will not have a way to write
PHY registers.
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: rob@landley.net, andrew@lunn.ch, f.fainelli@gmail.com,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: Add sysfs attribute to prevent PHY suspend
Date: Mon, 10 Mar 2014 01:53:33 +0100 [thread overview]
Message-ID: <531D0D0D.4050703@gmail.com> (raw)
In-Reply-To: <20140309.204101.47552917508273123.davem@davemloft.net>
On 03/10/2014 01:41 AM, David Miller wrote:
> From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Date: Mon, 10 Mar 2014 01:37:32 +0100
>
>> The mechanism is manual, no automatic way to determine it.
>
> We recognize BIOS and ACPI bugs and work around them, by looking at
> version information and whatnot, so you really can't convince me that
> something similar can't be done here perhaps in the platform code.
Hmm, if the is a way to determine the version of that particual u-boot
I'd be happy to exploit that information. But I honestly doubt that.
Compared to u-boot bootloader and kernel interaction, BIOS and ACPI
are well-defined protocols.
I personally, would prefer everybody should update his broken
bootloaders, but that will just not happen.
Anyway, at least for the two boards in question, we know a bootloader
workaround. The version does support user commands to re-enable the PHY
by writing the corresponding registers.
Unfortunately, the is a bug in phy_ethtool_get_wol that up to now,
prevents most PHYs (without .wol callbacks) from being suspended.
I wanted to get in a way to disable suspend before sending a fix.
If you are that against a sysfs knob, I guess, we will just see how
many more bootloaders are broken and some will not have a way to write
PHY registers.
Sebastian
next prev parent reply other threads:[~2014-03-10 0:53 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 16:58 [PATCH] net: phy: add suspend_halted module param Sebastian Hesselbarth
2014-02-23 16:58 ` Sebastian Hesselbarth
2014-02-23 16:58 ` Sebastian Hesselbarth
2014-02-24 18:20 ` Florian Fainelli
2014-02-24 18:20 ` Florian Fainelli
2014-02-24 23:05 ` David Miller
2014-02-24 23:05 ` David Miller
2014-02-24 23:05 ` David Miller
2014-02-24 23:34 ` Sebastian Hesselbarth
2014-02-24 23:34 ` Sebastian Hesselbarth
2014-02-24 19:15 ` Andrew Lunn
2014-02-24 19:15 ` Andrew Lunn
2014-02-24 19:37 ` Florian Fainelli
2014-02-24 19:37 ` Florian Fainelli
2014-02-24 19:39 ` Andrew Lunn
2014-02-24 19:39 ` Andrew Lunn
2014-02-25 22:38 ` Sebastian Hesselbarth
2014-02-25 22:38 ` Sebastian Hesselbarth
2014-02-26 18:21 ` Andrew Lunn
2014-02-26 18:21 ` Andrew Lunn
2014-02-26 18:30 ` Florian Fainelli
2014-02-26 18:30 ` Florian Fainelli
2014-02-26 19:10 ` Andrew Lunn
2014-02-26 19:10 ` Andrew Lunn
2014-02-26 19:35 ` Florian Fainelli
2014-02-26 19:35 ` Florian Fainelli
2014-02-26 20:22 ` Andrew Lunn
2014-02-26 20:22 ` Andrew Lunn
2014-03-07 11:34 ` [PATCH] net: phy: Add sysfs attribute to prevent PHY suspend Sebastian Hesselbarth
2014-03-07 11:34 ` Sebastian Hesselbarth
2014-03-08 1:09 ` Florian Fainelli
2014-03-08 1:09 ` Florian Fainelli
2014-03-09 23:12 ` David Miller
2014-03-09 23:12 ` David Miller
2014-03-09 23:25 ` Sebastian Hesselbarth
2014-03-09 23:25 ` Sebastian Hesselbarth
2014-03-10 0:30 ` David Miller
2014-03-10 0:30 ` David Miller
2014-03-10 0:37 ` Sebastian Hesselbarth
2014-03-10 0:37 ` Sebastian Hesselbarth
2014-03-10 0:41 ` David Miller
2014-03-10 0:41 ` David Miller
2014-03-10 0:53 ` Sebastian Hesselbarth [this message]
2014-03-10 0:53 ` Sebastian Hesselbarth
2014-03-10 3:40 ` David Miller
2014-03-10 3:40 ` David Miller
2014-03-10 10:28 ` Sebastian Hesselbarth
2014-03-10 10:28 ` Sebastian Hesselbarth
2014-03-10 14:25 ` One Thousand Gnomes
2014-03-10 14:25 ` One Thousand Gnomes
2014-03-10 16:56 ` Florian Fainelli
2014-03-10 16:56 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531D0D0D.4050703@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.