All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Vlad Yasevich <vyasevic@redhat.com>,
	netdev@vger.kernel.org, shemminger@vyatta.com,
	bridge@lists.linux-foundation.org, john.r.fastabend@intel.com
Subject: Re: [Bridge] [PATCH RFC 0/7] Non-promisc bidge ports support
Date: Thu, 27 Feb 2014 09:20:06 +0200	[thread overview]
Message-ID: <20140227072006.GD16484@redhat.com> (raw)
In-Reply-To: <530E7FE1.5060705@mojatatu.com>

On Wed, Feb 26, 2014 at 06:59:29PM -0500, Jamal Hadi Salim wrote:
> On 02/26/14 10:18, Vlad Yasevich wrote:
> >This patch series is a complete re-design and re-implementation of
> >prior attempts to support non-promiscuous bridge ports.
> >
> >The basic design is as follows.  The bridge keeps track of
> >all the ports that flood packets to unknown destinations.  If
> >the flooding is disabled on the port, to get traffic to flow
> >through, user/management would need to add an fdb describing
> >such traffic.  When such fdb is added, we save the address
> >to bridge private hardware address list.
> 
> Entering the addresses in the uc list on other bridgeports seems
> reasonable for the scenario described.
> But would it _also_ need to be added to the fdb of the bridge?
> i.e how does the bridge (if the packet was to be handed to it)
> know where to forward?
> BTW: on the comment that flooding off implies learning off: I would like
> to be able to turn off flooding on a specific bridge port but
> still want to learn from it. I dont think those two are mutually
> exclusive.
> 
> cheers,
> jamal

I agree.

It seems a reasonable tradeoff to limit any specific
optimization to !flood && !learn if this simplifies the
implementation significantly and if everything works
as it did before even with learning on.


-- 
MST

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Vlad Yasevich <vyasevic@redhat.com>,
	netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	shemminger@vyatta.com, john.r.fastabend@intel.com
Subject: Re: [PATCH RFC 0/7] Non-promisc bidge ports support
Date: Thu, 27 Feb 2014 09:20:06 +0200	[thread overview]
Message-ID: <20140227072006.GD16484@redhat.com> (raw)
In-Reply-To: <530E7FE1.5060705@mojatatu.com>

On Wed, Feb 26, 2014 at 06:59:29PM -0500, Jamal Hadi Salim wrote:
> On 02/26/14 10:18, Vlad Yasevich wrote:
> >This patch series is a complete re-design and re-implementation of
> >prior attempts to support non-promiscuous bridge ports.
> >
> >The basic design is as follows.  The bridge keeps track of
> >all the ports that flood packets to unknown destinations.  If
> >the flooding is disabled on the port, to get traffic to flow
> >through, user/management would need to add an fdb describing
> >such traffic.  When such fdb is added, we save the address
> >to bridge private hardware address list.
> 
> Entering the addresses in the uc list on other bridgeports seems
> reasonable for the scenario described.
> But would it _also_ need to be added to the fdb of the bridge?
> i.e how does the bridge (if the packet was to be handed to it)
> know where to forward?
> BTW: on the comment that flooding off implies learning off: I would like
> to be able to turn off flooding on a specific bridge port but
> still want to learn from it. I dont think those two are mutually
> exclusive.
> 
> cheers,
> jamal

I agree.

It seems a reasonable tradeoff to limit any specific
optimization to !flood && !learn if this simplifies the
implementation significantly and if everything works
as it did before even with learning on.


-- 
MST

  parent reply	other threads:[~2014-02-27  7:20 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26 15:18 [Bridge] [PATCH RFC 0/7] Non-promisc bidge ports support Vlad Yasevich
2014-02-26 15:18 ` Vlad Yasevich
2014-02-26 15:18 ` [Bridge] [PATCH 1/7] bridge: Turn flag change macro into a function Vlad Yasevich
2014-02-26 15:18   ` Vlad Yasevich
2014-02-26 15:29   ` [Bridge] " Michael S. Tsirkin
2014-02-26 15:29     ` Michael S. Tsirkin
2014-02-26 15:36     ` [Bridge] " Vlad Yasevich
2014-02-26 15:36       ` Vlad Yasevich
2014-02-26 15:18 ` [Bridge] [PATCH 2/7] bridge: Keep track of ports capable of flooding Vlad Yasevich
2014-02-26 15:18   ` Vlad Yasevich
2014-02-26 15:41   ` [Bridge] " Michael S. Tsirkin
2014-02-26 15:41     ` Michael S. Tsirkin
2014-02-26 15:41     ` [Bridge] " Vlad Yasevich
2014-02-26 15:41       ` Vlad Yasevich
2014-02-26 15:53       ` [Bridge] " Michael S. Tsirkin
2014-02-26 15:53         ` Michael S. Tsirkin
2014-02-27 11:59   ` [Bridge] " Toshiaki Makita
2014-02-27 11:59     ` Toshiaki Makita
2014-02-27 12:54     ` [Bridge] " Vlad Yasevich
2014-02-27 12:54       ` Vlad Yasevich
2014-02-26 15:18 ` [Bridge] [PATCH 3/7] bridge: Add addresses from static fdbs to bridge address list Vlad Yasevich
2014-02-26 15:18   ` Vlad Yasevich
2014-02-26 15:46   ` [Bridge] " Michael S. Tsirkin
2014-02-26 15:46     ` Michael S. Tsirkin
2014-02-26 15:43     ` [Bridge] " Vlad Yasevich
2014-02-26 15:43       ` Vlad Yasevich
2014-02-26 16:23   ` [Bridge] " Michael S. Tsirkin
2014-02-26 16:23     ` Michael S. Tsirkin
2014-02-26 17:25     ` [Bridge] " Vlad Yasevich
2014-02-26 17:25       ` Vlad Yasevich
2014-02-26 17:33       ` [Bridge] " Michael S. Tsirkin
2014-02-26 17:33         ` Michael S. Tsirkin
2014-02-26 16:57   ` [Bridge] " Stephen Hemminger
2014-02-26 16:57     ` Stephen Hemminger
2014-02-26 17:35     ` [Bridge] " Vlad Yasevich
2014-02-26 17:35       ` Vlad Yasevich
2014-02-27  7:53       ` [Bridge] " Michael S. Tsirkin
2014-02-27  7:53         ` Michael S. Tsirkin
2014-02-27 13:08         ` [Bridge] " Vlad Yasevich
2014-02-27 13:08           ` Vlad Yasevich
2014-02-27 13:38           ` [Bridge] " Michael S. Tsirkin
2014-02-27 13:38             ` Michael S. Tsirkin
2014-02-26 15:18 ` [Bridge] [PATCH 4/7] bridge: Automatically manage port promiscuous mode Vlad Yasevich
2014-02-26 15:18   ` Vlad Yasevich
2014-02-26 15:51   ` [Bridge] " Michael S. Tsirkin
2014-02-26 15:51     ` Michael S. Tsirkin
2014-02-26 16:02     ` [Bridge] " Vlad Yasevich
2014-02-26 16:02       ` Vlad Yasevich
2014-02-26 16:58   ` [Bridge] " Stephen Hemminger
2014-02-26 16:58     ` Stephen Hemminger
2014-02-26 17:32     ` [Bridge] " Michael S. Tsirkin
2014-02-26 17:32       ` Michael S. Tsirkin
2014-02-26 15:18 ` [Bridge] [PATCH 5/7] bridge: Correctly manage promiscuity when user requested it Vlad Yasevich
2014-02-26 15:18   ` Vlad Yasevich
2014-02-26 15:18 ` [Bridge] [PATCH 6/7] bridge: Manage promisc mode when vlans are configured on top of a bridge Vlad Yasevich
2014-02-26 15:18   ` Vlad Yasevich
2014-02-26 16:00   ` [Bridge] " Michael S. Tsirkin
2014-02-26 16:00     ` Michael S. Tsirkin
2014-02-26 16:05     ` [Bridge] " Vlad Yasevich
2014-02-26 16:05       ` Vlad Yasevich
2014-02-26 16:25       ` [Bridge] " Michael S. Tsirkin
2014-02-26 16:25         ` Michael S. Tsirkin
2014-02-27 12:06   ` [Bridge] " Toshiaki Makita
2014-02-27 12:06     ` Toshiaki Makita
2014-02-27 13:17     ` [Bridge] " Vlad Yasevich
2014-02-27 13:17       ` Vlad Yasevich
2014-02-28 19:34       ` [Bridge] " Vlad Yasevich
2014-02-28 19:34         ` Vlad Yasevich
2014-03-01 14:57         ` [Bridge] " Toshiaki Makita
2014-03-01 14:57           ` Toshiaki Makita
2014-03-03 12:12           ` [Bridge] " Vlad Yasevich
2014-03-03 12:12             ` Vlad Yasevich
2014-02-26 15:18 ` [Bridge] [PATCH 7/7] bridge: Support promisc management when all ports are non-flooding Vlad Yasevich
2014-02-26 15:18   ` Vlad Yasevich
2014-02-26 15:57   ` [Bridge] " Michael S. Tsirkin
2014-02-26 15:57     ` Michael S. Tsirkin
2014-02-27  3:46     ` [Bridge] " Vlad Yasevich
2014-02-27  3:46       ` Vlad Yasevich
2014-02-27  7:29       ` [Bridge] " Michael S. Tsirkin
2014-02-27  7:29         ` Michael S. Tsirkin
2014-02-26 16:01   ` [Bridge] " Michael S. Tsirkin
2014-02-26 16:01     ` Michael S. Tsirkin
2014-02-26 16:34 ` [Bridge] [PATCH RFC 0/7] Non-promisc bidge ports support Michael S. Tsirkin
2014-02-26 16:34   ` Michael S. Tsirkin
2014-02-26 23:59 ` [Bridge] " Jamal Hadi Salim
2014-02-26 23:59   ` Jamal Hadi Salim
2014-02-27  3:37   ` [Bridge] " Vlad Yasevich
2014-02-27  3:37     ` Vlad Yasevich
2014-02-27  8:54     ` [Bridge] " Amidu Sila
2014-02-27  7:20   ` Michael S. Tsirkin [this message]
2014-02-27  7:20     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140227072006.GD16484@redhat.com \
    --to=mst@redhat.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=jhs@mojatatu.com \
    --cc=john.r.fastabend@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.