From: Lee Jones <lee.jones@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/8] mfd: Move pm8xxx-irq.c contents into only driver that uses it
Date: Thu, 27 Feb 2014 08:33:39 +0000 [thread overview]
Message-ID: <20140227083339.GU9195@lee--X1> (raw)
In-Reply-To: <1393441166-32692-2-git-send-email-sboyd@codeaurora.org>
> The pm8xxx-irq.c code is practically mandatory given that the
> pm8921-core driver will WARN about it missing and the Kconfig
> marks it as default y when a PM8xxx chips is enabled. The only
> reason the file was split out was because we planned to support
> other pm8xxx chips with different pm8xxx-core.c files. Now that
> we have DT on ARM this isn't necessary because we should be able
> to support all the ssbi based PM8xxx chips in one driver and one
> file with no data bloat. Let's move this code into the only
> driver that uses it right now (pm8921) so that it's always compiled when
> needed. In the future we can rename pm8921-core.c to something
> more generic.
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/mfd/Kconfig | 10 --
> drivers/mfd/Makefile | 1 -
> drivers/mfd/pm8921-core.c | 348 ++++++++++++++++++++++++++++++++++++++
> drivers/mfd/pm8xxx-irq.c | 371 -----------------------------------------
> include/linux/mfd/pm8xxx/irq.h | 23 ---
> 5 files changed, 348 insertions(+), 405 deletions(-)
> delete mode 100644 drivers/mfd/pm8xxx-irq.c
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/8] mfd: Move pm8xxx-irq.c contents into only driver that uses it
Date: Thu, 27 Feb 2014 08:33:39 +0000 [thread overview]
Message-ID: <20140227083339.GU9195@lee--X1> (raw)
In-Reply-To: <1393441166-32692-2-git-send-email-sboyd@codeaurora.org>
> The pm8xxx-irq.c code is practically mandatory given that the
> pm8921-core driver will WARN about it missing and the Kconfig
> marks it as default y when a PM8xxx chips is enabled. The only
> reason the file was split out was because we planned to support
> other pm8xxx chips with different pm8xxx-core.c files. Now that
> we have DT on ARM this isn't necessary because we should be able
> to support all the ssbi based PM8xxx chips in one driver and one
> file with no data bloat. Let's move this code into the only
> driver that uses it right now (pm8921) so that it's always compiled when
> needed. In the future we can rename pm8921-core.c to something
> more generic.
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/mfd/Kconfig | 10 --
> drivers/mfd/Makefile | 1 -
> drivers/mfd/pm8921-core.c | 348 ++++++++++++++++++++++++++++++++++++++
> drivers/mfd/pm8xxx-irq.c | 371 -----------------------------------------
> include/linux/mfd/pm8xxx/irq.h | 23 ---
> 5 files changed, 348 insertions(+), 405 deletions(-)
> delete mode 100644 drivers/mfd/pm8xxx-irq.c
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-02-27 8:33 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 18:59 [PATCH v4 0/8] Modernize pm8921 with irqdomains, regmap, DT Stephen Boyd
2014-02-26 18:59 ` Stephen Boyd
2014-02-26 18:59 ` [PATCH v4 1/8] mfd: Move pm8xxx-irq.c contents into only driver that uses it Stephen Boyd
2014-02-26 18:59 ` Stephen Boyd
2014-02-26 18:59 ` Stephen Boyd
2014-02-27 8:33 ` Lee Jones [this message]
2014-02-27 8:33 ` Lee Jones
2014-02-26 18:59 ` [PATCH v4 2/8] mfd: pm8921: Update for genirq changes Stephen Boyd
2014-02-26 18:59 ` Stephen Boyd
2014-02-27 8:34 ` Lee Jones
2014-02-27 8:34 ` Lee Jones
2014-02-26 18:59 ` [PATCH v4 3/8] mfd: pm8921: Migrate to irqdomains Stephen Boyd
2014-02-26 18:59 ` Stephen Boyd
2014-02-26 18:59 ` Stephen Boyd
2014-02-27 8:34 ` Lee Jones
2014-02-27 8:34 ` Lee Jones
2014-02-26 18:59 ` [PATCH v4 4/8] mfd: ssbi: Add regmap read/write helpers Stephen Boyd
2014-02-26 18:59 ` Stephen Boyd
2014-02-27 8:35 ` Lee Jones
2014-02-27 8:35 ` Lee Jones
2014-02-26 18:59 ` [PATCH v4 5/8] mfd: pm8921: Use ssbi regmap Stephen Boyd
2014-02-26 18:59 ` Stephen Boyd
2014-02-27 8:35 ` Lee Jones
2014-02-27 8:35 ` Lee Jones
2014-02-26 18:59 ` [PATCH v4 6/8] mfd: pm8921: Add DT match table Stephen Boyd
2014-02-26 18:59 ` Stephen Boyd
2014-02-27 8:35 ` Lee Jones
2014-02-27 8:35 ` Lee Jones
2014-02-26 18:59 ` [PATCH v4 7/8] mfd: pm8921: Loosen Kconfig dependency Stephen Boyd
2014-02-26 18:59 ` Stephen Boyd
2014-02-27 8:37 ` Lee Jones
2014-02-27 8:37 ` Lee Jones
2014-02-26 18:59 ` [PATCH v4 8/8] devicetree: bindings: Document PM8921/8058 PMICs Stephen Boyd
2014-02-26 18:59 ` Stephen Boyd
2014-02-26 18:59 ` Stephen Boyd
2014-02-27 8:38 ` Lee Jones
2014-02-27 8:38 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227083339.GU9195@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.