From: Dan Carpenter <dan.carpenter@oracle.com>
To: Matt Fleming <matt.fleming@intel.com>, Nathan Zimmer <nzimmer@sgi.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-efi@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [patch] x86/efi: use GFP_ATOMIC under spin_lock
Date: Fri, 07 Mar 2014 11:20:56 +0000 [thread overview]
Message-ID: <20140307112055.GE2351@elgon.mountain> (raw)
In phys_efi_get_time() we call efi_call_phys_prelog() with a spin_lock
so this allocation should be atomic.
Fixes: b8f2c21db390 ('efi, x86: Pass a proper identity mapping in efi_call_phys_prelog')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c
index 0c2a234fef1e..f5adcadb381b 100644
--- a/arch/x86/platform/efi/efi_64.c
+++ b/arch/x86/platform/efi/efi_64.c
@@ -90,7 +90,7 @@ void __init efi_call_phys_prelog(void)
local_irq_save(efi_flags);
n_pgds = DIV_ROUND_UP((max_pfn << PAGE_SHIFT), PGDIR_SIZE);
- save_pgd = kmalloc(n_pgds * sizeof(pgd_t), GFP_KERNEL);
+ save_pgd = kmalloc(n_pgds * sizeof(pgd_t), GFP_ATOMIC);
for (pgd = 0; pgd < n_pgds; pgd++) {
save_pgd[pgd] = *pgd_offset_k(pgd * PGDIR_SIZE);
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Matt Fleming <matt.fleming@intel.com>, Nathan Zimmer <nzimmer@sgi.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-efi@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [patch] x86/efi: use GFP_ATOMIC under spin_lock
Date: Fri, 7 Mar 2014 14:20:56 +0300 [thread overview]
Message-ID: <20140307112055.GE2351@elgon.mountain> (raw)
In phys_efi_get_time() we call efi_call_phys_prelog() with a spin_lock
so this allocation should be atomic.
Fixes: b8f2c21db390 ('efi, x86: Pass a proper identity mapping in efi_call_phys_prelog')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c
index 0c2a234fef1e..f5adcadb381b 100644
--- a/arch/x86/platform/efi/efi_64.c
+++ b/arch/x86/platform/efi/efi_64.c
@@ -90,7 +90,7 @@ void __init efi_call_phys_prelog(void)
local_irq_save(efi_flags);
n_pgds = DIV_ROUND_UP((max_pfn << PAGE_SHIFT), PGDIR_SIZE);
- save_pgd = kmalloc(n_pgds * sizeof(pgd_t), GFP_KERNEL);
+ save_pgd = kmalloc(n_pgds * sizeof(pgd_t), GFP_ATOMIC);
for (pgd = 0; pgd < n_pgds; pgd++) {
save_pgd[pgd] = *pgd_offset_k(pgd * PGDIR_SIZE);
next reply other threads:[~2014-03-07 11:20 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 11:20 Dan Carpenter [this message]
2014-03-07 11:20 ` [patch] x86/efi: use GFP_ATOMIC under spin_lock Dan Carpenter
[not found] ` <20140307112055.GE2351-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2014-03-07 12:10 ` Ingo Molnar
2014-03-07 12:10 ` Ingo Molnar
[not found] ` <20140307121022.GA32575-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-07 12:25 ` Dan Carpenter
2014-03-07 12:25 ` Dan Carpenter
2014-03-09 6:48 ` Ingo Molnar
2014-03-09 6:48 ` Ingo Molnar
2014-03-09 7:14 ` Dan Carpenter
2014-03-09 7:14 ` Dan Carpenter
2014-03-09 16:20 ` Matt Fleming
2014-03-09 16:20 ` Matt Fleming
2014-03-09 16:31 ` Matthew Garrett
2014-03-09 16:31 ` Matthew Garrett
[not found] ` <20140309163141.GA18824-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2014-03-09 18:50 ` Matt Fleming
2014-03-09 18:50 ` Matt Fleming
2014-03-09 19:00 ` Matthew Garrett
2014-03-09 19:00 ` Matthew Garrett
[not found] ` <20140309190053.GA29555-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2014-03-10 9:10 ` Matt Fleming
2014-03-10 9:10 ` Matt Fleming
[not found] ` <20140309185028.GB10262-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-03-10 7:27 ` Jan Beulich
2014-03-10 7:27 ` Jan Beulich
2014-03-10 7:37 ` Ingo Molnar
2014-03-10 7:37 ` Ingo Molnar
2014-03-10 7:45 ` Jan Beulich
2014-03-10 7:53 ` Ingo Molnar
2014-03-10 7:53 ` Ingo Molnar
2014-03-10 8:22 ` Jan Beulich
2014-03-10 10:43 ` Matt Fleming
[not found] ` <20140310104328.GG10262-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-03-10 11:05 ` Jan Beulich
2014-03-10 11:05 ` Jan Beulich
[not found] ` <531DAA7602000078001224EF-ce6RLXgGx+vWGUEhTRrCg1aTQe2KTcn/@public.gmane.org>
2014-03-10 16:10 ` Matt Fleming
2014-03-10 16:10 ` Matt Fleming
2014-03-14 23:02 ` Matt Fleming
2014-03-14 23:02 ` Matt Fleming
2014-03-10 9:12 ` Matt Fleming
2014-03-10 7:26 ` Jan Beulich
2014-03-10 17:07 ` Dan Carpenter
2014-03-10 17:07 ` Dan Carpenter
2014-03-09 7:36 ` Dan Carpenter
2014-03-09 7:36 ` Dan Carpenter
2014-03-10 16:47 ` H. Peter Anvin
2014-03-10 16:47 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307112055.GE2351@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=nzimmer@sgi.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.