From: Lee Jones <lee.jones@linaro.org>
To: Roger Quadros <rogerq@ti.com>
Cc: tony@atomide.com, bcousson@baylibre.com, balbi@ti.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH v9 2/9] mfd: omap-usb-host: Always fail on clk_get() error
Date: Mon, 10 Mar 2014 14:17:54 +0000 [thread overview]
Message-ID: <20140310141754.GC15558@lee--X1> (raw)
In-Reply-To: <1393510711-4697-3-git-send-email-rogerq@ti.com>
> Be more strict and always fail on clk_get() error.
>
> CC: Lee Jones <lee.jones@linaro.org>
> CC: Samuel Ortiz <sameo@linux.intel.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/mfd/omap-usb-host.c | 62 +++++++++++++++++++++++++++++----------------
> 1 file changed, 40 insertions(+), 22 deletions(-)
I like to principle of the patch assuming that the devices would be
useless without their clocks.
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 2/9] mfd: omap-usb-host: Always fail on clk_get() error
Date: Mon, 10 Mar 2014 14:17:54 +0000 [thread overview]
Message-ID: <20140310141754.GC15558@lee--X1> (raw)
In-Reply-To: <1393510711-4697-3-git-send-email-rogerq@ti.com>
> Be more strict and always fail on clk_get() error.
>
> CC: Lee Jones <lee.jones@linaro.org>
> CC: Samuel Ortiz <sameo@linux.intel.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/mfd/omap-usb-host.c | 62 +++++++++++++++++++++++++++++----------------
> 1 file changed, 40 insertions(+), 22 deletions(-)
I like to principle of the patch assuming that the devices would be
useless without their clocks.
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Roger Quadros <rogerq@ti.com>
Cc: tony@atomide.com, bcousson@baylibre.com, balbi@ti.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH v9 2/9] mfd: omap-usb-host: Always fail on clk_get() error
Date: Mon, 10 Mar 2014 14:17:54 +0000 [thread overview]
Message-ID: <20140310141754.GC15558@lee--X1> (raw)
In-Reply-To: <1393510711-4697-3-git-send-email-rogerq@ti.com>
> Be more strict and always fail on clk_get() error.
>
> CC: Lee Jones <lee.jones@linaro.org>
> CC: Samuel Ortiz <sameo@linux.intel.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/mfd/omap-usb-host.c | 62 +++++++++++++++++++++++++++++----------------
> 1 file changed, 40 insertions(+), 22 deletions(-)
I like to principle of the patch assuming that the devices would be
useless without their clocks.
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-03-10 14:17 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 14:18 [PATCH v9 0/9] USB Host support for OMAP5 uEVM Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-02-27 14:18 ` [PATCH v9 1/9] mfd: omap-usb-host: Get clocks based on hardware revision Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-03-10 14:14 ` Lee Jones
2014-03-10 14:14 ` Lee Jones
2014-03-10 14:14 ` Lee Jones
2014-02-27 14:18 ` [PATCH v9 2/9] mfd: omap-usb-host: Always fail on clk_get() error Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-03-10 14:17 ` Lee Jones [this message]
2014-03-10 14:17 ` Lee Jones
2014-03-10 14:17 ` Lee Jones
2014-02-27 14:18 ` [PATCH v9 3/9] mfd: omap-usb-host: Use proper clock name instead of alias Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-03-10 14:32 ` Lee Jones
2014-03-10 14:32 ` Lee Jones
2014-02-27 14:18 ` [PATCH v9 4/9] mfd: omap-usb-host: Use clock names as per function for reference clocks Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-03-10 14:34 ` Lee Jones
2014-03-10 14:34 ` Lee Jones
2014-03-10 14:34 ` Lee Jones
2014-02-27 14:18 ` [PATCH v9 5/9] mfd: omap-usb-host: Update DT clock binding information Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-02-27 14:18 ` [PATCH v9 6/9] mfd: omap-usb-tll: " Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-02-27 14:18 ` [PATCH v9 7/9] ARM: OMAP2+: Remove legacy_init_ehci_clk() Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-02-27 14:18 ` [PATCH v9 8/9] ARM: dts: OMAP2+: Get rid of incompatible ids for USB host nodes Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-02-27 14:18 ` [PATCH v9 9/9] usb: omap: dts: Update DT binding example usage Roger Quadros
2014-02-27 14:18 ` Roger Quadros
2014-02-27 14:18 ` Roger Quadros
[not found] ` <1393510711-4697-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-02-28 22:56 ` [PATCH v9 0/9] USB Host support for OMAP5 uEVM Tony Lindgren
2014-02-28 22:56 ` Tony Lindgren
2014-02-28 22:56 ` Tony Lindgren
[not found] ` <20140228225627.GU13624-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-03-03 9:34 ` Roger Quadros
2014-03-03 9:34 ` Roger Quadros
2014-03-03 9:34 ` Roger Quadros
[not found] ` <53144CBC.2050607-l0cyMroinI0@public.gmane.org>
2014-03-04 18:47 ` Tony Lindgren
2014-03-04 18:47 ` Tony Lindgren
2014-03-04 18:47 ` Tony Lindgren
2014-03-11 8:48 ` Roger Quadros
2014-03-11 8:48 ` Roger Quadros
2014-03-11 8:48 ` Roger Quadros
[not found] ` <531ECDCB.4060700-l0cyMroinI0@public.gmane.org>
2014-03-11 12:02 ` Lee Jones
2014-03-11 12:02 ` Lee Jones
2014-03-11 12:02 ` Lee Jones
2014-03-11 12:16 ` Roger Quadros
2014-03-11 12:16 ` Roger Quadros
2014-03-11 12:16 ` Roger Quadros
2014-03-11 13:07 ` Lee Jones
2014-03-11 13:07 ` Lee Jones
2014-03-11 13:10 ` Roger Quadros
2014-03-11 13:10 ` Roger Quadros
2014-03-11 13:10 ` Roger Quadros
2014-03-11 16:24 ` Tony Lindgren
2014-03-11 16:24 ` Tony Lindgren
2014-03-13 22:34 ` Lee Jones
2014-03-13 22:34 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310141754.GC15558@lee--X1 \
--to=lee.jones@linaro.org \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.