From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Trilok Soni <tsoni@codeaurora.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org,
Anirudh Ghayal <aghayal@codeaurora.org>,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: Qualcomm PMIC8XXX keypad never worked?
Date: Tue, 11 Mar 2014 13:06:09 +0000 [thread overview]
Message-ID: <20140311130609.GL21216@lee--X1> (raw)
In-Reply-To: <8206209.oc1V5pPVYT@wuerfel>
> > > Something in the MFD_PM8XXX driver must have changed recently that now allows
> > > the KEYBOARD_PMIC8XXX driver to be enabled. Unfortunately, it does not build
> > > because of a dependency on the <linux/mfd/pm8xxx/gpio.h> header file that
> > > does not exist.
> >
> > I have it?
> >
> > -rw-r--r-- 1 lee lee 2147 Dec 18 11:52 include/linux/mfd/pm8xxx/core.h
>
> This is core.h, not gpio.h
Hmmm... so it is. I think I'm going senile!
> > > In order to keep 'make randconfig' working on my test box, I have disabled
> > > this driver, but it would be nice of someone could have a look into fixing it.
> >
> > Can you send me the config that breaks please?
>
> appended below. You might need more patches to build this, but you will get the
> error if you just try building the input driver.
Okay, I've recreated the error.
I think it's this commit that's causing your error:
https://lkml.org/lkml/2013/12/10/903
... but the MFD isn't broken, so I guess your solution is the most
elegant. If it's not fixed soon, I guess we should think about ripping
it out. It's obvoious that no-one cares, as it's been broken for
nearly 3 years.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: Qualcomm PMIC8XXX keypad never worked?
Date: Tue, 11 Mar 2014 13:06:09 +0000 [thread overview]
Message-ID: <20140311130609.GL21216@lee--X1> (raw)
In-Reply-To: <8206209.oc1V5pPVYT@wuerfel>
> > > Something in the MFD_PM8XXX driver must have changed recently that now allows
> > > the KEYBOARD_PMIC8XXX driver to be enabled. Unfortunately, it does not build
> > > because of a dependency on the <linux/mfd/pm8xxx/gpio.h> header file that
> > > does not exist.
> >
> > I have it?
> >
> > -rw-r--r-- 1 lee lee 2147 Dec 18 11:52 include/linux/mfd/pm8xxx/core.h
>
> This is core.h, not gpio.h
Hmmm... so it is. I think I'm going senile!
> > > In order to keep 'make randconfig' working on my test box, I have disabled
> > > this driver, but it would be nice of someone could have a look into fixing it.
> >
> > Can you send me the config that breaks please?
>
> appended below. You might need more patches to build this, but you will get the
> error if you just try building the input driver.
Okay, I've recreated the error.
I think it's this commit that's causing your error:
https://lkml.org/lkml/2013/12/10/903
... but the MFD isn't broken, so I guess your solution is the most
elegant. If it's not fixed soon, I guess we should think about ripping
it out. It's obvoious that no-one cares, as it's been broken for
nearly 3 years.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-03-11 13:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 8:49 Qualcomm PMIC8XXX keypad never worked? Arnd Bergmann
2014-03-11 8:49 ` Arnd Bergmann
2014-03-11 12:00 ` Lee Jones
2014-03-11 12:00 ` Lee Jones
2014-03-11 12:19 ` Arnd Bergmann
2014-03-11 12:19 ` Arnd Bergmann
2014-03-11 13:06 ` Lee Jones [this message]
2014-03-11 13:06 ` Lee Jones
2014-03-11 13:20 ` Qualcomm PMIC8xxx " Josh Cartwright
2014-03-11 13:20 ` Josh Cartwright
2014-03-11 13:35 ` Lee Jones
2014-03-11 13:35 ` Lee Jones
2014-03-11 13:35 ` Lee Jones
2014-03-12 5:18 ` Qualcomm PMIC8XXX " Bjorn Andersson
2014-03-12 5:18 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311130609.GL21216@lee--X1 \
--to=lee.jones@linaro.org \
--cc=aghayal@codeaurora.org \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sboyd@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.