From: mporter@linaro.org (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/5] ARM: dts: add bcm590xx pmu support and enable for bcm28155-ap
Date: Tue, 11 Mar 2014 11:50:54 -0400 [thread overview]
Message-ID: <20140311155054.GL25092@beef> (raw)
In-Reply-To: <20140219044458.GA2669@sirena.org.uk>
On Wed, Feb 19, 2014 at 01:44:58PM +0900, Mark Brown wrote:
> On Tue, Feb 18, 2014 at 06:17:12PM -0500, Matt Porter wrote:
>
> > + csr_reg: regulator at 13 {
> > + reg = <13>;
> > + regulator-compatible = "csr";
> > + regulator-min-microvolt = <860000>;
> > + regulator-max-microvolt = <1440000>;
> > + };
>
> You should not be setting voltage ranges like this in a .dtsi - you've
> no idea if these voltage ranges are in fact valid for any given board so
> they can't be set safely. In general I would not expect to see any
> configuration at all for regulators in an include file for the chip.
Agreed. I moved all constraints where they belong in the board-specific
dts.
Thanks,
Matt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140311/cc0408bb/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Matt Porter <mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Christian Daudt <bcm-xK7y4jjYLqYh9ZMKESR00Q@public.gmane.org>,
Devicetree List
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux ARM Kernel List
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Tim Kryger <tim.kryger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2 5/5] ARM: dts: add bcm590xx pmu support and enable for bcm28155-ap
Date: Tue, 11 Mar 2014 11:50:54 -0400 [thread overview]
Message-ID: <20140311155054.GL25092@beef> (raw)
In-Reply-To: <20140219044458.GA2669-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Wed, Feb 19, 2014 at 01:44:58PM +0900, Mark Brown wrote:
> On Tue, Feb 18, 2014 at 06:17:12PM -0500, Matt Porter wrote:
>
> > + csr_reg: regulator@13 {
> > + reg = <13>;
> > + regulator-compatible = "csr";
> > + regulator-min-microvolt = <860000>;
> > + regulator-max-microvolt = <1440000>;
> > + };
>
> You should not be setting voltage ranges like this in a .dtsi - you've
> no idea if these voltage ranges are in fact valid for any given board so
> they can't be set safely. In general I would not expect to see any
> configuration at all for regulators in an include file for the chip.
Agreed. I moved all constraints where they belong in the board-specific
dts.
Thanks,
Matt
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Matt Porter <mporter@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Christian Daudt <bcm@fixthebug.org>,
Devicetree List <devicetree@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tim Kryger <tim.kryger@linaro.org>
Subject: Re: [PATCH v2 5/5] ARM: dts: add bcm590xx pmu support and enable for bcm28155-ap
Date: Tue, 11 Mar 2014 11:50:54 -0400 [thread overview]
Message-ID: <20140311155054.GL25092@beef> (raw)
In-Reply-To: <20140219044458.GA2669@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Wed, Feb 19, 2014 at 01:44:58PM +0900, Mark Brown wrote:
> On Tue, Feb 18, 2014 at 06:17:12PM -0500, Matt Porter wrote:
>
> > + csr_reg: regulator@13 {
> > + reg = <13>;
> > + regulator-compatible = "csr";
> > + regulator-min-microvolt = <860000>;
> > + regulator-max-microvolt = <1440000>;
> > + };
>
> You should not be setting voltage ranges like this in a .dtsi - you've
> no idea if these voltage ranges are in fact valid for any given board so
> they can't be set safely. In general I would not expect to see any
> configuration at all for regulators in an include file for the chip.
Agreed. I moved all constraints where they belong in the board-specific
dts.
Thanks,
Matt
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-03-11 15:50 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 23:17 [PATCH v2 0/5] BCM59056 PMU regulator support Matt Porter
2014-02-18 23:17 ` Matt Porter
2014-02-18 23:17 ` [PATCH v2 1/5] mfd: add bcm590xx pmu DT binding Matt Porter
2014-02-18 23:17 ` Matt Porter
2014-02-18 23:17 ` Matt Porter
2014-02-19 4:47 ` Mark Brown
2014-02-19 4:47 ` Mark Brown
2014-02-19 4:47 ` Mark Brown
2014-03-11 15:49 ` Matt Porter
2014-03-11 15:49 ` Matt Porter
2014-02-18 23:17 ` [PATCH v2 2/5] mfd: add bcm590xx pmu driver Matt Porter
2014-02-18 23:17 ` Matt Porter
2014-02-19 4:46 ` Mark Brown
2014-02-19 4:46 ` Mark Brown
2014-03-11 15:50 ` Matt Porter
2014-03-11 15:50 ` Matt Porter
2014-03-11 15:50 ` Matt Porter
2014-02-18 23:17 ` [PATCH v2 3/5] regulator: add bcm590xx regulator driver Matt Porter
2014-02-18 23:17 ` Matt Porter
2014-02-19 4:52 ` Mark Brown
2014-02-19 4:52 ` Mark Brown
2014-02-19 4:52 ` Mark Brown
2014-03-11 15:47 ` Matt Porter
2014-03-11 15:47 ` Matt Porter
2014-02-18 23:17 ` [PATCH v2 4/5] ARM: configs: bcm_defconfig: enable bcm590xx regulator support Matt Porter
2014-02-18 23:17 ` Matt Porter
2014-02-18 23:17 ` [PATCH v2 5/5] ARM: dts: add bcm590xx pmu support and enable for bcm28155-ap Matt Porter
2014-02-18 23:17 ` Matt Porter
2014-02-19 4:44 ` Mark Brown
2014-02-19 4:44 ` Mark Brown
2014-03-11 15:50 ` Matt Porter [this message]
2014-03-11 15:50 ` Matt Porter
2014-03-11 15:50 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311155054.GL25092@beef \
--to=mporter@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.