From: Stephen Hemminger <stephen@networkplumber.org>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: kvm@vger.kernel.org, netdev@vger.kernel.org, mcgrof@suse.com,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org
Subject: Re: [Bridge] [PATCH 3/3] bridge: fix bridge root block on designated port
Date: Thu, 13 Mar 2014 15:16:23 -0700 [thread overview]
Message-ID: <20140313151623.03e0484d@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1394680527-28970-4-git-send-email-mcgrof@do-not-panic.com>
On Wed, 12 Mar 2014 20:15:27 -0700
"Luis R. Rodriguez" <mcgrof@do-not-panic.com> wrote:
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -150,6 +150,7 @@ struct net_bridge_port
> u8 priority;
> u8 state;
> u16 port_no;
> + bool root_block_enabled;
> unsigned char topology_change_ack;
It seems a bit confusing to have both a ROOT_BLOCK flag in the
data structure and and additional root_block_enabled flag.
If nothing else it is a waste of space.
Looks like you are changing the meaning slightly. is possible
to have BR_ROOT_BLOCK set but !root_block_enabled? and what about
the inverse?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: kvm@vger.kernel.org, netdev@vger.kernel.org, mcgrof@suse.com,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 3/3] bridge: fix bridge root block on designated port
Date: Thu, 13 Mar 2014 15:16:23 -0700 [thread overview]
Message-ID: <20140313151623.03e0484d@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1394680527-28970-4-git-send-email-mcgrof@do-not-panic.com>
On Wed, 12 Mar 2014 20:15:27 -0700
"Luis R. Rodriguez" <mcgrof@do-not-panic.com> wrote:
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -150,6 +150,7 @@ struct net_bridge_port
> u8 priority;
> u8 state;
> u16 port_no;
> + bool root_block_enabled;
> unsigned char topology_change_ack;
It seems a bit confusing to have both a ROOT_BLOCK flag in the
data structure and and additional root_block_enabled flag.
If nothing else it is a waste of space.
Looks like you are changing the meaning slightly. is possible
to have BR_ROOT_BLOCK set but !root_block_enabled? and what about
the inverse?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, xen-devel@lists.xenproject.org,
mcgrof@suse.com, bridge@lists.linux-foundation.org
Subject: Re: [PATCH 3/3] bridge: fix bridge root block on designated port
Date: Thu, 13 Mar 2014 15:16:23 -0700 [thread overview]
Message-ID: <20140313151623.03e0484d@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1394680527-28970-4-git-send-email-mcgrof@do-not-panic.com>
On Wed, 12 Mar 2014 20:15:27 -0700
"Luis R. Rodriguez" <mcgrof@do-not-panic.com> wrote:
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -150,6 +150,7 @@ struct net_bridge_port
> u8 priority;
> u8 state;
> u16 port_no;
> + bool root_block_enabled;
> unsigned char topology_change_ack;
It seems a bit confusing to have both a ROOT_BLOCK flag in the
data structure and and additional root_block_enabled flag.
If nothing else it is a waste of space.
Looks like you are changing the meaning slightly. is possible
to have BR_ROOT_BLOCK set but !root_block_enabled? and what about
the inverse?
next prev parent reply other threads:[~2014-03-13 22:16 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 3:15 [PATCH 0/3] bridge: few enhancements and small fixes Luis R. Rodriguez
2014-03-13 3:15 ` [Bridge] [PATCH 1/3] bridge: preserve random init MAC address Luis R. Rodriguez
2014-03-13 3:15 ` Luis R. Rodriguez
2014-03-13 3:15 ` Luis R. Rodriguez
2014-03-19 0:42 ` [Bridge] " Toshiaki Makita
2014-03-19 0:42 ` Toshiaki Makita
2014-03-19 0:42 ` Toshiaki Makita
2014-03-19 0:50 ` [Bridge] " Luis R. Rodriguez
2014-03-19 0:50 ` Luis R. Rodriguez
2014-03-19 0:50 ` Luis R. Rodriguez
2014-03-19 1:04 ` Toshiaki Makita
2014-03-19 1:04 ` [Bridge] " Toshiaki Makita
2014-03-19 1:04 ` Toshiaki Makita
2014-03-19 1:04 ` Toshiaki Makita
2014-03-19 1:10 ` Luis R. Rodriguez
2014-03-19 1:10 ` [Bridge] " Luis R. Rodriguez
2014-03-19 1:10 ` Luis R. Rodriguez
2014-03-19 1:10 ` Luis R. Rodriguez
2014-03-19 16:09 ` [Bridge] " Toshiaki Makita
2014-03-19 16:09 ` Toshiaki Makita
2014-03-19 16:09 ` Toshiaki Makita
2014-03-19 0:50 ` Luis R. Rodriguez
2014-03-19 0:42 ` Toshiaki Makita
2014-03-19 3:10 ` Stephen Hemminger
2014-03-19 3:10 ` [Bridge] " Stephen Hemminger
2014-03-19 3:10 ` Stephen Hemminger
2014-03-19 3:10 ` Stephen Hemminger
2014-03-19 3:37 ` [Bridge] " Luis R. Rodriguez
2014-03-19 3:37 ` Luis R. Rodriguez
2014-03-19 3:37 ` Luis R. Rodriguez
2014-03-19 3:37 ` Luis R. Rodriguez
2014-03-20 2:05 ` Luis R. Rodriguez
2014-03-20 2:05 ` [Bridge] " Luis R. Rodriguez
2014-04-22 19:41 ` Luis R. Rodriguez
2014-04-22 19:41 ` [Bridge] " Luis R. Rodriguez
2014-04-22 19:41 ` Luis R. Rodriguez
2014-04-22 19:41 ` Luis R. Rodriguez
2014-04-30 18:40 ` [Bridge] " Luis R. Rodriguez
2014-04-30 18:40 ` Luis R. Rodriguez
2014-04-30 18:40 ` Luis R. Rodriguez
2014-04-30 18:40 ` Luis R. Rodriguez
2014-04-30 19:11 ` Vlad Yasevich
2014-04-30 19:11 ` [Bridge] " Vlad Yasevich
2014-04-30 19:11 ` Vlad Yasevich
2014-04-30 19:11 ` Vlad Yasevich
2014-03-20 2:05 ` Luis R. Rodriguez
2014-03-13 3:15 ` Luis R. Rodriguez
2014-03-13 3:15 ` [PATCH 2/3] bridge: trigger a bridge calculation upon port changes Luis R. Rodriguez
2014-03-13 3:15 ` [Bridge] " Luis R. Rodriguez
2014-03-13 3:15 ` Luis R. Rodriguez
2014-03-13 18:26 ` [Bridge] " Cong Wang
2014-03-13 18:26 ` Cong Wang
2014-03-13 18:26 ` Cong Wang
2014-03-15 1:39 ` Luis R. Rodriguez
2014-03-15 1:39 ` Luis R. Rodriguez
2014-03-15 1:39 ` [Bridge] " Luis R. Rodriguez
2014-03-18 20:46 ` Cong Wang
2014-03-18 20:46 ` [Bridge] " Cong Wang
2014-03-18 20:46 ` Cong Wang
2014-03-18 20:46 ` Cong Wang
2014-03-18 21:22 ` Luis R. Rodriguez
2014-03-18 21:22 ` [Bridge] " Luis R. Rodriguez
2014-03-18 21:22 ` Luis R. Rodriguez
2014-03-18 21:22 ` Luis R. Rodriguez
2014-04-22 19:43 ` Luis R. Rodriguez
2014-04-22 19:43 ` Luis R. Rodriguez
2014-04-22 19:43 ` [Bridge] " Luis R. Rodriguez
2014-04-30 18:38 ` Luis R. Rodriguez
2014-04-30 18:38 ` Luis R. Rodriguez
2014-04-30 18:38 ` Luis R. Rodriguez
2014-04-30 18:38 ` Luis R. Rodriguez
2014-04-30 20:04 ` [Bridge] " Vlad Yasevich
2014-04-30 20:04 ` Vlad Yasevich
2014-04-30 20:04 ` Vlad Yasevich
2014-04-30 22:59 ` Luis R. Rodriguez
2014-04-30 22:59 ` [Bridge] " Luis R. Rodriguez
2014-05-01 0:12 ` Vlad Yasevich
2014-05-01 0:12 ` [Bridge] " Vlad Yasevich
2014-05-01 0:12 ` Vlad Yasevich
2014-05-01 0:12 ` Vlad Yasevich
2014-04-30 22:59 ` Luis R. Rodriguez
2014-04-30 20:04 ` Vlad Yasevich
2014-03-13 18:26 ` Cong Wang
2014-03-13 3:15 ` [Bridge] [PATCH 3/3] bridge: fix bridge root block on designated port Luis R. Rodriguez
2014-03-13 3:15 ` Luis R. Rodriguez
2014-03-13 22:16 ` Stephen Hemminger [this message]
2014-03-13 22:16 ` Stephen Hemminger
2014-03-13 22:16 ` Stephen Hemminger
2014-03-15 2:08 ` Luis R. Rodriguez
2014-03-15 2:08 ` [Bridge] " Luis R. Rodriguez
2014-03-15 2:08 ` Luis R. Rodriguez
2014-03-13 22:16 ` Stephen Hemminger
2014-03-13 3:15 ` Luis R. Rodriguez
2014-03-18 20:31 ` [PATCH 0/3] bridge: few enhancements and small fixes Luis R. Rodriguez
2014-03-18 20:31 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313151623.03e0484d@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.