All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: kvm@vger.kernel.org,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	bridge@lists.linux-foundation.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Stephen Hemminger <stephen@networkplumber.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [Bridge] [PATCH 1/3] bridge: preserve random init MAC address
Date: Wed, 19 Mar 2014 10:04:37 +0900	[thread overview]
Message-ID: <5328ED25.1040900@lab.ntt.co.jp> (raw)
In-Reply-To: <CAB=NE6X2eZFLWBN1acf=d75T_K2YM_OK3oaXEPu-hwpUJEmwkg@mail.gmail.com>

(2014/03/19 9:50), Luis R. Rodriguez wrote:
> On Tue, Mar 18, 2014 at 5:42 PM, Toshiaki Makita
> <makita.toshiaki@lab.ntt.co.jp> wrote:
>> nit,
>> If the last detached port happens to have the same addr as
>> random_init_addr, this seems to call br_stp_change_bridge_id() even
>> though bridge_id is not changed.
> 
> Ah good point.
> 
>> Shouldn't the assignment of random_init_addr be done before the check of
>> "no change"?
> 
> Good question, should we even allow two ports to have the same MAC
> address or should we complain and refuse to add it? If so that should
> mean we should also have to monitor any manual address changes or
> events for address changes on the ports.

This was recently discussed by Stephen and me.
I'm thinking it should be allowed.

http://marc.info/?l=linux-netdev&m=139182743919257&w=2

Toshiaki Makita

> 
> Stephen?
> 
>   Luis

WARNING: multiple messages have this Message-ID (diff)
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: kvm@vger.kernel.org,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	bridge@lists.linux-foundation.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Stephen Hemminger <stephen@networkplumber.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/3] bridge: preserve random init MAC address
Date: Wed, 19 Mar 2014 10:04:37 +0900	[thread overview]
Message-ID: <5328ED25.1040900@lab.ntt.co.jp> (raw)
In-Reply-To: <CAB=NE6X2eZFLWBN1acf=d75T_K2YM_OK3oaXEPu-hwpUJEmwkg@mail.gmail.com>

(2014/03/19 9:50), Luis R. Rodriguez wrote:
> On Tue, Mar 18, 2014 at 5:42 PM, Toshiaki Makita
> <makita.toshiaki@lab.ntt.co.jp> wrote:
>> nit,
>> If the last detached port happens to have the same addr as
>> random_init_addr, this seems to call br_stp_change_bridge_id() even
>> though bridge_id is not changed.
> 
> Ah good point.
> 
>> Shouldn't the assignment of random_init_addr be done before the check of
>> "no change"?
> 
> Good question, should we even allow two ports to have the same MAC
> address or should we complain and refuse to add it? If so that should
> mean we should also have to monitor any manual address changes or
> events for address changes on the ports.

This was recently discussed by Stephen and me.
I'm thinking it should be allowed.

http://marc.info/?l=linux-netdev&m=139182743919257&w=2

Toshiaki Makita

> 
> Stephen?
> 
>   Luis

WARNING: multiple messages have this Message-ID (diff)
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kvm@vger.kernel.org, xen-devel@lists.xenproject.org,
	Stephen Hemminger <stephen@networkplumber.org>,
	bridge@lists.linux-foundation.org
Subject: Re: [PATCH 1/3] bridge: preserve random init MAC address
Date: Wed, 19 Mar 2014 10:04:37 +0900	[thread overview]
Message-ID: <5328ED25.1040900@lab.ntt.co.jp> (raw)
In-Reply-To: <CAB=NE6X2eZFLWBN1acf=d75T_K2YM_OK3oaXEPu-hwpUJEmwkg@mail.gmail.com>

(2014/03/19 9:50), Luis R. Rodriguez wrote:
> On Tue, Mar 18, 2014 at 5:42 PM, Toshiaki Makita
> <makita.toshiaki@lab.ntt.co.jp> wrote:
>> nit,
>> If the last detached port happens to have the same addr as
>> random_init_addr, this seems to call br_stp_change_bridge_id() even
>> though bridge_id is not changed.
> 
> Ah good point.
> 
>> Shouldn't the assignment of random_init_addr be done before the check of
>> "no change"?
> 
> Good question, should we even allow two ports to have the same MAC
> address or should we complain and refuse to add it? If so that should
> mean we should also have to monitor any manual address changes or
> events for address changes on the ports.

This was recently discussed by Stephen and me.
I'm thinking it should be allowed.

http://marc.info/?l=linux-netdev&m=139182743919257&w=2

Toshiaki Makita

> 
> Stephen?
> 
>   Luis

  parent reply	other threads:[~2014-03-19  1:04 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-13  3:15 [PATCH 0/3] bridge: few enhancements and small fixes Luis R. Rodriguez
2014-03-13  3:15 ` [PATCH 1/3] bridge: preserve random init MAC address Luis R. Rodriguez
2014-03-13  3:15 ` [Bridge] " Luis R. Rodriguez
2014-03-13  3:15   ` Luis R. Rodriguez
2014-03-13  3:15   ` Luis R. Rodriguez
2014-03-19  0:42   ` [Bridge] " Toshiaki Makita
2014-03-19  0:42     ` Toshiaki Makita
2014-03-19  0:42     ` Toshiaki Makita
2014-03-19  0:50     ` [Bridge] " Luis R. Rodriguez
2014-03-19  0:50       ` Luis R. Rodriguez
2014-03-19  0:50       ` Luis R. Rodriguez
2014-03-19  1:04       ` Toshiaki Makita
2014-03-19  1:04       ` Toshiaki Makita [this message]
2014-03-19  1:04         ` Toshiaki Makita
2014-03-19  1:04         ` Toshiaki Makita
2014-03-19  1:10         ` Luis R. Rodriguez
2014-03-19  1:10         ` [Bridge] " Luis R. Rodriguez
2014-03-19  1:10           ` Luis R. Rodriguez
2014-03-19  1:10           ` Luis R. Rodriguez
2014-03-19 16:09           ` [Bridge] " Toshiaki Makita
2014-03-19 16:09             ` Toshiaki Makita
2014-03-19 16:09           ` Toshiaki Makita
2014-03-19  0:50     ` Luis R. Rodriguez
2014-03-19  0:42   ` Toshiaki Makita
2014-03-19  3:10   ` Stephen Hemminger
2014-03-19  3:10   ` [Bridge] " Stephen Hemminger
2014-03-19  3:10     ` Stephen Hemminger
2014-03-19  3:10     ` Stephen Hemminger
2014-03-19  3:37     ` Luis R. Rodriguez
2014-03-19  3:37     ` [Bridge] " Luis R. Rodriguez
2014-03-19  3:37       ` Luis R. Rodriguez
2014-03-19  3:37       ` Luis R. Rodriguez
2014-03-20  2:05     ` Luis R. Rodriguez
2014-03-20  2:05       ` [Bridge] " Luis R. Rodriguez
2014-04-22 19:41       ` Luis R. Rodriguez
2014-04-22 19:41       ` [Bridge] " Luis R. Rodriguez
2014-04-22 19:41         ` Luis R. Rodriguez
2014-04-22 19:41         ` Luis R. Rodriguez
2014-04-30 18:40         ` Luis R. Rodriguez
2014-04-30 18:40         ` [Bridge] " Luis R. Rodriguez
2014-04-30 18:40           ` Luis R. Rodriguez
2014-04-30 18:40           ` Luis R. Rodriguez
2014-04-30 19:11         ` [Bridge] " Vlad Yasevich
2014-04-30 19:11           ` Vlad Yasevich
2014-04-30 19:11           ` Vlad Yasevich
2014-04-30 19:11         ` Vlad Yasevich
2014-03-20  2:05     ` Luis R. Rodriguez
2014-03-13  3:15 ` [Bridge] [PATCH 2/3] bridge: trigger a bridge calculation upon port changes Luis R. Rodriguez
2014-03-13  3:15   ` Luis R. Rodriguez
2014-03-13 18:26   ` Cong Wang
2014-03-13 18:26   ` [Bridge] " Cong Wang
2014-03-13 18:26     ` Cong Wang
2014-03-13 18:26     ` Cong Wang
2014-03-15  1:39     ` Luis R. Rodriguez
2014-03-15  1:39       ` [Bridge] " Luis R. Rodriguez
2014-03-18 20:46       ` Cong Wang
2014-03-18 20:46         ` Cong Wang
2014-03-18 20:46         ` Cong Wang
2014-03-18 21:22         ` Luis R. Rodriguez
2014-03-18 21:22         ` [Bridge] " Luis R. Rodriguez
2014-03-18 21:22           ` Luis R. Rodriguez
2014-03-18 21:22           ` Luis R. Rodriguez
2014-04-22 19:43           ` Luis R. Rodriguez
2014-04-22 19:43           ` Luis R. Rodriguez
2014-04-22 19:43             ` [Bridge] " Luis R. Rodriguez
2014-04-30 18:38             ` Luis R. Rodriguez
2014-04-30 18:38             ` [Bridge] " Luis R. Rodriguez
2014-04-30 18:38               ` Luis R. Rodriguez
2014-04-30 18:38               ` Luis R. Rodriguez
2014-04-30 20:04             ` [Bridge] " Vlad Yasevich
2014-04-30 20:04               ` Vlad Yasevich
2014-04-30 20:04               ` Vlad Yasevich
2014-04-30 22:59               ` Luis R. Rodriguez
2014-04-30 22:59               ` Luis R. Rodriguez
2014-04-30 22:59                 ` [Bridge] " Luis R. Rodriguez
2014-05-01  0:12                 ` Vlad Yasevich
2014-05-01  0:12                   ` Vlad Yasevich
2014-05-01  0:12                   ` Vlad Yasevich
2014-05-01  0:12                 ` Vlad Yasevich
2014-04-30 20:04             ` Vlad Yasevich
2014-03-18 20:46       ` Cong Wang
2014-03-15  1:39     ` Luis R. Rodriguez
2014-03-13  3:15 ` Luis R. Rodriguez
2014-03-13  3:15 ` [PATCH 3/3] bridge: fix bridge root block on designated port Luis R. Rodriguez
2014-03-13  3:15 ` [Bridge] " Luis R. Rodriguez
2014-03-13  3:15   ` Luis R. Rodriguez
2014-03-13 22:16   ` [Bridge] " Stephen Hemminger
2014-03-13 22:16     ` Stephen Hemminger
2014-03-13 22:16     ` Stephen Hemminger
2014-03-15  2:08     ` Luis R. Rodriguez
2014-03-15  2:08       ` [Bridge] " Luis R. Rodriguez
2014-03-15  2:08     ` Luis R. Rodriguez
2014-03-13 22:16   ` Stephen Hemminger
2014-03-18 20:31 ` [PATCH 0/3] bridge: few enhancements and small fixes Luis R. Rodriguez
2014-03-18 20:31 ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5328ED25.1040900@lab.ntt.co.jp \
    --to=makita.toshiaki@lab.ntt.co.jp \
    --cc=bridge@lists.linux-foundation.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@do-not-panic.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.