From: Tony Lindgren <tony@atomide.com>
To: Joel Fernandes <joelf@TI.com>
Cc: Rob Herring <robh@kernel.org>, Tero Kristo <t-kristo@TI.com>,
Nishanth Menon <nm@TI.com>, Suman Anna <s-anna@TI.com>,
Felipe Balbi <balbi@TI.com>,
Linux OMAP List <linux-omap@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC 4/5] clocksource: omap-timer: Introduce clocksource driver for OMAP SoCs
Date: Thu, 13 Mar 2014 13:48:52 -0700 [thread overview]
Message-ID: <20140313204851.GB23432@atomide.com> (raw)
In-Reply-To: <1394742919-32163-5-git-send-email-joelf@ti.com>
* Joel Fernandes <joelf@TI.com> [140313 13:43]:
> We introduce functions to initialize clocksource and clockevent, use
> CLOCKSOURCE_OF_DECLARE to declare the clocksource, and handle the clocksource
> selection on a per-SoC basis (Currently only AM335x is supported). Powering up
> of the timer will be done with the help of the mach-omap layer function that's
> introduced earlier in the series.
>
> We make a local copy of dmtimer API for use by clocksource, the original
> dmtimer API in plat-omap is kept as-is till the migration of all SoCs is
> completed after which it can't be deleted.
>
> Signed-off-by: Joel Fernandes <joelf@ti.com>
> ---
> drivers/clocksource/Makefile | 1 +
> drivers/clocksource/omap-timer.c | 1157 ++++++++++++++++++++++++++++++++++++++
> drivers/clocksource/omap-timer.h | 422 ++++++++++++++
> 3 files changed, 1580 insertions(+)
> create mode 100644 drivers/clocksource/omap-timer.c
> create mode 100644 drivers/clocksource/omap-timer.h
Hmm this leaves duplicate arch/arm/plat-omap/dmtimer.c code, please
sort out that issue too by allowing omap1 and omap3 still to use
the legacy timer init functions but with timer code under
drivers/clocksource/omap-timer.c.
And not the that drivers/clocksource/omap-timer.h won't be needed at
all, those defines can stay private to the drivers/clocksource/omap-timer.c.
So this patch really should just be moving of the code to the new
location.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 4/5] clocksource: omap-timer: Introduce clocksource driver for OMAP SoCs
Date: Thu, 13 Mar 2014 13:48:52 -0700 [thread overview]
Message-ID: <20140313204851.GB23432@atomide.com> (raw)
In-Reply-To: <1394742919-32163-5-git-send-email-joelf@ti.com>
* Joel Fernandes <joelf@TI.com> [140313 13:43]:
> We introduce functions to initialize clocksource and clockevent, use
> CLOCKSOURCE_OF_DECLARE to declare the clocksource, and handle the clocksource
> selection on a per-SoC basis (Currently only AM335x is supported). Powering up
> of the timer will be done with the help of the mach-omap layer function that's
> introduced earlier in the series.
>
> We make a local copy of dmtimer API for use by clocksource, the original
> dmtimer API in plat-omap is kept as-is till the migration of all SoCs is
> completed after which it can't be deleted.
>
> Signed-off-by: Joel Fernandes <joelf@ti.com>
> ---
> drivers/clocksource/Makefile | 1 +
> drivers/clocksource/omap-timer.c | 1157 ++++++++++++++++++++++++++++++++++++++
> drivers/clocksource/omap-timer.h | 422 ++++++++++++++
> 3 files changed, 1580 insertions(+)
> create mode 100644 drivers/clocksource/omap-timer.c
> create mode 100644 drivers/clocksource/omap-timer.h
Hmm this leaves duplicate arch/arm/plat-omap/dmtimer.c code, please
sort out that issue too by allowing omap1 and omap3 still to use
the legacy timer init functions but with timer code under
drivers/clocksource/omap-timer.c.
And not the that drivers/clocksource/omap-timer.h won't be needed at
all, those defines can stay private to the drivers/clocksource/omap-timer.c.
So this patch really should just be moving of the code to the new
location.
Regards,
Tony
next prev parent reply other threads:[~2014-03-13 20:48 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 20:35 [RFC 0/5] Clocksource driver for OMAP SoCs Joel Fernandes
2014-03-13 20:35 ` Joel Fernandes
2014-03-13 20:35 ` [RFC 1/5] ARM: dts: am33xx: Add clock nodes for timer1 and timer2 Joel Fernandes
2014-03-13 20:35 ` Joel Fernandes
2014-03-13 20:35 ` Joel Fernandes
2014-03-13 20:35 ` [RFC 2/5] ARM: dts: am33xx: Set parent clock for timer through DT Joel Fernandes
2014-03-13 20:35 ` Joel Fernandes
2014-03-13 20:35 ` Joel Fernandes
2014-03-14 8:08 ` Tero Kristo
2014-03-14 8:08 ` Tero Kristo
2014-03-13 20:35 ` [RFC 3/5] ARM: OMAP2+: timer: Add clocksource initialization and powerup support Joel Fernandes
2014-03-13 20:35 ` Joel Fernandes
2014-03-13 21:52 ` Rob Herring
2014-03-13 21:52 ` Rob Herring
2014-03-13 23:36 ` Joel Fernandes
2014-03-13 23:36 ` Joel Fernandes
2014-03-14 8:03 ` Tero Kristo
2014-03-14 8:03 ` Tero Kristo
2014-03-14 21:09 ` Kevin Hilman
2014-03-14 21:09 ` Kevin Hilman
2014-03-14 21:16 ` Rob Herring
2014-03-14 21:16 ` Rob Herring
2014-03-13 20:35 ` [RFC 4/5] clocksource: omap-timer: Introduce clocksource driver for OMAP SoCs Joel Fernandes
2014-03-13 20:35 ` Joel Fernandes
2014-03-13 20:48 ` Tony Lindgren [this message]
2014-03-13 20:48 ` Tony Lindgren
2014-03-13 23:49 ` Joel Fernandes
2014-03-13 23:49 ` Joel Fernandes
2014-03-13 23:49 ` Joel Fernandes
2014-03-14 15:52 ` Tony Lindgren
2014-03-14 15:52 ` Tony Lindgren
2014-03-14 19:32 ` Joel Fernandes
2014-03-14 19:32 ` Joel Fernandes
2014-03-14 19:33 ` Joel Fernandes
2014-03-14 19:33 ` Joel Fernandes
2014-03-15 0:13 ` Suman Anna
2014-03-15 0:13 ` Suman Anna
2014-03-15 0:13 ` Suman Anna
2014-03-15 1:11 ` Joel Fernandes
2014-03-15 1:11 ` Joel Fernandes
2014-03-13 20:35 ` [RFC 5/5] ARM: AM33xx: Move to using omap_generic_timer_init for init_time Joel Fernandes
2014-03-13 20:35 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313204851.GB23432@atomide.com \
--to=tony@atomide.com \
--cc=balbi@TI.com \
--cc=joelf@TI.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@TI.com \
--cc=robh@kernel.org \
--cc=s-anna@TI.com \
--cc=t-kristo@TI.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.