All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: Joel Fernandes <joelf@ti.com>, Tony Lindgren <tony@atomide.com>,
	Rob Herring <robh@kernel.org>, Nishanth Menon <nm@ti.com>,
	Suman Anna <s-anna@ti.com>, Felipe Balbi <balbi@ti.com>
Cc: Linux OMAP List <linux-omap@vger.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 2/5] ARM: dts: am33xx: Set parent clock for timer through DT
Date: Fri, 14 Mar 2014 10:08:59 +0200	[thread overview]
Message-ID: <5322B91B.4020401@ti.com> (raw)
In-Reply-To: <1394742919-32163-3-git-send-email-joelf@ti.com>

On 03/13/2014 10:35 PM, Joel Fernandes wrote:
> Signed-off-by: Joel Fernandes <joelf@ti.com>
> ---
>   arch/arm/boot/dts/am33xx.dtsi |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 4e6c959..51b7008 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -352,6 +352,7 @@
>   			interrupts = <67>;
>   			ti,hwmods = "timer1";
>   			ti,timer-alwon;
> +			ti,default-parent = <&sys_clkin_ck>;
>   		};
>
>   		timer2: timer@48040000 {
> @@ -360,6 +361,7 @@
>   			reg = <0x48040000 0x400>;
>   			interrupts = <68>;
>   			ti,hwmods = "timer2";
> +			ti,default-parent = <&sys_clkin_ck>;
>   		};
>
>   		timer3: timer@48042000 {
>

I don't think this works, the ti,default-parent property is only 
supported for clock nodes (at least I didn't quickly find anything from 
your clocksource driver that would handle this.) You should do something 
like this:

&timer1_fck {
	ti,default-parent = <&sys_clkin_ck>;
};

&timer2_fck {
	ti,default-parent = <&sys_clkin_ck>;
};

-Tero

WARNING: multiple messages have this Message-ID (diff)
From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 2/5] ARM: dts: am33xx: Set parent clock for timer through DT
Date: Fri, 14 Mar 2014 10:08:59 +0200	[thread overview]
Message-ID: <5322B91B.4020401@ti.com> (raw)
In-Reply-To: <1394742919-32163-3-git-send-email-joelf@ti.com>

On 03/13/2014 10:35 PM, Joel Fernandes wrote:
> Signed-off-by: Joel Fernandes <joelf@ti.com>
> ---
>   arch/arm/boot/dts/am33xx.dtsi |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 4e6c959..51b7008 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -352,6 +352,7 @@
>   			interrupts = <67>;
>   			ti,hwmods = "timer1";
>   			ti,timer-alwon;
> +			ti,default-parent = <&sys_clkin_ck>;
>   		};
>
>   		timer2: timer at 48040000 {
> @@ -360,6 +361,7 @@
>   			reg = <0x48040000 0x400>;
>   			interrupts = <68>;
>   			ti,hwmods = "timer2";
> +			ti,default-parent = <&sys_clkin_ck>;
>   		};
>
>   		timer3: timer at 48042000 {
>

I don't think this works, the ti,default-parent property is only 
supported for clock nodes (at least I didn't quickly find anything from 
your clocksource driver that would handle this.) You should do something 
like this:

&timer1_fck {
	ti,default-parent = <&sys_clkin_ck>;
};

&timer2_fck {
	ti,default-parent = <&sys_clkin_ck>;
};

-Tero

  reply	other threads:[~2014-03-14  8:08 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-13 20:35 [RFC 0/5] Clocksource driver for OMAP SoCs Joel Fernandes
2014-03-13 20:35 ` Joel Fernandes
2014-03-13 20:35 ` [RFC 1/5] ARM: dts: am33xx: Add clock nodes for timer1 and timer2 Joel Fernandes
2014-03-13 20:35   ` Joel Fernandes
2014-03-13 20:35   ` Joel Fernandes
2014-03-13 20:35 ` [RFC 2/5] ARM: dts: am33xx: Set parent clock for timer through DT Joel Fernandes
2014-03-13 20:35   ` Joel Fernandes
2014-03-13 20:35   ` Joel Fernandes
2014-03-14  8:08   ` Tero Kristo [this message]
2014-03-14  8:08     ` Tero Kristo
2014-03-13 20:35 ` [RFC 3/5] ARM: OMAP2+: timer: Add clocksource initialization and powerup support Joel Fernandes
2014-03-13 20:35   ` Joel Fernandes
2014-03-13 21:52   ` Rob Herring
2014-03-13 21:52     ` Rob Herring
2014-03-13 23:36     ` Joel Fernandes
2014-03-13 23:36       ` Joel Fernandes
2014-03-14  8:03       ` Tero Kristo
2014-03-14  8:03         ` Tero Kristo
2014-03-14 21:09       ` Kevin Hilman
2014-03-14 21:09         ` Kevin Hilman
2014-03-14 21:16         ` Rob Herring
2014-03-14 21:16           ` Rob Herring
2014-03-13 20:35 ` [RFC 4/5] clocksource: omap-timer: Introduce clocksource driver for OMAP SoCs Joel Fernandes
2014-03-13 20:35   ` Joel Fernandes
2014-03-13 20:48   ` Tony Lindgren
2014-03-13 20:48     ` Tony Lindgren
2014-03-13 23:49     ` Joel Fernandes
2014-03-13 23:49       ` Joel Fernandes
2014-03-13 23:49       ` Joel Fernandes
2014-03-14 15:52       ` Tony Lindgren
2014-03-14 15:52         ` Tony Lindgren
2014-03-14 19:32         ` Joel Fernandes
2014-03-14 19:32           ` Joel Fernandes
2014-03-14 19:33           ` Joel Fernandes
2014-03-14 19:33             ` Joel Fernandes
2014-03-15  0:13   ` Suman Anna
2014-03-15  0:13     ` Suman Anna
2014-03-15  0:13     ` Suman Anna
2014-03-15  1:11     ` Joel Fernandes
2014-03-15  1:11       ` Joel Fernandes
2014-03-13 20:35 ` [RFC 5/5] ARM: AM33xx: Move to using omap_generic_timer_init for init_time Joel Fernandes
2014-03-13 20:35   ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5322B91B.4020401@ti.com \
    --to=t-kristo@ti.com \
    --cc=balbi@ti.com \
    --cc=joelf@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=s-anna@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.