From: Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>
To: Leif Lindholm <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2 13/15] arm64: add EFI runtime services
Date: Tue, 18 Mar 2014 12:34:19 +0000 [thread overview]
Message-ID: <20140318123418.GH13200@arm.com> (raw)
In-Reply-To: <1394750828-16351-14-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Thu, Mar 13, 2014 at 10:47:06PM +0000, Leif Lindholm wrote:
> --- /dev/null
> +++ b/arch/arm64/kernel/efi.c
[...]
> +/*
> + * Called from setup_arch with interrupts disabled.
> + */
> +void __init efi_enter_virtual_mode(void)
[...]
> --- a/init/main.c
> +++ b/init/main.c
> @@ -902,6 +902,10 @@ static noinline void __init kernel_init_freeable(void)
> smp_prepare_cpus(setup_max_cpus);
>
> do_pre_smp_initcalls();
> +
> + if (IS_ENABLED(CONFIG_ARM64) && efi_enabled(EFI_BOOT))
> + efi_enter_virtual_mode();
The comment for the efi_enter_virtual_mode() function says "called from
setup_arch with interrupts disabled". None of these are true for the
call above (and I would really prefer an arch call than this arm64
conditional call in init/main.c.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 13/15] arm64: add EFI runtime services
Date: Tue, 18 Mar 2014 12:34:19 +0000 [thread overview]
Message-ID: <20140318123418.GH13200@arm.com> (raw)
In-Reply-To: <1394750828-16351-14-git-send-email-leif.lindholm@linaro.org>
On Thu, Mar 13, 2014 at 10:47:06PM +0000, Leif Lindholm wrote:
> --- /dev/null
> +++ b/arch/arm64/kernel/efi.c
[...]
> +/*
> + * Called from setup_arch with interrupts disabled.
> + */
> +void __init efi_enter_virtual_mode(void)
[...]
> --- a/init/main.c
> +++ b/init/main.c
> @@ -902,6 +902,10 @@ static noinline void __init kernel_init_freeable(void)
> smp_prepare_cpus(setup_max_cpus);
>
> do_pre_smp_initcalls();
> +
> + if (IS_ENABLED(CONFIG_ARM64) && efi_enabled(EFI_BOOT))
> + efi_enter_virtual_mode();
The comment for the efi_enter_virtual_mode() function says "called from
setup_arch with interrupts disabled". None of these are true for the
call above (and I would really prefer an arch call than this arm64
conditional call in init/main.c.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"matt.fleming@intel.com" <matt.fleming@intel.com>,
"msalter@redhat.com" <msalter@redhat.com>,
"roy.franz@linaro.org" <roy.franz@linaro.org>
Subject: Re: [PATCH v2 13/15] arm64: add EFI runtime services
Date: Tue, 18 Mar 2014 12:34:19 +0000 [thread overview]
Message-ID: <20140318123418.GH13200@arm.com> (raw)
In-Reply-To: <1394750828-16351-14-git-send-email-leif.lindholm@linaro.org>
On Thu, Mar 13, 2014 at 10:47:06PM +0000, Leif Lindholm wrote:
> --- /dev/null
> +++ b/arch/arm64/kernel/efi.c
[...]
> +/*
> + * Called from setup_arch with interrupts disabled.
> + */
> +void __init efi_enter_virtual_mode(void)
[...]
> --- a/init/main.c
> +++ b/init/main.c
> @@ -902,6 +902,10 @@ static noinline void __init kernel_init_freeable(void)
> smp_prepare_cpus(setup_max_cpus);
>
> do_pre_smp_initcalls();
> +
> + if (IS_ENABLED(CONFIG_ARM64) && efi_enabled(EFI_BOOT))
> + efi_enter_virtual_mode();
The comment for the efi_enter_virtual_mode() function says "called from
setup_arch with interrupts disabled". None of these are true for the
call above (and I would really prefer an arch call than this arm64
conditional call in init/main.c.
--
Catalin
next prev parent reply other threads:[~2014-03-18 12:34 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 22:46 [PATCH v2 00/14] UEFI support for arm(64) Leif Lindholm
2014-03-13 22:46 ` Leif Lindholm
2014-03-13 22:46 ` Leif Lindholm
2014-03-13 22:46 ` [PATCH v2 01/15] efi: delete stray ARM ifdef Leif Lindholm
2014-03-13 22:46 ` Leif Lindholm
2014-03-13 22:46 ` Leif Lindholm
2014-03-13 22:46 ` [PATCH v2 02/15] efi: x86: Improve cmdline conversion Leif Lindholm
2014-03-13 22:46 ` Leif Lindholm
2014-03-13 22:46 ` Leif Lindholm
2014-03-13 22:46 ` [PATCH v2 03/15] efi: create memory map iteration helper Leif Lindholm
2014-03-13 22:46 ` Leif Lindholm
2014-03-13 22:46 ` Leif Lindholm
2014-03-13 22:46 ` [PATCH v2 05/15] efi: add helper function to get UEFI params from FDT Leif Lindholm
2014-03-13 22:46 ` Leif Lindholm
2014-03-13 22:46 ` Leif Lindholm
2014-03-13 22:46 ` [PATCH v2 06/15] doc: efi-stub.txt updates for ARM Leif Lindholm
2014-03-13 22:46 ` Leif Lindholm
2014-03-13 22:47 ` [PATCH v2 07/15] efi: Add shared printk wrapper for consistent prefixing Leif Lindholm
2014-03-13 22:47 ` Leif Lindholm
[not found] ` <1394750828-16351-1-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-03-13 22:46 ` [PATCH v2 04/15] lib: add fdt_empty_tree.c Leif Lindholm
2014-03-13 22:46 ` Leif Lindholm
2014-03-13 22:46 ` Leif Lindholm
2014-03-13 22:47 ` [PATCH v2 08/15] efi: Add get_dram_base() helper function Leif Lindholm
2014-03-13 22:47 ` Leif Lindholm
2014-03-13 22:47 ` Leif Lindholm
2014-03-13 22:47 ` [PATCH v2 09/15] efi: Add shared FDT related functions for ARM/ARM64 Leif Lindholm
2014-03-13 22:47 ` Leif Lindholm
2014-03-13 22:47 ` [PATCH v2 10/15] arm64: Add function to create identity mappings Leif Lindholm
2014-03-13 22:47 ` Leif Lindholm
2014-03-13 22:47 ` [PATCH v2 11/15] arm64: add EFI stub Leif Lindholm
2014-03-13 22:47 ` Leif Lindholm
[not found] ` <1394750828-16351-12-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-03-18 12:09 ` Catalin Marinas
2014-03-18 12:09 ` Catalin Marinas
2014-03-18 12:09 ` Catalin Marinas
[not found] ` <20140318120919.GG13200-5wv7dgnIgG8@public.gmane.org>
2014-03-18 14:40 ` Mark Salter
2014-03-18 14:40 ` Mark Salter
2014-03-18 14:40 ` Mark Salter
[not found] ` <1395153629.2967.10.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2014-03-18 18:28 ` Catalin Marinas
2014-03-18 18:28 ` Catalin Marinas
2014-03-18 18:28 ` Catalin Marinas
2014-03-18 21:40 ` Mark Salter
2014-03-18 21:40 ` Mark Salter
2014-03-18 21:40 ` Mark Salter
[not found] ` <1395178831.2967.29.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2014-03-18 21:48 ` Roy Franz
2014-03-18 21:48 ` Roy Franz
2014-03-18 21:48 ` Roy Franz
[not found] ` <CAFECyb_NuHBQD3zPouDde3WTyz8RrUu1OWFOt6VWX_U5n1g8MA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-18 22:21 ` Jason Gunthorpe
2014-03-18 22:21 ` Jason Gunthorpe
2014-03-18 22:21 ` Jason Gunthorpe
[not found] ` <20140318222105.GA11178-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2014-03-19 10:35 ` Catalin Marinas
2014-03-19 10:35 ` Catalin Marinas
2014-03-19 10:35 ` Catalin Marinas
2014-03-19 10:57 ` Catalin Marinas
2014-03-19 10:57 ` Catalin Marinas
2014-03-19 10:57 ` Catalin Marinas
[not found] ` <20140319105706.GE2214-5wv7dgnIgG8@public.gmane.org>
2014-03-19 15:13 ` Mark Salter
2014-03-19 15:13 ` Mark Salter
2014-03-19 15:13 ` Mark Salter
[not found] ` <1395241998.2967.52.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2014-03-19 16:01 ` Catalin Marinas
2014-03-19 16:01 ` Catalin Marinas
2014-03-19 16:01 ` Catalin Marinas
[not found] ` <20140319160149.GF2214-5wv7dgnIgG8@public.gmane.org>
2014-03-19 16:46 ` Mark Salter
2014-03-19 16:46 ` Mark Salter
2014-03-19 16:46 ` Mark Salter
2014-03-13 22:47 ` [PATCH v2 12/15] doc: arm64: add description of EFI stub support Leif Lindholm
2014-03-13 22:47 ` Leif Lindholm
2014-03-13 22:47 ` [PATCH v2 13/15] arm64: add EFI runtime services Leif Lindholm
2014-03-13 22:47 ` Leif Lindholm
[not found] ` <1394750828-16351-14-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-03-18 12:34 ` Catalin Marinas [this message]
2014-03-18 12:34 ` Catalin Marinas
2014-03-18 12:34 ` Catalin Marinas
[not found] ` <20140318123418.GH13200-5wv7dgnIgG8@public.gmane.org>
2014-03-18 14:16 ` Mark Salter
2014-03-18 14:16 ` Mark Salter
2014-03-18 14:16 ` Mark Salter
[not found] ` <1395152209.2967.3.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2014-03-18 17:36 ` Catalin Marinas
2014-03-18 17:36 ` Catalin Marinas
2014-03-18 17:36 ` Catalin Marinas
2014-03-13 22:47 ` [PATCH v2 14/15] doc: arm: add UEFI support documentation Leif Lindholm
2014-03-13 22:47 ` Leif Lindholm
2014-03-13 22:47 ` [PATCH v2 15/15] efi/arm64: ignore dtb= when UEFI SecureBoot is enabled Leif Lindholm
2014-03-13 22:47 ` Leif Lindholm
2014-03-17 22:24 ` [PATCH v2 00/14] UEFI support for arm(64) Matt Fleming
2014-03-17 22:24 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318123418.GH13200@arm.com \
--to=catalin.marinas-5wv7dgnigg8@public.gmane.org \
--cc=leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.