From: Finn Thain <fthain@telegraphics.com.au>
To: "James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org
Cc: Sam Creasey <sammy@sammy.net>,
Russell King <linux@arm.linux.org.uk>,
Michael Schmitz <schmitz@debian.org>,
Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-m68k@vger.kernel.org
Subject: [PATCH v2 04/12] scsi/NCR5380: use NCR5380_dprint() instead of NCR5380_print()
Date: Wed, 19 Mar 2014 23:35:20 +1100 [thread overview]
Message-ID: <20140319123517.752438506@telegraphics.com.au> (raw)
In-Reply-To: 20140319123516.542623278@telegraphics.com.au
[-- Attachment #1: ncr5380-debug-macros-sun3-NCR5380_print --]
[-- Type: text/plain, Size: 1061 bytes --]
Only the NCR5380_dprint() macro should invoke the NCR5380_print() function.
That's why NCR5380.c only defines the function #if NDEBUG. Use the standard
macro.
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
drivers/scsi/sun3_scsi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: linux-m68k/drivers/scsi/sun3_scsi.c
===================================================================
--- linux-m68k.orig/drivers/scsi/sun3_scsi.c 2014-03-19 23:34:41.000000000 +1100
+++ linux-m68k/drivers/scsi/sun3_scsi.c 2014-03-19 23:34:41.000000000 +1100
@@ -79,8 +79,6 @@
#include <scsi/scsi_host.h>
#include "sun3_scsi.h"
-static void NCR5380_print(struct Scsi_Host *instance);
-
/* #define OLDDMA */
#define USE_WRAPPER
@@ -463,7 +461,7 @@ static unsigned long sun3scsi_dma_setup(
printk("scsi%d: fifo_mismatch %04x not %04x\n",
default_instance->host_no, dregs->fifo_count,
(unsigned int) count);
- NCR5380_print(default_instance);
+ NCR5380_dprint(NDEBUG_DMA, default_instance);
}
/* setup udc */
WARNING: multiple messages have this Message-ID (diff)
From: fthain@telegraphics.com.au (Finn Thain)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 04/12] scsi/NCR5380: use NCR5380_dprint() instead of NCR5380_print()
Date: Wed, 19 Mar 2014 23:35:20 +1100 [thread overview]
Message-ID: <20140319123517.752438506@telegraphics.com.au> (raw)
In-Reply-To: 20140319123516.542623278@telegraphics.com.au
An embedded and charset-unspecified text was scrubbed...
Name: ncr5380-debug-macros-sun3-NCR5380_print
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140319/9f0dd964/attachment.ksh>
WARNING: multiple messages have this Message-ID (diff)
From: Finn Thain <fthain@telegraphics.com.au>
To: "James E.J. Bottomley" <JBottomley@parallels.com>,
<linux-scsi@vger.kernel.org>
Cc: Sam Creasey <sammy@sammy.net>,
Russell King <linux@arm.linux.org.uk>,
Michael Schmitz <schmitz@debian.org>,
Joe Perches <joe@perches.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-m68k@vger.kernel.org>
Subject: [PATCH v2 04/12] scsi/NCR5380: use NCR5380_dprint() instead of NCR5380_print()
Date: Wed, 19 Mar 2014 23:35:20 +1100 [thread overview]
Message-ID: <20140319123517.752438506@telegraphics.com.au> (raw)
In-Reply-To: 20140319123516.542623278@telegraphics.com.au
[-- Attachment #1: ncr5380-debug-macros-sun3-NCR5380_print --]
[-- Type: text/plain, Size: 1062 bytes --]
Only the NCR5380_dprint() macro should invoke the NCR5380_print() function.
That's why NCR5380.c only defines the function #if NDEBUG. Use the standard
macro.
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
drivers/scsi/sun3_scsi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: linux-m68k/drivers/scsi/sun3_scsi.c
===================================================================
--- linux-m68k.orig/drivers/scsi/sun3_scsi.c 2014-03-19 23:34:41.000000000 +1100
+++ linux-m68k/drivers/scsi/sun3_scsi.c 2014-03-19 23:34:41.000000000 +1100
@@ -79,8 +79,6 @@
#include <scsi/scsi_host.h>
#include "sun3_scsi.h"
-static void NCR5380_print(struct Scsi_Host *instance);
-
/* #define OLDDMA */
#define USE_WRAPPER
@@ -463,7 +461,7 @@ static unsigned long sun3scsi_dma_setup(
printk("scsi%d: fifo_mismatch %04x not %04x\n",
default_instance->host_no, dregs->fifo_count,
(unsigned int) count);
- NCR5380_print(default_instance);
+ NCR5380_dprint(NDEBUG_DMA, default_instance);
}
/* setup udc */
next prev parent reply other threads:[~2014-03-19 23:27 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 12:35 [PATCH v2 00/12] scsi/NCR5380: fix debugging macros and #include structure Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` [PATCH v2 01/12] scsi/NCR5380: remove unused BOARD_NORMAL and BOARD_NCR53C400 Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` [PATCH v2 02/12] scsi/NCR5380: remove redundant HOSTS_C macro tests Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` [PATCH v2 03/12] scsi/NCR5380: remove old CVS keywords Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` Finn Thain [this message]
2014-03-19 12:35 ` [PATCH v2 04/12] scsi/NCR5380: use NCR5380_dprint() instead of NCR5380_print() Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` [PATCH v2 05/12] scsi/NCR5380: fix build failures when debugging is enabled Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` [PATCH v2 06/12] scsi/NCR5380: fix dprintk macro usage and definition Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` [PATCH v2 07/12] scsi/NCR5380: adopt NCR5380_dprint() and NCR5380_dprint_phase() Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-04-26 1:51 ` Michael Schmitz
2014-04-26 1:51 ` Michael Schmitz
2014-03-19 12:35 ` [PATCH v2 08/12] scsi/NCR5380: adopt dprintk() Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-04-26 1:52 ` Michael Schmitz
2014-04-26 1:52 ` Michael Schmitz
2014-03-19 12:35 ` [PATCH v2 09/12] scsi/NCR5380: fix and standardize NDEBUG macros Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` [PATCH v2 10/12] scsi/NCR5380: remove unused macro definitions Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-04-26 1:53 ` Michael Schmitz
2014-04-26 1:53 ` Michael Schmitz
2014-03-19 12:35 ` [PATCH v2 11/12] scsi/NCR5380: reduce depth of sun3_scsi nested includes Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` [PATCH v2 12/12] scsi/NCR5380: merge sun3_scsi_vme.c into sun3_scsi.c Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-03-19 12:35 ` Finn Thain
2014-04-11 14:39 ` [PATCH v2 00/12] scsi/NCR5380: fix debugging macros and #include structure Sam Creasey
2014-04-11 14:39 ` Sam Creasey
2014-04-26 17:21 ` James Bottomley
2014-04-26 17:21 ` James Bottomley
2014-04-29 2:22 ` Finn Thain
2014-04-29 2:22 ` Finn Thain
2014-04-29 3:15 ` Michael Schmitz
2014-04-29 3:15 ` Michael Schmitz
2014-04-29 14:41 ` James Bottomley
2014-04-29 14:41 ` James Bottomley
2014-04-30 7:45 ` Michael Schmitz
2014-04-30 7:45 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319123517.752438506@telegraphics.com.au \
--to=fthain@telegraphics.com.au \
--cc=JBottomley@parallels.com \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sammy@sammy.net \
--cc=schmitz@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.