All of lore.kernel.org
 help / color / mirror / Atom feed
From: moinejf@free.fr (Jean-Francois Moine)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation
Date: Thu, 20 Mar 2014 14:52:21 +0100	[thread overview]
Message-ID: <20140320145221.09252bf6@armhf> (raw)
In-Reply-To: <532AEDE2.3080306@gmail.com>

On Thu, 20 Mar 2014 14:32:18 +0100
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:

> Ok, I had another round of google'ing and found this:
> http://hipstercircuits.com/wp-content/uploads/2013/05/TDA19988.pdf
> 
> There, the datasheet specifically for TDA19988 only states 0x70 and
> 0x34 as the two i2c addresses. Therefore, TDA19988 has fixed i2c
> addresses while TDA9983b has configurable (main) i2c address.
> 
> Not as easy as we thought ;)
> 
> I suggest reword the reg property to:
> "- reg: shall be set to the I2C address"
> 
> and optionally list all known addresses for each TDA[1]998x in the
> binding.

Thanks for the link.

OK, then, as the linux tda998x driver handles only the tda 19988 and
19989 chips, the HDMI I2C address is always 0x70.

So, question: Russell and Sebastian, do you still want an other patch?

Other question: the CEC address is hard-coded to 0x34 in the driver.
Should it be configurable in the DT?

-- 
Ken ar c'henta?	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

WARNING: multiple messages have this Message-ID (diff)
From: Jean-Francois Moine <moinejf@free.fr>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: devicetree@vger.kernel.org,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation
Date: Thu, 20 Mar 2014 14:52:21 +0100	[thread overview]
Message-ID: <20140320145221.09252bf6@armhf> (raw)
In-Reply-To: <532AEDE2.3080306@gmail.com>

On Thu, 20 Mar 2014 14:32:18 +0100
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:

> Ok, I had another round of google'ing and found this:
> http://hipstercircuits.com/wp-content/uploads/2013/05/TDA19988.pdf
> 
> There, the datasheet specifically for TDA19988 only states 0x70 and
> 0x34 as the two i2c addresses. Therefore, TDA19988 has fixed i2c
> addresses while TDA9983b has configurable (main) i2c address.
> 
> Not as easy as we thought ;)
> 
> I suggest reword the reg property to:
> "- reg: shall be set to the I2C address"
> 
> and optionally list all known addresses for each TDA[1]998x in the
> binding.

Thanks for the link.

OK, then, as the linux tda998x driver handles only the tda 19988 and
19989 chips, the HDMI I2C address is always 0x70.

So, question: Russell and Sebastian, do you still want an other patch?

Other question: the CEC address is hard-coded to 0x34 in the driver.
Should it be configurable in the DT?

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jean-Francois Moine <moinejf@free.fr>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation
Date: Thu, 20 Mar 2014 14:52:21 +0100	[thread overview]
Message-ID: <20140320145221.09252bf6@armhf> (raw)
In-Reply-To: <532AEDE2.3080306@gmail.com>

On Thu, 20 Mar 2014 14:32:18 +0100
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:

> Ok, I had another round of google'ing and found this:
> http://hipstercircuits.com/wp-content/uploads/2013/05/TDA19988.pdf
> 
> There, the datasheet specifically for TDA19988 only states 0x70 and
> 0x34 as the two i2c addresses. Therefore, TDA19988 has fixed i2c
> addresses while TDA9983b has configurable (main) i2c address.
> 
> Not as easy as we thought ;)
> 
> I suggest reword the reg property to:
> "- reg: shall be set to the I2C address"
> 
> and optionally list all known addresses for each TDA[1]998x in the
> binding.

Thanks for the link.

OK, then, as the linux tda998x driver handles only the tda 19988 and
19989 chips, the HDMI I2C address is always 0x70.

So, question: Russell and Sebastian, do you still want an other patch?

Other question: the CEC address is hard-coded to 0x34 in the driver.
Should it be configurable in the DT?

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

  reply	other threads:[~2014-03-20 13:52 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20  8:58 [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation Jean-Francois Moine
2014-03-20  8:58 ` Jean-Francois Moine
2014-03-20  8:58 ` Jean-Francois Moine
2014-03-20 12:32 ` Sebastian Hesselbarth
2014-03-20 12:32   ` Sebastian Hesselbarth
2014-03-20 12:32   ` Sebastian Hesselbarth
2014-03-20 12:36   ` Russell King - ARM Linux
2014-03-20 12:36     ` Russell King - ARM Linux
2014-03-20 12:36     ` Russell King - ARM Linux
2014-03-20 13:01   ` Jean-Francois Moine
2014-03-20 13:01     ` Jean-Francois Moine
2014-03-20 13:01     ` Jean-Francois Moine
2014-03-20 13:25     ` Jean-Francois Moine
2014-03-20 13:25       ` Jean-Francois Moine
2014-03-20 13:25       ` Jean-Francois Moine
2014-03-20 13:26     ` Russell King - ARM Linux
2014-03-20 13:26       ` Russell King - ARM Linux
2014-03-20 13:26       ` Russell King - ARM Linux
2014-03-20 13:32     ` Sebastian Hesselbarth
2014-03-20 13:32       ` Sebastian Hesselbarth
2014-03-20 13:52       ` Jean-Francois Moine [this message]
2014-03-20 13:52         ` Jean-Francois Moine
2014-03-20 13:52         ` Jean-Francois Moine
2014-03-20 14:19         ` Sebastian Hesselbarth
2014-03-20 14:19           ` Sebastian Hesselbarth
2014-03-20 14:19           ` Sebastian Hesselbarth
2014-03-20 14:31         ` Russell King - ARM Linux
2014-03-20 14:31           ` Russell King - ARM Linux
2014-03-20 14:31           ` Russell King - ARM Linux
2014-03-20 14:59           ` Jean-Francois Moine
2014-03-20 14:59             ` Jean-Francois Moine
2014-03-20 14:59             ` Jean-Francois Moine
2014-03-20 15:15             ` Robert Nelson
2014-03-20 15:15               ` Robert Nelson
2014-03-20 15:15               ` Robert Nelson
2014-03-20 15:19             ` Russell King - ARM Linux
2014-03-20 15:19               ` Russell King - ARM Linux
2014-03-20 15:19               ` Russell King - ARM Linux
2014-03-20 15:54               ` Jean-Francois Moine
2014-03-20 15:54                 ` Jean-Francois Moine
2014-03-20 15:54                 ` Jean-Francois Moine
2014-03-20 16:22                 ` Russell King - ARM Linux
2014-03-20 16:22                   ` Russell King - ARM Linux
2014-03-20 16:22                   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140320145221.09252bf6@armhf \
    --to=moinejf@free.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.