Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver

[Lee Jones <lee.jones@linaro.org>]

[...]

> >>+static int rtsx_usb_suspend(struct usb_interface *intf, pm_message_t message)
> >>+{
> >>+	struct rtsx_ucr *ucr =
> >>+		(struct rtsx_ucr *)usb_get_intfdata(intf);
> >>+
> >>+	dev_dbg(&intf->dev, "%s called with pm message 0x%04u\n",
> >>+			__func__, message.event);
> >>+
> >>+	mutex_lock(&ucr->dev_mutex);
> >>+	rtsx_usb_turn_off_led(ucr);
> >
> >When is this turned on again?
> >
> 
> The LED is not in a permanent cut-off state after here. It is called
> to guarantee the LED is off during suspend to save more power. It
> could be lit up in the card host drivers(e.g. rtsx_usb_sdmmc.c)
> anytime whenever necessary.
> 
> This has been asked may times. I'm considering putting some comment
> in next revision.

Yes, please do.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog