From: Roger <rogerable@realtek.com>
To: Lee Jones <lee.jones@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Maxim Levitsky <maximlevitsky@gmail.com>,
Alex Dubov <oakad@yahoo.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
linux-mmc@vger.kernel.org, Chris Ball <chris@printf.net>,
linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn,
Dan Carpenter <dan.carpenter@oracle.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH v5 3/3] memstick: Add realtek USB memstick host driver
Date: Tue, 8 Apr 2014 16:06:18 +0800 [thread overview]
Message-ID: <5343ADFA.7010703@realtek.com> (raw)
In-Reply-To: <20140402151654.GA24060@lee--X1>
On 04/02/2014 11:16 PM, Lee Jones wrote:
> On Tue, 01 Apr 2014, Andrew Morton wrote:
>
>> On Tue, 1 Apr 2014 11:20:32 +0800 Roger <rogerable@realtek.com> wrote:
>>
>>> On 03/25/2014 06:44 PM, rogerable@realtek.com wrote:
>>>> From: Roger Tseng <rogerable@realtek.com>
>>>>
>>>> Realtek USB memstick host driver provides memstick host support based on the
>>>> Realtek USB card reader MFD driver.
>>>>
>>>> Signed-off-by: Roger Tseng <rogerable@realtek.com>
>>>> ---
>>>> drivers/memstick/host/Kconfig | 10 +
>>>> drivers/memstick/host/Makefile | 1 +
>>>> drivers/memstick/host/rtsx_usb_ms.c | 839 ++++++++++++++++++++++++++++++++++++
>>>> 3 files changed, 850 insertions(+)
>>>> create mode 100644 drivers/memstick/host/rtsx_usb_ms.c
>>> Hi Andrew,
>>>
>>> Since I'll have to send next revision(v6, to modify patch 1/3) and
>>> you've commented v4, would you also comment or Ack the 3/3 of this one?
>>> This should save one revision for me to make any necessary change.
>>
>> It looks OK to my inexpert eye. It would be better if Maxim and/or Alex
>> could review the code. If that doesn't happen then I guess the best we
>> can do is to go ahead and merge it. Have you worked out via which tree
>> the patches will be merged?
>
> I'll be happy to take the set if one of the subsystem experts would be
> kind enough to cast an eye over it.
>
> Maxim, Alex?
>
Lee,
When I prepare my next submission, I found a previous version of this
patch set(and only the 1/3 'mfd' part) seems to be merged in the
following commit:
commit e5744abb2fa3629aa5a94e21ca1eae32ff2fe00b
Merge: c29aa15 2d28ca7
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mon Apr 7 10:24:18 2014 -0700
Merge tag 'mfd-for-linus-3.15' of
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd
Is there any chance to revert it? Or what can I do to help current
situation?
note: the merged commit:
commit 730876be256603b4ee7225a125467d97a7ce9060
Author: Roger Tseng <rogerable@realtek.com>
Date: Wed Feb 12 18:00:36 2014 +0800
mfd: Add realtek USB card reader driver
Best regards,
Roger Tseng
WARNING: multiple messages have this Message-ID (diff)
From: Roger <rogerable@realtek.com>
To: Lee Jones <lee.jones@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Chris Ball <chris@printf.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Maxim Levitsky <maximlevitsky@gmail.com>,
Alex Dubov <oakad@yahoo.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
<linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
<driverdev-devel@linuxdriverproject.org>,
<wei_wang@realsil.com.cn>, <micky_ching@realsil.com.cn>
Subject: Re: [PATCH v5 3/3] memstick: Add realtek USB memstick host driver
Date: Tue, 8 Apr 2014 16:06:18 +0800 [thread overview]
Message-ID: <5343ADFA.7010703@realtek.com> (raw)
In-Reply-To: <20140402151654.GA24060@lee--X1>
On 04/02/2014 11:16 PM, Lee Jones wrote:
> On Tue, 01 Apr 2014, Andrew Morton wrote:
>
>> On Tue, 1 Apr 2014 11:20:32 +0800 Roger <rogerable@realtek.com> wrote:
>>
>>> On 03/25/2014 06:44 PM, rogerable@realtek.com wrote:
>>>> From: Roger Tseng <rogerable@realtek.com>
>>>>
>>>> Realtek USB memstick host driver provides memstick host support based on the
>>>> Realtek USB card reader MFD driver.
>>>>
>>>> Signed-off-by: Roger Tseng <rogerable@realtek.com>
>>>> ---
>>>> drivers/memstick/host/Kconfig | 10 +
>>>> drivers/memstick/host/Makefile | 1 +
>>>> drivers/memstick/host/rtsx_usb_ms.c | 839 ++++++++++++++++++++++++++++++++++++
>>>> 3 files changed, 850 insertions(+)
>>>> create mode 100644 drivers/memstick/host/rtsx_usb_ms.c
>>> Hi Andrew,
>>>
>>> Since I'll have to send next revision(v6, to modify patch 1/3) and
>>> you've commented v4, would you also comment or Ack the 3/3 of this one?
>>> This should save one revision for me to make any necessary change.
>>
>> It looks OK to my inexpert eye. It would be better if Maxim and/or Alex
>> could review the code. If that doesn't happen then I guess the best we
>> can do is to go ahead and merge it. Have you worked out via which tree
>> the patches will be merged?
>
> I'll be happy to take the set if one of the subsystem experts would be
> kind enough to cast an eye over it.
>
> Maxim, Alex?
>
Lee,
When I prepare my next submission, I found a previous version of this
patch set(and only the 1/3 'mfd' part) seems to be merged in the
following commit:
commit e5744abb2fa3629aa5a94e21ca1eae32ff2fe00b
Merge: c29aa15 2d28ca7
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mon Apr 7 10:24:18 2014 -0700
Merge tag 'mfd-for-linus-3.15' of
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd
Is there any chance to revert it? Or what can I do to help current
situation?
note: the merged commit:
commit 730876be256603b4ee7225a125467d97a7ce9060
Author: Roger Tseng <rogerable@realtek.com>
Date: Wed Feb 12 18:00:36 2014 +0800
mfd: Add realtek USB card reader driver
Best regards,
Roger Tseng
next prev parent reply other threads:[~2014-04-08 8:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 10:44 [PATCH v5 0/3] Add modules for realtek USB card reader rogerable
2014-03-25 10:44 ` rogerable
2014-03-25 10:44 ` [PATCH v5 1/3] mfd: Add realtek USB card reader driver rogerable
2014-03-25 10:44 ` rogerable
2014-03-26 14:36 ` Oliver Neukum
[not found] ` <201403280231.s2S2VP8X017745@rtits1.realtek.com>
2014-03-28 3:33 ` Roger
2014-03-28 3:33 ` Roger
2014-03-28 7:59 ` Lee Jones
2014-03-28 8:31 ` Oliver Neukum
2014-03-28 8:31 ` Oliver Neukum
2014-03-28 8:57 ` Roger
2014-03-28 8:57 ` Roger
2014-03-25 10:44 ` [PATCH v5 2/3] mmc: Add realtek USB sdmmc host driver rogerable
2014-03-25 10:44 ` rogerable
2014-03-25 10:44 ` [PATCH v5 3/3] memstick: Add realtek USB memstick " rogerable
2014-03-25 10:44 ` rogerable
2014-04-01 3:20 ` Roger
2014-04-01 3:20 ` Roger
2014-04-01 22:06 ` Andrew Morton
2014-04-01 22:06 ` Andrew Morton
2014-04-02 15:16 ` Lee Jones
2014-04-02 15:16 ` Lee Jones
2014-04-08 8:06 ` Roger [this message]
2014-04-08 8:06 ` Roger
2014-04-08 11:37 ` Lee Jones
2014-04-08 11:37 ` Lee Jones
2014-04-08 13:10 ` Roger
2014-04-08 13:10 ` Roger
2014-04-08 13:25 ` Dan Carpenter
2014-04-08 13:25 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5343ADFA.7010703@realtek.com \
--to=rogerable@realtek.com \
--cc=akpm@linux-foundation.org \
--cc=chris@printf.net \
--cc=dan.carpenter@oracle.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=oakad@yahoo.com \
--cc=sameo@linux.intel.com \
--cc=ulf.hansson@linaro.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.