From: Shawn Guo <shawn.guo@linaro.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
kernel@pengutronix.de, Russell King <rmk+kernel@arm.linux.org.uk>
Subject: Re: [PATCH] imx-drm: imx-drm-core: Fix imx_drm_encoder_get_mux_id
Date: Mon, 7 Apr 2014 21:46:54 +0800 [thread overview]
Message-ID: <20140407134649.GA3860@dragon> (raw)
In-Reply-To: <1396858956-7096-1-git-send-email-p.zabel@pengutronix.de>
On Mon, Apr 07, 2014 at 10:22:36AM +0200, Philipp Zabel wrote:
> The decoder mux id is equal to the port id of the encoder's input port
> that is connected to the given crtc, not to the endpoint id (which is
> arbitrary and usually zero).
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
It fixes a color corruption issue on my dual display case (LVDS + HDMI).
Tested-by: Shawn Guo <shawn.guo@freescale.com>
Shawn
> ---
> drivers/staging/imx-drm/imx-drm-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c
> index 4144a75..bc7f8bd 100644
> --- a/drivers/staging/imx-drm/imx-drm-core.c
> +++ b/drivers/staging/imx-drm/imx-drm-core.c
> @@ -517,7 +517,7 @@ int imx_drm_encoder_get_mux_id(struct device_node *node,
> of_node_put(port);
> if (port == imx_crtc->port) {
> ret = of_graph_parse_endpoint(ep, &endpoint);
> - return ret ? ret : endpoint.id;
> + return ret ? ret : endpoint.port;
> }
> } while (ep);
>
> --
> 1.9.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@linaro.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Fabio Estevam <fabio.estevam@freescale.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<devel@driverdev.osuosl.org>, <kernel@pengutronix.de>
Subject: Re: [PATCH] imx-drm: imx-drm-core: Fix imx_drm_encoder_get_mux_id
Date: Mon, 7 Apr 2014 21:46:54 +0800 [thread overview]
Message-ID: <20140407134649.GA3860@dragon> (raw)
In-Reply-To: <1396858956-7096-1-git-send-email-p.zabel@pengutronix.de>
On Mon, Apr 07, 2014 at 10:22:36AM +0200, Philipp Zabel wrote:
> The decoder mux id is equal to the port id of the encoder's input port
> that is connected to the given crtc, not to the endpoint id (which is
> arbitrary and usually zero).
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
It fixes a color corruption issue on my dual display case (LVDS + HDMI).
Tested-by: Shawn Guo <shawn.guo@freescale.com>
Shawn
> ---
> drivers/staging/imx-drm/imx-drm-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c
> index 4144a75..bc7f8bd 100644
> --- a/drivers/staging/imx-drm/imx-drm-core.c
> +++ b/drivers/staging/imx-drm/imx-drm-core.c
> @@ -517,7 +517,7 @@ int imx_drm_encoder_get_mux_id(struct device_node *node,
> of_node_put(port);
> if (port == imx_crtc->port) {
> ret = of_graph_parse_endpoint(ep, &endpoint);
> - return ret ? ret : endpoint.id;
> + return ret ? ret : endpoint.port;
> }
> } while (ep);
>
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-04-07 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 8:22 [PATCH] imx-drm: imx-drm-core: Fix imx_drm_encoder_get_mux_id Philipp Zabel
2014-04-07 8:22 ` Philipp Zabel
2014-04-07 13:46 ` Shawn Guo [this message]
2014-04-07 13:46 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407134649.GA3860@dragon \
--to=shawn.guo@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.