* [PATCH] imx-drm: imx-drm-core: Fix imx_drm_encoder_get_mux_id
@ 2014-04-07 8:22 ` Philipp Zabel
0 siblings, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2014-04-07 8:22 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Fabio Estevam, devel, linux-kernel, dri-devel, kernel,
Russell King
The decoder mux id is equal to the port id of the encoder's input port
that is connected to the given crtc, not to the endpoint id (which is
arbitrary and usually zero).
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/staging/imx-drm/imx-drm-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c
index 4144a75..bc7f8bd 100644
--- a/drivers/staging/imx-drm/imx-drm-core.c
+++ b/drivers/staging/imx-drm/imx-drm-core.c
@@ -517,7 +517,7 @@ int imx_drm_encoder_get_mux_id(struct device_node *node,
of_node_put(port);
if (port == imx_crtc->port) {
ret = of_graph_parse_endpoint(ep, &endpoint);
- return ret ? ret : endpoint.id;
+ return ret ? ret : endpoint.port;
}
} while (ep);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] imx-drm: imx-drm-core: Fix imx_drm_encoder_get_mux_id
@ 2014-04-07 8:22 ` Philipp Zabel
0 siblings, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2014-04-07 8:22 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Russell King, Fabio Estevam, Shawn Guo, dri-devel, linux-kernel,
devel, kernel, Philipp Zabel
The decoder mux id is equal to the port id of the encoder's input port
that is connected to the given crtc, not to the endpoint id (which is
arbitrary and usually zero).
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/staging/imx-drm/imx-drm-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c
index 4144a75..bc7f8bd 100644
--- a/drivers/staging/imx-drm/imx-drm-core.c
+++ b/drivers/staging/imx-drm/imx-drm-core.c
@@ -517,7 +517,7 @@ int imx_drm_encoder_get_mux_id(struct device_node *node,
of_node_put(port);
if (port == imx_crtc->port) {
ret = of_graph_parse_endpoint(ep, &endpoint);
- return ret ? ret : endpoint.id;
+ return ret ? ret : endpoint.port;
}
} while (ep);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] imx-drm: imx-drm-core: Fix imx_drm_encoder_get_mux_id
2014-04-07 8:22 ` Philipp Zabel
@ 2014-04-07 13:46 ` Shawn Guo
-1 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2014-04-07 13:46 UTC (permalink / raw)
To: Philipp Zabel
Cc: Fabio Estevam, devel, Greg Kroah-Hartman, linux-kernel, dri-devel,
kernel, Russell King
On Mon, Apr 07, 2014 at 10:22:36AM +0200, Philipp Zabel wrote:
> The decoder mux id is equal to the port id of the encoder's input port
> that is connected to the given crtc, not to the endpoint id (which is
> arbitrary and usually zero).
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
It fixes a color corruption issue on my dual display case (LVDS + HDMI).
Tested-by: Shawn Guo <shawn.guo@freescale.com>
Shawn
> ---
> drivers/staging/imx-drm/imx-drm-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c
> index 4144a75..bc7f8bd 100644
> --- a/drivers/staging/imx-drm/imx-drm-core.c
> +++ b/drivers/staging/imx-drm/imx-drm-core.c
> @@ -517,7 +517,7 @@ int imx_drm_encoder_get_mux_id(struct device_node *node,
> of_node_put(port);
> if (port == imx_crtc->port) {
> ret = of_graph_parse_endpoint(ep, &endpoint);
> - return ret ? ret : endpoint.id;
> + return ret ? ret : endpoint.port;
> }
> } while (ep);
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] imx-drm: imx-drm-core: Fix imx_drm_encoder_get_mux_id
@ 2014-04-07 13:46 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2014-04-07 13:46 UTC (permalink / raw)
To: Philipp Zabel
Cc: Greg Kroah-Hartman, Russell King, Fabio Estevam, dri-devel,
linux-kernel, devel, kernel
On Mon, Apr 07, 2014 at 10:22:36AM +0200, Philipp Zabel wrote:
> The decoder mux id is equal to the port id of the encoder's input port
> that is connected to the given crtc, not to the endpoint id (which is
> arbitrary and usually zero).
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
It fixes a color corruption issue on my dual display case (LVDS + HDMI).
Tested-by: Shawn Guo <shawn.guo@freescale.com>
Shawn
> ---
> drivers/staging/imx-drm/imx-drm-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c
> index 4144a75..bc7f8bd 100644
> --- a/drivers/staging/imx-drm/imx-drm-core.c
> +++ b/drivers/staging/imx-drm/imx-drm-core.c
> @@ -517,7 +517,7 @@ int imx_drm_encoder_get_mux_id(struct device_node *node,
> of_node_put(port);
> if (port == imx_crtc->port) {
> ret = of_graph_parse_endpoint(ep, &endpoint);
> - return ret ? ret : endpoint.id;
> + return ret ? ret : endpoint.port;
> }
> } while (ep);
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-07 13:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-07 8:22 [PATCH] imx-drm: imx-drm-core: Fix imx_drm_encoder_get_mux_id Philipp Zabel
2014-04-07 8:22 ` Philipp Zabel
2014-04-07 13:46 ` Shawn Guo
2014-04-07 13:46 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.