All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: Huang Shijie <b32955@freescale.com>,
	Lee Jones <lee.jones@linaro.org>,
	linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 1/9] mtd: spi-nor: drop \t after #define
Date: Wed, 9 Apr 2014 10:56:56 -0700	[thread overview]
Message-ID: <20140409175656.GF32070@ld-irv-0074> (raw)
In-Reply-To: <201404091940.14392.marex@denx.de>

On Wed, Apr 09, 2014 at 07:40:14PM +0200, Marek Vasut wrote:
> On Wednesday, April 09, 2014 at 07:32:46 PM, Brian Norris wrote:
> > +#define OPCODE_DUAL_READ        0x3b    /* Read data bytes (Dual SPI) */
> > +#define OPCODE_QUAD_READ        0x6b    /* Read data bytes (Quad SPI) */
> 
> This is still a little non-standard -- or rather -- inconsistent here. You 
> should use space after #define and \t after the name I'd say. I'd also say these 
> two slipped your attention as the others do it just like that.

Thanks. I think I noticed this at one point, but in my patch juggling, I
never straightened it out. I'll send v2 eventually. And in the meantime,
I'm keeping my patches here:

  http://git.infradead.org/users/norris/linux-mtd.git/shortlog/refs/heads/spinor

Brian

WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Huang Shijie <b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/9] mtd: spi-nor: drop \t after #define
Date: Wed, 9 Apr 2014 10:56:56 -0700	[thread overview]
Message-ID: <20140409175656.GF32070@ld-irv-0074> (raw)
In-Reply-To: <201404091940.14392.marex-ynQEQJNshbs@public.gmane.org>

On Wed, Apr 09, 2014 at 07:40:14PM +0200, Marek Vasut wrote:
> On Wednesday, April 09, 2014 at 07:32:46 PM, Brian Norris wrote:
> > +#define OPCODE_DUAL_READ        0x3b    /* Read data bytes (Dual SPI) */
> > +#define OPCODE_QUAD_READ        0x6b    /* Read data bytes (Quad SPI) */
> 
> This is still a little non-standard -- or rather -- inconsistent here. You 
> should use space after #define and \t after the name I'd say. I'd also say these 
> two slipped your attention as the others do it just like that.

Thanks. I think I noticed this at one point, but in my patch juggling, I
never straightened it out. I'll send v2 eventually. And in the meantime,
I'm keeping my patches here:

  http://git.infradead.org/users/norris/linux-mtd.git/shortlog/refs/heads/spinor

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-04-09 17:57 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 17:32 [PATCH 1/9] mtd: spi-nor: drop \t after #define Brian Norris
2014-04-09 17:32 ` Brian Norris
2014-04-09 17:32 ` [PATCH 2/9] mtd: spi-nor: re-name OPCODE_* to SPINOR_OP_* Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-09 17:41   ` Marek Vasut
2014-04-09 17:41     ` Marek Vasut
2014-04-10  7:42   ` Huang Shijie
2014-04-10  7:42     ` Huang Shijie
2014-04-09 17:32 ` [PATCH 3/9] mtd: spi-nor: unify read opcode variants with ST SPI FSM Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-09 17:41   ` Marek Vasut
2014-04-09 17:41     ` Marek Vasut
2014-04-10  7:43   ` Huang Shijie
2014-04-10  7:43     ` Huang Shijie
2014-04-10  7:47   ` Huang Shijie
2014-04-10  7:47     ` Huang Shijie
2014-04-10 19:34     ` Brian Norris
2014-04-10 19:34       ` Brian Norris
2014-04-09 17:32 ` [PATCH 4/9] Documentation: spi-nor: rewrite some portions Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-09 17:44   ` Marek Vasut
2014-04-09 17:44     ` Marek Vasut
2014-04-09 18:14     ` Brian Norris
2014-04-09 18:14       ` Brian Norris
2014-04-09 17:32 ` [PATCH 5/9] mtd: spi-nor: shorten Kconfig naming Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-09 17:44   ` Marek Vasut
2014-04-09 17:44     ` Marek Vasut
2014-04-10  7:39   ` Huang Shijie
2014-04-10  7:39     ` Huang Shijie
2014-04-09 17:32 ` [PATCH 6/9] mtd: st_spi_fsm: fixup Kconfig dependency Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-10  7:57   ` Lee Jones
2014-04-10  7:57     ` Lee Jones
2014-04-09 17:32 ` [PATCH 7/9] mtd: st_spi_fsm: kill duplicate CMD definitions Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-10  7:56   ` Lee Jones
2014-04-10  7:56     ` Lee Jones
2014-04-10 18:58     ` Brian Norris
2014-04-10 18:58       ` Brian Norris
2014-04-10 18:01   ` Geert Uytterhoeven
2014-04-10 18:01     ` Geert Uytterhoeven
2014-04-10 18:59     ` Brian Norris
2014-04-10 18:59       ` Brian Norris
2014-04-09 17:32 ` [PATCH 8/9] mtd: st_spi_fsm: replace FLACH_CMD_* with SPINOR_OP_* Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-10  7:52   ` Lee Jones
2014-04-10  7:52     ` Lee Jones
2014-04-09 17:32 ` [PATCH 9/9] mtd: st_spi_fsm: begin using spi-nor.h opcodes Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-10  7:50   ` Lee Jones
2014-04-10  7:50     ` Lee Jones
2014-04-09 17:40 ` [PATCH 1/9] mtd: spi-nor: drop \t after #define Marek Vasut
2014-04-09 17:40   ` Marek Vasut
2014-04-09 17:56   ` Brian Norris [this message]
2014-04-09 17:56     ` Brian Norris
2014-04-10  7:34 ` Huang Shijie
2014-04-10  7:34   ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140409175656.GF32070@ld-irv-0074 \
    --to=computersforpeace@gmail.com \
    --cc=b32955@freescale.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marex@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.