All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Marek Vasut <marex@denx.de>, Lee Jones <lee.jones@linaro.org>,
	linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 3/9] mtd: spi-nor: unify read opcode variants with ST SPI FSM
Date: Thu, 10 Apr 2014 15:47:13 +0800	[thread overview]
Message-ID: <20140410074711.GG24100@localhost> (raw)
In-Reply-To: <1397064774-31784-3-git-send-email-computersforpeace@gmail.com>

On Wed, Apr 09, 2014 at 10:32:48AM -0700, Brian Norris wrote:
> serial_flash_cmds.h defines our opcodes a little differently. Let's
> borrow its naming, since it's borrowed from the SFDP standard, and it's
> more extensible.
> 
> This prepares us for merging serial_flash_cmds.h and spi-nor.h opcode
> listing.
> 
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 16 ++++++++--------
>  include/linux/mtd/spi-nor.h   | 24 ++++++++++++++++--------
Please also change the fsl-quadspi.c which also uses the opcodes.


thanks
Huang Shijie

WARNING: multiple messages have this Message-ID (diff)
From: Huang Shijie <b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: <linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
Subject: Re: [PATCH 3/9] mtd: spi-nor: unify read opcode variants with ST SPI FSM
Date: Thu, 10 Apr 2014 15:47:13 +0800	[thread overview]
Message-ID: <20140410074711.GG24100@localhost> (raw)
In-Reply-To: <1397064774-31784-3-git-send-email-computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Wed, Apr 09, 2014 at 10:32:48AM -0700, Brian Norris wrote:
> serial_flash_cmds.h defines our opcodes a little differently. Let's
> borrow its naming, since it's borrowed from the SFDP standard, and it's
> more extensible.
> 
> This prepares us for merging serial_flash_cmds.h and spi-nor.h opcode
> listing.
> 
> Signed-off-by: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 16 ++++++++--------
>  include/linux/mtd/spi-nor.h   | 24 ++++++++++++++++--------
Please also change the fsl-quadspi.c which also uses the opcodes.


thanks
Huang Shijie



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-04-10  8:41 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 17:32 [PATCH 1/9] mtd: spi-nor: drop \t after #define Brian Norris
2014-04-09 17:32 ` Brian Norris
2014-04-09 17:32 ` [PATCH 2/9] mtd: spi-nor: re-name OPCODE_* to SPINOR_OP_* Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-09 17:41   ` Marek Vasut
2014-04-09 17:41     ` Marek Vasut
2014-04-10  7:42   ` Huang Shijie
2014-04-10  7:42     ` Huang Shijie
2014-04-09 17:32 ` [PATCH 3/9] mtd: spi-nor: unify read opcode variants with ST SPI FSM Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-09 17:41   ` Marek Vasut
2014-04-09 17:41     ` Marek Vasut
2014-04-10  7:43   ` Huang Shijie
2014-04-10  7:43     ` Huang Shijie
2014-04-10  7:47   ` Huang Shijie [this message]
2014-04-10  7:47     ` Huang Shijie
2014-04-10 19:34     ` Brian Norris
2014-04-10 19:34       ` Brian Norris
2014-04-09 17:32 ` [PATCH 4/9] Documentation: spi-nor: rewrite some portions Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-09 17:44   ` Marek Vasut
2014-04-09 17:44     ` Marek Vasut
2014-04-09 18:14     ` Brian Norris
2014-04-09 18:14       ` Brian Norris
2014-04-09 17:32 ` [PATCH 5/9] mtd: spi-nor: shorten Kconfig naming Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-09 17:44   ` Marek Vasut
2014-04-09 17:44     ` Marek Vasut
2014-04-10  7:39   ` Huang Shijie
2014-04-10  7:39     ` Huang Shijie
2014-04-09 17:32 ` [PATCH 6/9] mtd: st_spi_fsm: fixup Kconfig dependency Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-10  7:57   ` Lee Jones
2014-04-10  7:57     ` Lee Jones
2014-04-09 17:32 ` [PATCH 7/9] mtd: st_spi_fsm: kill duplicate CMD definitions Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-10  7:56   ` Lee Jones
2014-04-10  7:56     ` Lee Jones
2014-04-10 18:58     ` Brian Norris
2014-04-10 18:58       ` Brian Norris
2014-04-10 18:01   ` Geert Uytterhoeven
2014-04-10 18:01     ` Geert Uytterhoeven
2014-04-10 18:59     ` Brian Norris
2014-04-10 18:59       ` Brian Norris
2014-04-09 17:32 ` [PATCH 8/9] mtd: st_spi_fsm: replace FLACH_CMD_* with SPINOR_OP_* Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-10  7:52   ` Lee Jones
2014-04-10  7:52     ` Lee Jones
2014-04-09 17:32 ` [PATCH 9/9] mtd: st_spi_fsm: begin using spi-nor.h opcodes Brian Norris
2014-04-09 17:32   ` Brian Norris
2014-04-10  7:50   ` Lee Jones
2014-04-10  7:50     ` Lee Jones
2014-04-09 17:40 ` [PATCH 1/9] mtd: spi-nor: drop \t after #define Marek Vasut
2014-04-09 17:40   ` Marek Vasut
2014-04-09 17:56   ` Brian Norris
2014-04-09 17:56     ` Brian Norris
2014-04-10  7:34 ` Huang Shijie
2014-04-10  7:34   ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140410074711.GG24100@localhost \
    --to=b32955@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marex@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.