From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ALSA: sound/atmel-ac97c.h: Remove unused flags from platform data
Date: Tue, 15 Apr 2014 00:51:29 +0200 [thread overview]
Message-ID: <20140414225129.GZ2967@piout.net> (raw)
In-Reply-To: <1397293707-26890-3-git-send-email-alexanders83@web.de>
On 12/04/2014 at 11:08:25 +0200, Alexander Stein wrote :
> This platform data member is unsed, so remove it.
^
another typo :)
>
> Signed-off-by: Alexander Stein <alexanders83@web.de>
I would say that it doesn't matter anymore but no code is better tahn
dead code.
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> include/sound/atmel-ac97c.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/sound/atmel-ac97c.h b/include/sound/atmel-ac97c.h
> index e6aabdb..00e6c289 100644
> --- a/include/sound/atmel-ac97c.h
> +++ b/include/sound/atmel-ac97c.h
> @@ -23,7 +23,6 @@
> * @reset_pin: GPIO pin wired to the reset input on the external AC97 codec,
> * optional to use, set to -ENODEV if not in use. AC97 layer will
> * try to do a software reset of the external codec anyway.
> - * @flags: Flags for which directions should be enabled.
> *
> * If the user do not want to use a DMA channel for playback or capture, i.e.
> * only one feature is required on the board. The slave for playback or capture
> @@ -33,7 +32,6 @@
> struct ac97c_platform_data {
> struct dw_dma_slave rx_dws;
> struct dw_dma_slave tx_dws;
> - unsigned int flags;
> int reset_pin;
> };
>
> --
> 1.9.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Alexander Stein <alexanders83@web.de>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Randy Dunlap <rdunlap@infradead.org>,
Andrew Victor <linux@maxim.org.za>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/4] ALSA: sound/atmel-ac97c.h: Remove unused flags from platform data
Date: Tue, 15 Apr 2014 00:51:29 +0200 [thread overview]
Message-ID: <20140414225129.GZ2967@piout.net> (raw)
In-Reply-To: <1397293707-26890-3-git-send-email-alexanders83@web.de>
On 12/04/2014 at 11:08:25 +0200, Alexander Stein wrote :
> This platform data member is unsed, so remove it.
^
another typo :)
>
> Signed-off-by: Alexander Stein <alexanders83@web.de>
I would say that it doesn't matter anymore but no code is better tahn
dead code.
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> include/sound/atmel-ac97c.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/sound/atmel-ac97c.h b/include/sound/atmel-ac97c.h
> index e6aabdb..00e6c289 100644
> --- a/include/sound/atmel-ac97c.h
> +++ b/include/sound/atmel-ac97c.h
> @@ -23,7 +23,6 @@
> * @reset_pin: GPIO pin wired to the reset input on the external AC97 codec,
> * optional to use, set to -ENODEV if not in use. AC97 layer will
> * try to do a software reset of the external codec anyway.
> - * @flags: Flags for which directions should be enabled.
> *
> * If the user do not want to use a DMA channel for playback or capture, i.e.
> * only one feature is required on the board. The slave for playback or capture
> @@ -33,7 +32,6 @@
> struct ac97c_platform_data {
> struct dw_dma_slave rx_dws;
> struct dw_dma_slave tx_dws;
> - unsigned int flags;
> int reset_pin;
> };
>
> --
> 1.9.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-14 22:51 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 9:08 Device tree support for Atmel AC97 controller on AT91SAM9263 Alexander Stein
2014-04-12 9:08 ` Alexander Stein
2014-04-12 9:08 ` [PATCH 1/4] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver Alexander Stein
2014-04-12 9:08 ` Alexander Stein
2014-04-14 22:48 ` Alexandre Belloni
2014-04-14 22:48 ` Alexandre Belloni
2014-04-12 9:08 ` [PATCH 2/4] ALSA: sound/atmel-ac97c.h: Remove unused flags from platform data Alexander Stein
2014-04-12 9:08 ` Alexander Stein
2014-04-14 22:51 ` Alexandre Belloni [this message]
2014-04-14 22:51 ` Alexandre Belloni
2014-04-12 9:08 ` [PATCH 3/4] ALSA: sound/atmel/ac97c.c: Add device tree support Alexander Stein
2014-04-12 9:08 ` Alexander Stein
2014-04-12 10:31 ` Alexander Shiyan
2014-04-12 10:31 ` Alexander Shiyan
2014-04-12 10:42 ` Alexander Stein
2014-04-12 10:42 ` Alexander Stein
2014-04-12 10:48 ` Alexander Shiyan
2014-04-12 10:48 ` Alexander Shiyan
2014-04-13 8:32 ` Alexander Stein
2014-04-13 8:32 ` Alexander Stein
2014-04-14 23:21 ` Alexandre Belloni
2014-04-14 23:21 ` Alexandre Belloni
2014-04-15 19:17 ` Alexander Stein
2014-04-15 19:17 ` Re: " Alexander Stein
[not found] ` <1397293707-26890-4-git-send-email-alexanders83-S0/GAf8tV78@public.gmane.org>
2014-04-12 10:31 ` Alexander Shiyan
2014-04-12 10:31 ` Alexander Shiyan
2014-04-14 23:07 ` Alexandre Belloni
2014-04-14 23:07 ` Alexandre Belloni
2014-04-12 9:08 ` [PATCH 4/4] ARM: at91/dt: sam9263: Add ac97 device node Alexander Stein
2014-04-12 9:08 ` Alexander Stein
2014-04-14 8:39 ` Device tree support for Atmel AC97 controller on AT91SAM9263 Bo Shen
2014-04-14 8:39 ` Bo Shen
2014-04-14 18:34 ` Alexander Stein
2014-04-14 18:34 ` Alexander Stein
2014-04-14 8:42 ` Takashi Iwai
2014-04-14 8:42 ` Takashi Iwai
2014-04-14 18:43 ` Alexander Stein
2014-04-14 18:43 ` Alexander Stein
2014-04-14 22:47 ` Alexandre Belloni
2014-04-14 22:47 ` Alexandre Belloni
2014-04-15 5:59 ` Takashi Iwai
2014-04-15 5:59 ` Takashi Iwai
2014-04-15 17:38 ` [PATCH v2 1/2] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver Alexander Stein
2014-04-15 17:38 ` [PATCH v2 2/2] ALSA: sound/atmel-ac97c.h: Remove unused flags from platform data Alexander Stein
2014-04-16 7:39 ` Nicolas Ferre
2014-04-16 7:39 ` [PATCH v2 1/2] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver Nicolas Ferre
2014-04-16 8:23 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414225129.GZ2967@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.