All of lore.kernel.org
 help / color / mirror / Atom feed
From: voice.shen@atmel.com (Bo Shen)
To: linux-arm-kernel@lists.infradead.org
Subject: Device tree support for Atmel AC97 controller on AT91SAM9263
Date: Mon, 14 Apr 2014 16:39:43 +0800	[thread overview]
Message-ID: <534B9ECF.806@atmel.com> (raw)
In-Reply-To: <1397293707-26890-1-git-send-email-alexanders83@web.de>

Hi Alexander,

On 04/12/2014 05:08 PM, Alexander Stein wrote:
> This set of patches add device tree support for the AC97 controller found
> on AT91SAM9263.
> The first two patches are minor cleanup, while the last ones add the actual
> support.

I just test the whole patch series, and find issues to work with device 
tree kernel.
When we use dt kernel, no where assign the device id (so take it as 
"-1"), so when register devices, it will be /dev/snd/pcmC0D-1p and 
/dev/snd/pcmC0D-1c. So, the sound won't work.

The root cause is that when call "snd_pcm_new", it will pass 
"chip->pdev->id" as parameter.

So, I am thinking whether this should be fix in <sound/atmel/ac97c.c> or 
in <sound/core/pcm.c>

> Regards,
> Alexander

Best Regards,
Bo Shen

WARNING: multiple messages have this Message-ID (diff)
From: Bo Shen <voice.shen@atmel.com>
To: Alexander Stein <alexanders83@web.de>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Andrew Victor <linux@maxim.org.za>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	Grant Likely <grant.likely@linaro.org>,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: Device tree support for Atmel AC97 controller on AT91SAM9263
Date: Mon, 14 Apr 2014 16:39:43 +0800	[thread overview]
Message-ID: <534B9ECF.806@atmel.com> (raw)
In-Reply-To: <1397293707-26890-1-git-send-email-alexanders83@web.de>

Hi Alexander,

On 04/12/2014 05:08 PM, Alexander Stein wrote:
> This set of patches add device tree support for the AC97 controller found
> on AT91SAM9263.
> The first two patches are minor cleanup, while the last ones add the actual
> support.

I just test the whole patch series, and find issues to work with device 
tree kernel.
When we use dt kernel, no where assign the device id (so take it as 
"-1"), so when register devices, it will be /dev/snd/pcmC0D-1p and 
/dev/snd/pcmC0D-1c. So, the sound won't work.

The root cause is that when call "snd_pcm_new", it will pass 
"chip->pdev->id" as parameter.

So, I am thinking whether this should be fix in <sound/atmel/ac97c.c> or 
in <sound/core/pcm.c>

> Regards,
> Alexander

Best Regards,
Bo Shen

  parent reply	other threads:[~2014-04-14  8:39 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-12  9:08 Device tree support for Atmel AC97 controller on AT91SAM9263 Alexander Stein
2014-04-12  9:08 ` Alexander Stein
2014-04-12  9:08 ` [PATCH 1/4] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver Alexander Stein
2014-04-12  9:08   ` Alexander Stein
2014-04-14 22:48   ` Alexandre Belloni
2014-04-14 22:48     ` Alexandre Belloni
2014-04-12  9:08 ` [PATCH 2/4] ALSA: sound/atmel-ac97c.h: Remove unused flags from platform data Alexander Stein
2014-04-12  9:08   ` Alexander Stein
2014-04-14 22:51   ` Alexandre Belloni
2014-04-14 22:51     ` Alexandre Belloni
2014-04-12  9:08 ` [PATCH 3/4] ALSA: sound/atmel/ac97c.c: Add device tree support Alexander Stein
2014-04-12  9:08   ` Alexander Stein
2014-04-12 10:31   ` Alexander Shiyan
2014-04-12 10:31     ` Alexander Shiyan
2014-04-12 10:42     ` Alexander Stein
2014-04-12 10:42       ` Alexander Stein
2014-04-12 10:48       ` Alexander Shiyan
2014-04-12 10:48         ` Alexander Shiyan
2014-04-13  8:32         ` Alexander Stein
2014-04-13  8:32           ` Alexander Stein
2014-04-14 23:21           ` Alexandre Belloni
2014-04-14 23:21             ` Alexandre Belloni
2014-04-15 19:17             ` Alexander Stein
2014-04-15 19:17               ` Re: " Alexander Stein
     [not found]   ` <1397293707-26890-4-git-send-email-alexanders83-S0/GAf8tV78@public.gmane.org>
2014-04-12 10:31     ` Alexander Shiyan
2014-04-12 10:31   ` Alexander Shiyan
2014-04-14 23:07   ` Alexandre Belloni
2014-04-14 23:07     ` Alexandre Belloni
2014-04-12  9:08 ` [PATCH 4/4] ARM: at91/dt: sam9263: Add ac97 device node Alexander Stein
2014-04-12  9:08   ` Alexander Stein
2014-04-14  8:39 ` Bo Shen [this message]
2014-04-14  8:39   ` Device tree support for Atmel AC97 controller on AT91SAM9263 Bo Shen
2014-04-14 18:34   ` Alexander Stein
2014-04-14 18:34     ` Alexander Stein
2014-04-14  8:42 ` Takashi Iwai
2014-04-14  8:42   ` Takashi Iwai
2014-04-14 18:43   ` Alexander Stein
2014-04-14 18:43     ` Alexander Stein
2014-04-14 22:47     ` Alexandre Belloni
2014-04-14 22:47       ` Alexandre Belloni
2014-04-15  5:59       ` Takashi Iwai
2014-04-15  5:59         ` Takashi Iwai
2014-04-15 17:38 ` [PATCH v2 1/2] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver Alexander Stein
2014-04-15 17:38   ` [PATCH v2 2/2] ALSA: sound/atmel-ac97c.h: Remove unused flags from platform data Alexander Stein
2014-04-16  7:39     ` Nicolas Ferre
2014-04-16  7:39   ` [PATCH v2 1/2] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver Nicolas Ferre
2014-04-16  8:23   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534B9ECF.806@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.