From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] usb: host: xhci-plat: Allow to register glue code using the device tree
Date: Sat, 19 Apr 2014 22:15:17 -0500 [thread overview]
Message-ID: <20140420031517.GA26893@saruman.home> (raw)
In-Reply-To: <1397816563-9000-2-git-send-email-gregory.clement@free-electrons.com>
Hi,
On Fri, Apr 18, 2014 at 12:22:36PM +0200, Gregory CLEMENT wrote:
> This patch allow to register specific glue code for xhci controller.
> It creates a structure called xhci_plat_ops to register functions
> specific to an SoC. Currently there are only probe() and remove() but
What SoC-specific code do you need ?
> it can be extended later, it was the point to create such a structure.
>
> Each compatible string can then be associated to an instance of this
> structure. In the non device tree case a default structure is used.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> drivers/usb/host/xhci-plat.c | 72 +++++++++++++++++++++++++++++++++++++++++---
> drivers/usb/host/xhci.h | 4 +++
> 2 files changed, 72 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 151901ce1ba9..8029cc82edc4 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -16,6 +16,7 @@
> #include <linux/slab.h>
> #include <linux/of.h>
> #include <linux/dma-mapping.h>
> +#include <linux/of_device.h>
>
> #include "xhci.h"
>
> @@ -85,7 +86,7 @@ static const struct hc_driver xhci_plat_xhci_driver = {
> .bus_resume = xhci_bus_resume,
> };
>
> -static int xhci_plat_probe(struct platform_device *pdev)
> +int common_xhci_plat_probe(struct platform_device *pdev, void *priv)
no, I rather not see this sort of hack.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140419/c03b4c88/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
Mathias Nyman <mathias.nyman@intel.com>,
devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Nadav Haklai <nadavh@marvell.com>,
Lior Amsalem <alior@marvell.com>,
Rob Herring <robh+dt@kernel.org>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Grant Likely <grant.likely@linaro.org>,
Tawfik Bayouk <tawfik@marvell.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 1/8] usb: host: xhci-plat: Allow to register glue code using the device tree
Date: Sat, 19 Apr 2014 22:15:17 -0500 [thread overview]
Message-ID: <20140420031517.GA26893@saruman.home> (raw)
In-Reply-To: <1397816563-9000-2-git-send-email-gregory.clement@free-electrons.com>
[-- Attachment #1.1: Type: text/plain, Size: 1502 bytes --]
Hi,
On Fri, Apr 18, 2014 at 12:22:36PM +0200, Gregory CLEMENT wrote:
> This patch allow to register specific glue code for xhci controller.
> It creates a structure called xhci_plat_ops to register functions
> specific to an SoC. Currently there are only probe() and remove() but
What SoC-specific code do you need ?
> it can be extended later, it was the point to create such a structure.
>
> Each compatible string can then be associated to an instance of this
> structure. In the non device tree case a default structure is used.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> drivers/usb/host/xhci-plat.c | 72 +++++++++++++++++++++++++++++++++++++++++---
> drivers/usb/host/xhci.h | 4 +++
> 2 files changed, 72 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 151901ce1ba9..8029cc82edc4 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -16,6 +16,7 @@
> #include <linux/slab.h>
> #include <linux/of.h>
> #include <linux/dma-mapping.h>
> +#include <linux/of_device.h>
>
> #include "xhci.h"
>
> @@ -85,7 +86,7 @@ static const struct hc_driver xhci_plat_xhci_driver = {
> .bus_resume = xhci_bus_resume,
> };
>
> -static int xhci_plat_probe(struct platform_device *pdev)
> +int common_xhci_plat_probe(struct platform_device *pdev, void *priv)
no, I rather not see this sort of hack.
--
balbi
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
<linux-arm-kernel@lists.infradead.org>,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/8] usb: host: xhci-plat: Allow to register glue code using the device tree
Date: Sat, 19 Apr 2014 22:15:17 -0500 [thread overview]
Message-ID: <20140420031517.GA26893@saruman.home> (raw)
In-Reply-To: <1397816563-9000-2-git-send-email-gregory.clement@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]
Hi,
On Fri, Apr 18, 2014 at 12:22:36PM +0200, Gregory CLEMENT wrote:
> This patch allow to register specific glue code for xhci controller.
> It creates a structure called xhci_plat_ops to register functions
> specific to an SoC. Currently there are only probe() and remove() but
What SoC-specific code do you need ?
> it can be extended later, it was the point to create such a structure.
>
> Each compatible string can then be associated to an instance of this
> structure. In the non device tree case a default structure is used.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> drivers/usb/host/xhci-plat.c | 72 +++++++++++++++++++++++++++++++++++++++++---
> drivers/usb/host/xhci.h | 4 +++
> 2 files changed, 72 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 151901ce1ba9..8029cc82edc4 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -16,6 +16,7 @@
> #include <linux/slab.h>
> #include <linux/of.h>
> #include <linux/dma-mapping.h>
> +#include <linux/of_device.h>
>
> #include "xhci.h"
>
> @@ -85,7 +86,7 @@ static const struct hc_driver xhci_plat_xhci_driver = {
> .bus_resume = xhci_bus_resume,
> };
>
> -static int xhci_plat_probe(struct platform_device *pdev)
> +int common_xhci_plat_probe(struct platform_device *pdev, void *priv)
no, I rather not see this sort of hack.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-04-20 3:15 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 10:22 [PATCH 0/8] USB3 support for Armada 38x Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` [PATCH 1/8] usb: host: xhci-plat: Allow to register glue code using the device tree Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-20 3:15 ` Felipe Balbi [this message]
2014-04-20 3:15 ` Felipe Balbi
2014-04-20 3:15 ` Felipe Balbi
2014-04-18 10:22 ` [PATCH 2/8] usb: host: xhci-plat: Add support for the Armada 38x glue code Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 11:13 ` Sebastian Hesselbarth
2014-04-18 11:13 ` Sebastian Hesselbarth
2014-04-18 11:13 ` Sebastian Hesselbarth
2014-04-18 11:43 ` Gregory CLEMENT
2014-04-18 11:43 ` Gregory CLEMENT
2014-04-18 11:47 ` Sebastian Hesselbarth
2014-04-18 11:47 ` Sebastian Hesselbarth
2014-04-18 11:47 ` Sebastian Hesselbarth
2014-04-20 3:20 ` Felipe Balbi
2014-04-20 3:20 ` Felipe Balbi
2014-04-20 3:20 ` Felipe Balbi
2014-04-23 7:44 ` Gregory CLEMENT
2014-04-23 7:44 ` Gregory CLEMENT
2014-04-23 7:44 ` Gregory CLEMENT
2014-04-23 15:22 ` Felipe Balbi
2014-04-23 15:22 ` Felipe Balbi
2014-04-23 15:22 ` Felipe Balbi
2014-04-18 10:22 ` [PATCH 3/8] xhci-platform: Add a new controller using xhci: Armada 38x Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-20 3:21 ` Felipe Balbi
2014-04-20 3:21 ` Felipe Balbi
2014-04-20 3:21 ` Felipe Balbi
2014-04-18 10:22 ` [PATCH 4/8] ARM: mvebu: Add USB3 UTMI support Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 11:19 ` Sebastian Hesselbarth
2014-04-18 11:19 ` Sebastian Hesselbarth
2014-04-18 11:19 ` Sebastian Hesselbarth
2014-04-18 12:19 ` Gregory CLEMENT
2014-04-18 12:19 ` Gregory CLEMENT
2014-04-18 12:19 ` Gregory CLEMENT
2014-04-20 3:22 ` Felipe Balbi
2014-04-20 3:22 ` Felipe Balbi
2014-04-20 3:22 ` Felipe Balbi
2014-04-18 10:22 ` [PATCH 5/8] ARM: mvebu: Add Device Tree description of xHCI hosts on Armada 38x Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 11:23 ` Sebastian Hesselbarth
2014-04-18 11:23 ` Sebastian Hesselbarth
2014-04-18 11:23 ` Sebastian Hesselbarth
2014-04-18 11:45 ` Gregory CLEMENT
2014-04-18 11:45 ` Gregory CLEMENT
2014-04-18 11:45 ` Gregory CLEMENT
2014-04-18 10:22 ` [PATCH 6/8] ARM: mvebu: Add USB3 support for " Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` [PATCH 7/8] ARM: configs: Add usb_xhci_mvebu to mvebu_v7_defconfig Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` [PATCH 8/8] ARM: configs: Add usb_xhci_mvebu to multi_v7_defconfig Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140420031517.GA26893@saruman.home \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.