From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] ARM: mvebu: Add Device Tree description of xHCI hosts on Armada 38x
Date: Fri, 18 Apr 2014 13:45:08 +0200 [thread overview]
Message-ID: <53511044.9070601@free-electrons.com> (raw)
In-Reply-To: <53510B28.1070709@gmail.com>
Hi Sebastian,
On 18/04/2014 13:23, Sebastian Hesselbarth wrote:
> On 04/18/2014 12:22 PM, Gregory CLEMENT wrote:
>> The Marvell Armada 38x SoCs contain two xHCI host. This commit adds
>> the Device Tree description of those interfaces at the SoC level, and
>> also enables the two USB3 ports on the Armada 385 DB platform and one
>> USB3 port on the Armada 385 RD platforms.
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> ---
>> arch/arm/boot/dts/armada-385-db.dts | 8 ++++++++
>> arch/arm/boot/dts/armada-385-rd.dts | 4 ++++
>> arch/arm/boot/dts/armada-38x.dtsi | 17 +++++++++++++++++
>> 3 files changed, 29 insertions(+)
> [...]
>> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
>> index a064f59da02d..4f117e66aa1a 100644
>> --- a/arch/arm/boot/dts/armada-38x.dtsi
>> +++ b/arch/arm/boot/dts/armada-38x.dtsi
>> @@ -355,6 +355,23 @@
>> clocks = <&coredivclk 0>;
>> status = "disabled";
>> };
>> +
>> + usb3 at f0000 {
>> + compatible = "marvell,xhci-armada-380";
>> + reg = <0xf0000 0x3fff>,<0xf4000 0x3fff>;
>> + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&gateclk 9>;
>
> Using generic PHY framework will allow you to reference the PHY nodes
> with "usb-phy" here.
>
> BTW, you added a "marvell,armada-380-usb-utmi" in the patch for PHY init
> but I can see no corresponding node added.
Yes a commit was lost during one of my rebase!
Thanks to git reflog, I found it.
Thanks,
Gregory
>
> Sebastian
>
>> + status = "disabled";
>> + };
>> +
>> + usb3 at f8000 {
>> + compatible = "marvell,xhci-armada-380";
>> + reg = <0xf8000 0x3fff>,<0xfc000 0x3fff>;
>> + interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&gateclk 10>;
>> + status = "disabled";
>> + };
>> +
>> };
>> };
>>
>>
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Mathias Nyman
<mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Ezequiel Garcia
<ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Tawfik Bayouk <tawfik-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Nadav Haklai <nadavh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/8] ARM: mvebu: Add Device Tree description of xHCI hosts on Armada 38x
Date: Fri, 18 Apr 2014 13:45:08 +0200 [thread overview]
Message-ID: <53511044.9070601@free-electrons.com> (raw)
In-Reply-To: <53510B28.1070709-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi Sebastian,
On 18/04/2014 13:23, Sebastian Hesselbarth wrote:
> On 04/18/2014 12:22 PM, Gregory CLEMENT wrote:
>> The Marvell Armada 38x SoCs contain two xHCI host. This commit adds
>> the Device Tree description of those interfaces at the SoC level, and
>> also enables the two USB3 ports on the Armada 385 DB platform and one
>> USB3 port on the Armada 385 RD platforms.
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
>> ---
>> arch/arm/boot/dts/armada-385-db.dts | 8 ++++++++
>> arch/arm/boot/dts/armada-385-rd.dts | 4 ++++
>> arch/arm/boot/dts/armada-38x.dtsi | 17 +++++++++++++++++
>> 3 files changed, 29 insertions(+)
> [...]
>> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
>> index a064f59da02d..4f117e66aa1a 100644
>> --- a/arch/arm/boot/dts/armada-38x.dtsi
>> +++ b/arch/arm/boot/dts/armada-38x.dtsi
>> @@ -355,6 +355,23 @@
>> clocks = <&coredivclk 0>;
>> status = "disabled";
>> };
>> +
>> + usb3@f0000 {
>> + compatible = "marvell,xhci-armada-380";
>> + reg = <0xf0000 0x3fff>,<0xf4000 0x3fff>;
>> + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&gateclk 9>;
>
> Using generic PHY framework will allow you to reference the PHY nodes
> with "usb-phy" here.
>
> BTW, you added a "marvell,armada-380-usb-utmi" in the patch for PHY init
> but I can see no corresponding node added.
Yes a commit was lost during one of my rebase!
Thanks to git reflog, I found it.
Thanks,
Gregory
>
> Sebastian
>
>> + status = "disabled";
>> + };
>> +
>> + usb3@f8000 {
>> + compatible = "marvell,xhci-armada-380";
>> + reg = <0xf8000 0x3fff>,<0xfc000 0x3fff>;
>> + interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&gateclk 10>;
>> + status = "disabled";
>> + };
>> +
>> };
>> };
>>
>>
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 5/8] ARM: mvebu: Add Device Tree description of xHCI hosts on Armada 38x
Date: Fri, 18 Apr 2014 13:45:08 +0200 [thread overview]
Message-ID: <53511044.9070601@free-electrons.com> (raw)
In-Reply-To: <53510B28.1070709@gmail.com>
Hi Sebastian,
On 18/04/2014 13:23, Sebastian Hesselbarth wrote:
> On 04/18/2014 12:22 PM, Gregory CLEMENT wrote:
>> The Marvell Armada 38x SoCs contain two xHCI host. This commit adds
>> the Device Tree description of those interfaces at the SoC level, and
>> also enables the two USB3 ports on the Armada 385 DB platform and one
>> USB3 port on the Armada 385 RD platforms.
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> ---
>> arch/arm/boot/dts/armada-385-db.dts | 8 ++++++++
>> arch/arm/boot/dts/armada-385-rd.dts | 4 ++++
>> arch/arm/boot/dts/armada-38x.dtsi | 17 +++++++++++++++++
>> 3 files changed, 29 insertions(+)
> [...]
>> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
>> index a064f59da02d..4f117e66aa1a 100644
>> --- a/arch/arm/boot/dts/armada-38x.dtsi
>> +++ b/arch/arm/boot/dts/armada-38x.dtsi
>> @@ -355,6 +355,23 @@
>> clocks = <&coredivclk 0>;
>> status = "disabled";
>> };
>> +
>> + usb3@f0000 {
>> + compatible = "marvell,xhci-armada-380";
>> + reg = <0xf0000 0x3fff>,<0xf4000 0x3fff>;
>> + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&gateclk 9>;
>
> Using generic PHY framework will allow you to reference the PHY nodes
> with "usb-phy" here.
>
> BTW, you added a "marvell,armada-380-usb-utmi" in the patch for PHY init
> but I can see no corresponding node added.
Yes a commit was lost during one of my rebase!
Thanks to git reflog, I found it.
Thanks,
Gregory
>
> Sebastian
>
>> + status = "disabled";
>> + };
>> +
>> + usb3@f8000 {
>> + compatible = "marvell,xhci-armada-380";
>> + reg = <0xf8000 0x3fff>,<0xfc000 0x3fff>;
>> + interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&gateclk 10>;
>> + status = "disabled";
>> + };
>> +
>> };
>> };
>>
>>
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2014-04-18 11:45 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 10:22 [PATCH 0/8] USB3 support for Armada 38x Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` [PATCH 1/8] usb: host: xhci-plat: Allow to register glue code using the device tree Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-20 3:15 ` Felipe Balbi
2014-04-20 3:15 ` Felipe Balbi
2014-04-20 3:15 ` Felipe Balbi
2014-04-18 10:22 ` [PATCH 2/8] usb: host: xhci-plat: Add support for the Armada 38x glue code Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 11:13 ` Sebastian Hesselbarth
2014-04-18 11:13 ` Sebastian Hesselbarth
2014-04-18 11:13 ` Sebastian Hesselbarth
2014-04-18 11:43 ` Gregory CLEMENT
2014-04-18 11:43 ` Gregory CLEMENT
2014-04-18 11:47 ` Sebastian Hesselbarth
2014-04-18 11:47 ` Sebastian Hesselbarth
2014-04-18 11:47 ` Sebastian Hesselbarth
2014-04-20 3:20 ` Felipe Balbi
2014-04-20 3:20 ` Felipe Balbi
2014-04-20 3:20 ` Felipe Balbi
2014-04-23 7:44 ` Gregory CLEMENT
2014-04-23 7:44 ` Gregory CLEMENT
2014-04-23 7:44 ` Gregory CLEMENT
2014-04-23 15:22 ` Felipe Balbi
2014-04-23 15:22 ` Felipe Balbi
2014-04-23 15:22 ` Felipe Balbi
2014-04-18 10:22 ` [PATCH 3/8] xhci-platform: Add a new controller using xhci: Armada 38x Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-20 3:21 ` Felipe Balbi
2014-04-20 3:21 ` Felipe Balbi
2014-04-20 3:21 ` Felipe Balbi
2014-04-18 10:22 ` [PATCH 4/8] ARM: mvebu: Add USB3 UTMI support Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 11:19 ` Sebastian Hesselbarth
2014-04-18 11:19 ` Sebastian Hesselbarth
2014-04-18 11:19 ` Sebastian Hesselbarth
2014-04-18 12:19 ` Gregory CLEMENT
2014-04-18 12:19 ` Gregory CLEMENT
2014-04-18 12:19 ` Gregory CLEMENT
2014-04-20 3:22 ` Felipe Balbi
2014-04-20 3:22 ` Felipe Balbi
2014-04-20 3:22 ` Felipe Balbi
2014-04-18 10:22 ` [PATCH 5/8] ARM: mvebu: Add Device Tree description of xHCI hosts on Armada 38x Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 11:23 ` Sebastian Hesselbarth
2014-04-18 11:23 ` Sebastian Hesselbarth
2014-04-18 11:23 ` Sebastian Hesselbarth
2014-04-18 11:45 ` Gregory CLEMENT [this message]
2014-04-18 11:45 ` Gregory CLEMENT
2014-04-18 11:45 ` Gregory CLEMENT
2014-04-18 10:22 ` [PATCH 6/8] ARM: mvebu: Add USB3 support for " Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` [PATCH 7/8] ARM: configs: Add usb_xhci_mvebu to mvebu_v7_defconfig Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` [PATCH 8/8] ARM: configs: Add usb_xhci_mvebu to multi_v7_defconfig Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
2014-04-18 10:22 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53511044.9070601@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.