Re: [PATCH 2/2] xfs: Nuke XFS_ERROR macro

From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Eric Sandeen <sandeen@sandeen.net>,
	Steven Rostedt <rostedt@goodmis.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/2] xfs: Nuke XFS_ERROR macro
Date: Sun, 20 Apr 2014 23:57:46 -0700	[thread overview]
Message-ID: <20140421065746.GA20384@infradead.org> (raw)
In-Reply-To: <20140417003956.GS15995@dastard>

On Thu, Apr 17, 2014 at 10:39:56AM +1000, Dave Chinner wrote:
> so, basically a script that does:
> 
> #!/bin/bash
> 
> TRACEDIR=/sys/kernel/debug/tracing
> 
> grep -i 't xfs_' /proc/kallsyms | awk '{print $3}' ; while read F; do
> 	echo "r:ret_$F $F \$retval" >> $TRACEDIR/kprobe_events
> done
> 
> for E in $TRACEDIR/events/kprobes/ret_xfs_*/enable; do
> 	echo 1 > $E
> done;
> 
> echo 'arg1 > 0xffffffffffffff00' > $TRACEDIR/events/kprobes/filter
> 
> for T in $TRACEDIR/events/kprobes/ret_xfs_*/trigger; do
> 	echo 'traceoff if arg1 > 0xffffffffffffff00' > $T
> done

This looks incredibly useful!  Can we throw this into Documentation/ as
a helper script (and make the xfs a command line parameter so it's
genericly useful)?

One think that would be nice is to specify a module instead of relying
on a clean namespace, but to replace the XFS functionality the one above
is more than enough.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs