From: Tony Lindgren <tony@atomide.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux-OMAP <linux-omap@vger.kernel.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>
Subject: Re: [PATCH 11/11] pinctrl: single: Clear pin interrupts enabled by bootloader
Date: Tue, 22 Apr 2014 09:10:33 -0700 [thread overview]
Message-ID: <20140422161033.GC19317@atomide.com> (raw)
In-Reply-To: <CACRpkdYu2Obo8kuA2D9a33K_KCF-LPza=+reEpFnq8JFK6jOCg@mail.gmail.com>
* Linus Walleij <linus.walleij@linaro.org> [140422 04:55]:
> On Fri, Apr 11, 2014 at 1:47 AM, Tony Lindgren <tony@atomide.com> wrote:
>
> > Since we set up device wake-up interrupts as pinctrl-single
> > interrupts, we now must use the standard request_irq and
> > related functions to manage them.
> >
> > If the pin interrupts are enabled for some pins at boot,
> > the wake-up events can show up as constantly pending
> > at least on omaps and will hang the system unless the related
> > device driver clears the event at the device.
> >
> > To fix this, let's clear the interrupt flags during init,
> > and print out a warning so the board maintainers can update
> > their drivers to do proper request_irq for the driver specific
> > wake-up events.
> >
> > Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> Looks clean.
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Shall I apply this patch or will you funnel it through ARM SoC
> due to deps?
No deps except boards hanging without it.. Please feel free to
take this one, prererrably as a fix for the -rc series if no
objections.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/11] pinctrl: single: Clear pin interrupts enabled by bootloader
Date: Tue, 22 Apr 2014 09:10:33 -0700 [thread overview]
Message-ID: <20140422161033.GC19317@atomide.com> (raw)
In-Reply-To: <CACRpkdYu2Obo8kuA2D9a33K_KCF-LPza=+reEpFnq8JFK6jOCg@mail.gmail.com>
* Linus Walleij <linus.walleij@linaro.org> [140422 04:55]:
> On Fri, Apr 11, 2014 at 1:47 AM, Tony Lindgren <tony@atomide.com> wrote:
>
> > Since we set up device wake-up interrupts as pinctrl-single
> > interrupts, we now must use the standard request_irq and
> > related functions to manage them.
> >
> > If the pin interrupts are enabled for some pins at boot,
> > the wake-up events can show up as constantly pending
> > at least on omaps and will hang the system unless the related
> > device driver clears the event at the device.
> >
> > To fix this, let's clear the interrupt flags during init,
> > and print out a warning so the board maintainers can update
> > their drivers to do proper request_irq for the driver specific
> > wake-up events.
> >
> > Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> Looks clean.
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Shall I apply this patch or will you funnel it through ARM SoC
> due to deps?
No deps except boards hanging without it.. Please feel free to
take this one, prererrably as a fix for the -rc series if no
objections.
Regards,
Tony
next prev parent reply other threads:[~2014-04-22 16:10 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 23:47 [PATCH 00/11] Fixes for omap PM for making omap3 DT only Tony Lindgren
2014-04-10 23:47 ` Tony Lindgren
2014-04-10 23:47 ` [PATCH 01/11] ARM: OMAP3: PM: remove access to PRM_VOLTCTRL register Tony Lindgren
2014-04-10 23:47 ` Tony Lindgren
2014-04-10 23:47 ` [PATCH 02/11] ARM: OMAP3: Fix idle mode signaling for sys_clkreq and sys_off_mode Tony Lindgren
2014-04-10 23:47 ` Tony Lindgren
2014-04-12 8:57 ` Tero Kristo
2014-04-12 8:57 ` Tero Kristo
2014-04-12 15:02 ` Tony Lindgren
2014-04-12 15:02 ` Tony Lindgren
2014-04-23 7:51 ` Tero Kristo
2014-04-23 7:51 ` Tero Kristo
2014-04-23 20:49 ` Tony Lindgren
2014-04-23 20:49 ` Tony Lindgren
2014-05-07 16:34 ` Tony Lindgren
2014-05-07 16:34 ` Tony Lindgren
2014-04-14 22:51 ` Grazvydas Ignotas
2014-04-14 22:51 ` Grazvydas Ignotas
2014-04-15 22:56 ` Tony Lindgren
2014-04-15 22:56 ` Tony Lindgren
2014-04-16 13:58 ` Grazvydas Ignotas
2014-04-16 13:58 ` Grazvydas Ignotas
2014-04-18 17:48 ` Tony Lindgren
2014-04-18 17:48 ` Tony Lindgren
2014-04-10 23:47 ` [PATCH 03/11] ARM: OMAP3: Disable broken omap3_set_off_timings function Tony Lindgren
2014-04-10 23:47 ` Tony Lindgren
2014-04-10 23:47 ` [PATCH 04/11] ARM: OMAP3: Fix voltage control for deeper idle states Tony Lindgren
2014-04-10 23:47 ` Tony Lindgren
2014-04-11 15:14 ` Tony Lindgren
2014-04-11 15:14 ` Tony Lindgren
2014-05-07 16:38 ` Tony Lindgren
2014-05-07 16:38 ` Tony Lindgren
2014-04-10 23:47 ` [PATCH 05/11] ARM: dts: Configure omap3 twl4030 I2C4 pins by default Tony Lindgren
2014-04-10 23:47 ` Tony Lindgren
2014-04-10 23:47 ` [PATCH 06/11] ARM: OMAP2+: Fix voltage scaling init for device tree Tony Lindgren
2014-04-10 23:47 ` Tony Lindgren
2014-05-19 17:50 ` Joachim Eastwood
2014-05-19 17:50 ` Joachim Eastwood
2014-05-19 18:01 ` Tony Lindgren
2014-05-19 18:01 ` Tony Lindgren
2014-05-19 18:32 ` Nishanth Menon
2014-05-19 18:32 ` Nishanth Menon
2014-05-19 18:48 ` Joachim Eastwood
2014-05-19 18:48 ` Joachim Eastwood
2014-05-19 18:52 ` Nishanth Menon
2014-05-19 18:52 ` Nishanth Menon
2014-05-19 20:23 ` Tony Lindgren
2014-05-19 20:23 ` Tony Lindgren
2014-04-10 23:47 ` [PATCH 07/11] ARM: dts: Enable N900 keybaord sleep leds by default Tony Lindgren
2014-04-10 23:47 ` Tony Lindgren
2014-04-11 0:23 ` Tony Lindgren
2014-04-11 0:23 ` Tony Lindgren
2014-04-11 23:31 ` Aaro Koskinen
2014-04-11 23:31 ` Aaro Koskinen
2014-04-23 21:07 ` Tony Lindgren
2014-04-23 21:07 ` Tony Lindgren
2014-04-10 23:47 ` [PATCH 08/11] ARM: dts: Fix omap serial wake-up when booted with device tree Tony Lindgren
2014-04-10 23:47 ` Tony Lindgren
2014-04-10 23:47 ` [PATCH 09/11] ARM: OMAP2+: Enable CPUidle in omap2plus_defconfig Tony Lindgren
2014-04-10 23:47 ` Tony Lindgren
2014-04-10 23:47 ` [PATCH 10/11] mfd: twl-core: Fix idle mode signaling for omaps when booted with device tree Tony Lindgren
2014-04-10 23:47 ` Tony Lindgren
2014-04-17 8:00 ` Lee Jones
2014-04-17 8:00 ` Lee Jones
2014-04-17 15:37 ` Tony Lindgren
2014-04-17 15:37 ` Tony Lindgren
2014-04-23 14:46 ` [GIT PULL] arm: omap: Immutable branch between MFD and ARM OMAP due for the v3.16 merge-window Lee Jones
2014-04-23 14:46 ` Lee Jones
2014-04-23 20:41 ` Tony Lindgren
2014-04-23 20:41 ` Tony Lindgren
2014-04-10 23:47 ` [PATCH 11/11] pinctrl: single: Clear pin interrupts enabled by bootloader Tony Lindgren
2014-04-10 23:47 ` Tony Lindgren
2014-04-22 11:54 ` Linus Walleij
2014-04-22 11:54 ` Linus Walleij
2014-04-22 16:10 ` Tony Lindgren [this message]
2014-04-22 16:10 ` Tony Lindgren
2014-04-23 13:57 ` Linus Walleij
2014-04-23 13:57 ` Linus Walleij
2014-04-11 20:47 ` [PATCH 00/11] Fixes for omap PM for making omap3 DT only Sebastian Reichel
2014-04-11 20:47 ` Sebastian Reichel
2014-04-11 21:04 ` Tony Lindgren
2014-04-11 21:04 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422161033.GC19317@atomide.com \
--to=tony@atomide.com \
--cc=haojian.zhuang@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.