From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org,
sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 3/7] mfd: cros_ec: spi: Make the cros_ec_spi timeout more reliable
Date: Wed, 23 Apr 2014 13:35:10 +0100 [thread overview]
Message-ID: <20140423123510.GD640@lee--X1> (raw)
In-Reply-To: <1398185154-19404-4-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
On Tue, 22 Apr 2014, Doug Anderson wrote:
> The cros_ec_spi transfer had two problems with its timeout code:
>
> 1. It looked at the timeout even in the case that it found valid data.
> 2. If the cros_ec_spi code got switched out for a while, it's possible
> it could get a timeout after a single loop. Let's be paranoid and
> make sure we do one last transfer after the timeout expires.
>
> Signed-off-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Reviewed-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Tested-by: Andrew Bresticker <abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Tested-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> Changes in v2: None
>
> drivers/mfd/cros_ec_spi.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
Waiting for other subsystems to Ack, so for now:
Acked-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: swarren@nvidia.com, wsa@the-dreams.de, abrestic@chromium.org,
dgreid@chromium.org, olof@lixom.net, sjg@chromium.org,
linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
sameo@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] mfd: cros_ec: spi: Make the cros_ec_spi timeout more reliable
Date: Wed, 23 Apr 2014 13:35:10 +0100 [thread overview]
Message-ID: <20140423123510.GD640@lee--X1> (raw)
In-Reply-To: <1398185154-19404-4-git-send-email-dianders@chromium.org>
On Tue, 22 Apr 2014, Doug Anderson wrote:
> The cros_ec_spi transfer had two problems with its timeout code:
>
> 1. It looked at the timeout even in the case that it found valid data.
> 2. If the cros_ec_spi code got switched out for a while, it's possible
> it could get a timeout after a single loop. Let's be paranoid and
> make sure we do one last transfer after the timeout expires.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Tested-by: Andrew Bresticker <abrestic@chromium.org>
> Tested-by: Stephen Warren <swarren@nvidia.com>
> ---
> Changes in v2: None
>
> drivers/mfd/cros_ec_spi.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
Waiting for other subsystems to Ack, so for now:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-04-23 12:35 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 16:45 [PATCH v2 0/7] Add cros_ec changes for newer boards Doug Anderson
2014-04-22 16:45 ` Doug Anderson
2014-04-22 16:45 ` Doug Anderson
[not found] ` <1398185154-19404-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-04-22 16:45 ` [PATCH v2 1/7] mfd: cros_ec: spi: calculate delay between transfers correctly Doug Anderson
2014-04-22 16:45 ` Doug Anderson
2014-04-23 12:33 ` Lee Jones
2014-04-22 16:45 ` [PATCH v2 4/7] mfd: cros_ec: spi: Increase cros_ec_spi deadline from 5ms to 100ms Doug Anderson
2014-04-22 16:45 ` Doug Anderson
2014-04-23 12:36 ` Lee Jones
2014-04-22 16:45 ` [PATCH v2 6/7] i2c: ChromeOS EC tunnel driver Doug Anderson
2014-04-22 16:45 ` Doug Anderson
2014-04-23 12:37 ` Lee Jones
2014-04-23 16:37 ` Doug Anderson
[not found] ` <1398185154-19404-7-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-04-29 12:33 ` Wolfram Sang
2014-04-29 12:33 ` Wolfram Sang
2014-04-30 17:44 ` Doug Anderson
2014-04-22 16:45 ` [PATCH v2 2/7] mfd: cros_ec: spi: Add mutex to cros_ec_spi Doug Anderson
2014-04-23 12:34 ` Lee Jones
2014-04-22 16:45 ` [PATCH v2 3/7] mfd: cros_ec: spi: Make the cros_ec_spi timeout more reliable Doug Anderson
[not found] ` <1398185154-19404-4-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-04-23 12:35 ` Lee Jones [this message]
2014-04-23 12:35 ` Lee Jones
2014-04-22 16:45 ` [PATCH v2 5/7] mfd: cros_ec: Sync to the latest cros_ec_commands.h from EC sources Doug Anderson
2014-04-23 12:36 ` Lee Jones
2014-04-22 16:45 ` [PATCH v2 7/7] ARM: tegra: Add the EC i2c tunnel to tegra124-venice2 Doug Anderson
2014-04-22 16:45 ` Doug Anderson
2014-04-22 16:45 ` Doug Anderson
2014-04-23 12:32 ` [PATCH v2 0/7] Add cros_ec changes for newer boards Lee Jones
2014-04-23 12:32 ` Lee Jones
2014-04-23 12:32 ` Lee Jones
2014-04-23 16:20 ` Stephen Warren
2014-04-23 16:20 ` Stephen Warren
2014-04-23 16:20 ` Stephen Warren
2014-04-23 16:32 ` Doug Anderson
2014-04-23 16:32 ` Doug Anderson
2014-04-23 16:35 ` Doug Anderson
2014-04-23 16:35 ` Doug Anderson
2014-04-28 9:19 ` Lee Jones
2014-04-28 9:19 ` Lee Jones
2014-04-28 21:18 ` Doug Anderson
2014-04-28 21:18 ` Doug Anderson
2014-04-29 8:21 ` Lee Jones
2014-04-29 8:21 ` Lee Jones
2014-04-29 16:51 ` Doug Anderson
2014-04-29 16:51 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423123510.GD640@lee--X1 \
--to=lee.jones-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.