From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH 2/6] i2c: sh_mobile: improve error handling
Date: Fri, 2 May 2014 09:19:31 +0200 [thread overview]
Message-ID: <20140502071931.GA2647@katana> (raw)
In-Reply-To: <CAMuHMdWs=FkAgCpBNQcaRtJRanGQjp1erN+=Jqpekioj+9pk1A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
On Thu, May 01, 2014 at 12:25:38AM +0200, Geert Uytterhoeven wrote:
> Hi Wolfram,
>
> On Thu, May 1, 2014 at 12:21 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > Use standard i2c error codes for i2c failures. Also, don't print
> > something on timeout since it happens regularly with i2c. Simplify some,
> > logic, too.
>
> You may want to keep the timeout messages with dev_dbg()?
Not really. We now have an I2C tracer which shows the return value of
the transfer. I really want to reduce debug output of all drivers in
favor of the tracer.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH 2/6] i2c: sh_mobile: improve error handling
Date: Fri, 02 May 2014 07:19:31 +0000 [thread overview]
Message-ID: <20140502071931.GA2647@katana> (raw)
In-Reply-To: <CAMuHMdWs=FkAgCpBNQcaRtJRanGQjp1erN+=Jqpekioj+9pk1A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
On Thu, May 01, 2014 at 12:25:38AM +0200, Geert Uytterhoeven wrote:
> Hi Wolfram,
>
> On Thu, May 1, 2014 at 12:21 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > Use standard i2c error codes for i2c failures. Also, don't print
> > something on timeout since it happens regularly with i2c. Simplify some,
> > logic, too.
>
> You may want to keep the timeout messages with dev_dbg()?
Not really. We now have an I2C tracer which shows the return value of
the transfer. I really want to reduce debug output of all drivers in
favor of the tracer.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-02 7:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 22:21 [PATCH 0/6] i2c: sh_mobile: cleanups Wolfram Sang
2014-04-30 22:21 ` Wolfram Sang
2014-04-30 22:21 ` [PATCH 1/6] i2c: sh_mobile: replace magic hex values with constants Wolfram Sang
2014-04-30 22:21 ` Wolfram Sang
2014-04-30 22:21 ` [PATCH 2/6] i2c: sh_mobile: improve error handling Wolfram Sang
2014-04-30 22:21 ` Wolfram Sang
[not found] ` <1398896470-24663-3-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-04-30 22:25 ` Geert Uytterhoeven
2014-04-30 22:25 ` Geert Uytterhoeven
2014-05-02 7:19 ` Wolfram Sang [this message]
2014-05-02 7:19 ` Wolfram Sang
2014-04-30 22:21 ` [PATCH 3/6] i2c: sh_mobile: honor DT bus speed settings Wolfram Sang
2014-04-30 22:21 ` Wolfram Sang
2014-04-30 22:21 ` [PATCH 5/6] i2c: sh_mobile: devm conversion, low hanging fruits Wolfram Sang
2014-04-30 22:21 ` Wolfram Sang
2014-04-30 22:39 ` Geert Uytterhoeven
2014-04-30 22:39 ` Geert Uytterhoeven
[not found] ` <1398896470-24663-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-04-30 22:21 ` [PATCH 4/6] i2c: sh_mobile: add devicetree documentation Wolfram Sang
2014-04-30 22:21 ` Wolfram Sang
2014-04-30 22:32 ` Geert Uytterhoeven
2014-04-30 22:32 ` Geert Uytterhoeven
2014-05-01 1:02 ` Rob Herring
2014-05-01 1:02 ` Rob Herring
2014-05-02 7:23 ` Wolfram Sang
2014-05-02 7:23 ` Wolfram Sang
2014-04-30 22:21 ` [PATCH 6/6] i2c: sh_mobile: devm conversion, irq setup Wolfram Sang
2014-04-30 22:21 ` Wolfram Sang
2014-04-30 22:44 ` Geert Uytterhoeven
2014-04-30 22:44 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502071931.GA2647@katana \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.