From: Vinod Koul <vinod.koul@intel.com>
To: hongbo.zhang@freescale.com
Cc: leo.li@freescale.com, vkoul@infradead.org,
linux-kernel@vger.kernel.org, scottwood@freescale.com,
dmaengine@vger.kernel.org, dan.j.williams@intel.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 2/8] DMA: Freescale: unify register access methods
Date: Fri, 2 May 2014 22:18:47 +0530 [thread overview]
Message-ID: <20140502164847.GD32284@intel.com> (raw)
In-Reply-To: <1397809071-5353-3-git-send-email-hongbo.zhang@freescale.com>
On Fri, Apr 18, 2014 at 04:17:45PM +0800, hongbo.zhang@freescale.com wrote:
> From: Hongbo Zhang <hongbo.zhang@freescale.com>
>
> Methods of accessing DMA controller registers are inconsistent, some registers
> are accessed by DMA_IN/OUT directly, while others are accessed by functions
> get/set_* which are wrappers of DMA_IN/OUT, and even for the BCR register, it
> is read by get_bcr but written by DMA_OUT.
> This patch unifies the inconsistent methods, all registers are accessed by
> get/set_* now.
>
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: hongbo.zhang@freescale.com
Cc: vkoul@infradead.org, dan.j.williams@intel.com,
dmaengine@vger.kernel.org, scottwood@freescale.com,
leo.li@freescale.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/8] DMA: Freescale: unify register access methods
Date: Fri, 2 May 2014 22:18:47 +0530 [thread overview]
Message-ID: <20140502164847.GD32284@intel.com> (raw)
In-Reply-To: <1397809071-5353-3-git-send-email-hongbo.zhang@freescale.com>
On Fri, Apr 18, 2014 at 04:17:45PM +0800, hongbo.zhang@freescale.com wrote:
> From: Hongbo Zhang <hongbo.zhang@freescale.com>
>
> Methods of accessing DMA controller registers are inconsistent, some registers
> are accessed by DMA_IN/OUT directly, while others are accessed by functions
> get/set_* which are wrappers of DMA_IN/OUT, and even for the BCR register, it
> is read by get_bcr but written by DMA_OUT.
> This patch unifies the inconsistent methods, all registers are accessed by
> get/set_* now.
>
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2014-05-02 17:03 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 8:17 [PATCH v4 0/8] DMA: Freescale: driver cleanups and enhancements hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-04-18 8:17 ` [PATCH v4 1/8] DMA: Freescale: remove the unnecessary FSL_DMA_LD_DEBUG hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:48 ` Vinod Koul
2014-05-02 16:48 ` Vinod Koul
2014-04-18 8:17 ` [PATCH v4 2/8] DMA: Freescale: unify register access methods hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:48 ` Vinod Koul [this message]
2014-05-02 16:48 ` Vinod Koul
2014-04-18 8:17 ` [PATCH v4 3/8] DMA: Freescale: remove attribute DMA_INTERRUPT of dmaengine hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:49 ` Vinod Koul
2014-05-02 16:49 ` Vinod Koul
2014-04-18 8:17 ` [PATCH v4 4/8] DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:49 ` Vinod Koul
2014-05-02 16:49 ` Vinod Koul
2014-04-18 8:17 ` [PATCH v4 5/8] DMA: Freescale: move functions to avoid forward declarations hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:50 ` Vinod Koul
2014-05-02 16:50 ` Vinod Koul
2014-04-18 8:17 ` [PATCH v4 6/8] DMA: Freescale: change descriptor release process for supporting async_tx hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:50 ` Vinod Koul
2014-05-02 16:50 ` Vinod Koul
2014-05-08 10:03 ` Hongbo Zhang
2014-05-08 10:03 ` Hongbo Zhang
2014-04-18 8:17 ` [PATCH v4 7/8] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:51 ` Vinod Koul
2014-05-02 16:51 ` Vinod Koul
2014-05-04 8:40 ` Hongbo Zhang
2014-05-04 8:40 ` Hongbo Zhang
2014-04-18 8:17 ` [PATCH v4 8/8] DMA: Freescale: add suspend resume functions for DMA driver hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:46 ` Vinod Koul
2014-05-02 16:46 ` Vinod Koul
2014-05-04 10:22 ` Hongbo Zhang
2014-05-04 10:22 ` Hongbo Zhang
2014-05-07 8:31 ` Shevchenko, Andriy
2014-05-07 8:31 ` Shevchenko, Andriy
2014-05-08 9:52 ` Hongbo Zhang
2014-05-08 9:52 ` Hongbo Zhang
2014-05-21 3:45 ` Vinod Koul
2014-05-21 3:45 ` Vinod Koul
2014-05-21 6:42 ` Hongbo Zhang
2014-05-21 6:42 ` Hongbo Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502164847.GD32284@intel.com \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=hongbo.zhang@freescale.com \
--cc=leo.li@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
--cc=vkoul@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.