From: Hongbo Zhang <hongbo.zhang@freescale.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: leo.li@freescale.com, vkoul@infradead.org,
linux-kernel@vger.kernel.org, scottwood@freescale.com,
dmaengine@vger.kernel.org, dan.j.williams@intel.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 7/8] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave
Date: Sun, 4 May 2014 16:40:18 +0800 [thread overview]
Message-ID: <5365FCF2.9090008@freescale.com> (raw)
In-Reply-To: <20140502165143.GI32284@intel.com>
On 05/03/2014 12:51 AM, Vinod Koul wrote:
> On Fri, Apr 18, 2014 at 04:17:50PM +0800, hongbo.zhang@freescale.com wrote:
>> From: Hongbo Zhang <hongbo.zhang@freescale.com>
>>
>> The usage of spin_lock_irqsave() is a stronger locking mechanism than is
>> required throughout the driver. The minimum locking required should be used
>> instead. Interrupts will be turned off and context will be saved, it is
>> unnecessary to use irqsave.
>>
>> This patch changes all instances of spin_lock_irqsave() to spin_lock_bh(). All
>> manipulation of protected fields is done using tasklet context or weaker, which
>> makes spin_lock_bh() the correct choice.
>>
> This doesnt apply, perhpas due to depends on 6/8
>
So let's wait for the review result of 6/8.
WARNING: multiple messages have this Message-ID (diff)
From: Hongbo Zhang <hongbo.zhang@freescale.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: <vkoul@infradead.org>, <dan.j.williams@intel.com>,
<dmaengine@vger.kernel.org>, <scottwood@freescale.com>,
<leo.li@freescale.com>, <linuxppc-dev@lists.ozlabs.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 7/8] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave
Date: Sun, 4 May 2014 16:40:18 +0800 [thread overview]
Message-ID: <5365FCF2.9090008@freescale.com> (raw)
In-Reply-To: <20140502165143.GI32284@intel.com>
On 05/03/2014 12:51 AM, Vinod Koul wrote:
> On Fri, Apr 18, 2014 at 04:17:50PM +0800, hongbo.zhang@freescale.com wrote:
>> From: Hongbo Zhang <hongbo.zhang@freescale.com>
>>
>> The usage of spin_lock_irqsave() is a stronger locking mechanism than is
>> required throughout the driver. The minimum locking required should be used
>> instead. Interrupts will be turned off and context will be saved, it is
>> unnecessary to use irqsave.
>>
>> This patch changes all instances of spin_lock_irqsave() to spin_lock_bh(). All
>> manipulation of protected fields is done using tasklet context or weaker, which
>> makes spin_lock_bh() the correct choice.
>>
> This doesnt apply, perhpas due to depends on 6/8
>
So let's wait for the review result of 6/8.
next prev parent reply other threads:[~2014-05-04 8:55 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 8:17 [PATCH v4 0/8] DMA: Freescale: driver cleanups and enhancements hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-04-18 8:17 ` [PATCH v4 1/8] DMA: Freescale: remove the unnecessary FSL_DMA_LD_DEBUG hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:48 ` Vinod Koul
2014-05-02 16:48 ` Vinod Koul
2014-04-18 8:17 ` [PATCH v4 2/8] DMA: Freescale: unify register access methods hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:48 ` Vinod Koul
2014-05-02 16:48 ` Vinod Koul
2014-04-18 8:17 ` [PATCH v4 3/8] DMA: Freescale: remove attribute DMA_INTERRUPT of dmaengine hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:49 ` Vinod Koul
2014-05-02 16:49 ` Vinod Koul
2014-04-18 8:17 ` [PATCH v4 4/8] DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:49 ` Vinod Koul
2014-05-02 16:49 ` Vinod Koul
2014-04-18 8:17 ` [PATCH v4 5/8] DMA: Freescale: move functions to avoid forward declarations hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:50 ` Vinod Koul
2014-05-02 16:50 ` Vinod Koul
2014-04-18 8:17 ` [PATCH v4 6/8] DMA: Freescale: change descriptor release process for supporting async_tx hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:50 ` Vinod Koul
2014-05-02 16:50 ` Vinod Koul
2014-05-08 10:03 ` Hongbo Zhang
2014-05-08 10:03 ` Hongbo Zhang
2014-04-18 8:17 ` [PATCH v4 7/8] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:51 ` Vinod Koul
2014-05-02 16:51 ` Vinod Koul
2014-05-04 8:40 ` Hongbo Zhang [this message]
2014-05-04 8:40 ` Hongbo Zhang
2014-04-18 8:17 ` [PATCH v4 8/8] DMA: Freescale: add suspend resume functions for DMA driver hongbo.zhang
2014-04-18 8:17 ` hongbo.zhang
2014-05-02 16:46 ` Vinod Koul
2014-05-02 16:46 ` Vinod Koul
2014-05-04 10:22 ` Hongbo Zhang
2014-05-04 10:22 ` Hongbo Zhang
2014-05-07 8:31 ` Shevchenko, Andriy
2014-05-07 8:31 ` Shevchenko, Andriy
2014-05-08 9:52 ` Hongbo Zhang
2014-05-08 9:52 ` Hongbo Zhang
2014-05-21 3:45 ` Vinod Koul
2014-05-21 3:45 ` Vinod Koul
2014-05-21 6:42 ` Hongbo Zhang
2014-05-21 6:42 ` Hongbo Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5365FCF2.9090008@freescale.com \
--to=hongbo.zhang@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=leo.li@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
--cc=vinod.koul@intel.com \
--cc=vkoul@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.