* [linuxtv-samsung:for-v3.16 45/81] drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here?
@ 2014-05-05 19:02 Dan Carpenter
2014-05-05 20:52 ` Antti Palosaari
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2014-05-05 19:02 UTC (permalink / raw)
To: kbuild, Antti Palosaari; +Cc: Mauro Carvalho Chehab, linux-media
tree: git://linuxtv.org/snawrocki/samsung.git for-v3.16
head: 13b46c7a03adbcc347b77a13ed27066bc92d515c
commit: 192292403147877c7d5f737a3cc751ded397aef7 [45/81] [media] em28xx: add [2013:025f] PCTV tripleStick (292e)
drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here?
drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: maybe use && instead of &
drivers/media/tuners/si2157.c:44 si2157_cmd_execute() warn: add some parenthesis here?
drivers/media/tuners/si2157.c:44 si2157_cmd_execute() warn: maybe use && instead of &
git remote add linuxtv-samsung git://linuxtv.org/snawrocki/samsung.git
git remote update linuxtv-samsung
git checkout 192292403147877c7d5f737a3cc751ded397aef7
vim +47 drivers/media/dvb-frontends/si2168.c
845f3505 Antti Palosaari 2014-04-10 31 goto err_mutex_unlock;
845f3505 Antti Palosaari 2014-04-10 32 } else if (ret != cmd->rlen) {
845f3505 Antti Palosaari 2014-04-10 33 ret = -EREMOTEIO;
845f3505 Antti Palosaari 2014-04-10 34 goto err_mutex_unlock;
845f3505 Antti Palosaari 2014-04-10 35 }
845f3505 Antti Palosaari 2014-04-10 36
845f3505 Antti Palosaari 2014-04-10 37 /* firmware ready? */
845f3505 Antti Palosaari 2014-04-10 38 if ((cmd->args[0] >> 7) & 0x01)
845f3505 Antti Palosaari 2014-04-10 39 break;
845f3505 Antti Palosaari 2014-04-10 40 }
845f3505 Antti Palosaari 2014-04-10 41
845f3505 Antti Palosaari 2014-04-10 42 dev_dbg(&s->client->dev, "%s: cmd execution took %d ms\n",
845f3505 Antti Palosaari 2014-04-10 43 __func__,
845f3505 Antti Palosaari 2014-04-10 44 jiffies_to_msecs(jiffies) -
845f3505 Antti Palosaari 2014-04-10 45 (jiffies_to_msecs(timeout) - TIMEOUT));
845f3505 Antti Palosaari 2014-04-10 46
845f3505 Antti Palosaari 2014-04-10 @47 if (!(cmd->args[0] >> 7) & 0x01) {
This should be: if (!((md->args[0] >> 7) & 0x01)) {
Otherwise it is a precedence error where it does the negate before the
bitwise AND.
845f3505 Antti Palosaari 2014-04-10 48 ret = -ETIMEDOUT;
845f3505 Antti Palosaari 2014-04-10 49 goto err_mutex_unlock;
845f3505 Antti Palosaari 2014-04-10 50 }
845f3505 Antti Palosaari 2014-04-10 51 }
845f3505 Antti Palosaari 2014-04-10 52
845f3505 Antti Palosaari 2014-04-10 53 ret = 0;
845f3505 Antti Palosaari 2014-04-10 54
845f3505 Antti Palosaari 2014-04-10 55 err_mutex_unlock:
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [linuxtv-samsung:for-v3.16 45/81] drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here?
2014-05-05 19:02 [linuxtv-samsung:for-v3.16 45/81] drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here? Dan Carpenter
@ 2014-05-05 20:52 ` Antti Palosaari
2014-05-20 12:01 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Antti Palosaari @ 2014-05-05 20:52 UTC (permalink / raw)
To: Dan Carpenter, kbuild; +Cc: Mauro Carvalho Chehab, linux-media
On 05.05.2014 22:02, Dan Carpenter wrote:
>
> tree: git://linuxtv.org/snawrocki/samsung.git for-v3.16
> head: 13b46c7a03adbcc347b77a13ed27066bc92d515c
> commit: 192292403147877c7d5f737a3cc751ded397aef7 [45/81] [media] em28xx: add [2013:025f] PCTV tripleStick (292e)
>
> drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here?
> drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: maybe use && instead of &
> drivers/media/tuners/si2157.c:44 si2157_cmd_execute() warn: add some parenthesis here?
> drivers/media/tuners/si2157.c:44 si2157_cmd_execute() warn: maybe use && instead of &
>
> git remote add linuxtv-samsung git://linuxtv.org/snawrocki/samsung.git
> git remote update linuxtv-samsung
> git checkout 192292403147877c7d5f737a3cc751ded397aef7
> vim +47 drivers/media/dvb-frontends/si2168.c
>
> 845f3505 Antti Palosaari 2014-04-10 31 goto err_mutex_unlock;
> 845f3505 Antti Palosaari 2014-04-10 32 } else if (ret != cmd->rlen) {
> 845f3505 Antti Palosaari 2014-04-10 33 ret = -EREMOTEIO;
> 845f3505 Antti Palosaari 2014-04-10 34 goto err_mutex_unlock;
> 845f3505 Antti Palosaari 2014-04-10 35 }
> 845f3505 Antti Palosaari 2014-04-10 36
> 845f3505 Antti Palosaari 2014-04-10 37 /* firmware ready? */
> 845f3505 Antti Palosaari 2014-04-10 38 if ((cmd->args[0] >> 7) & 0x01)
> 845f3505 Antti Palosaari 2014-04-10 39 break;
> 845f3505 Antti Palosaari 2014-04-10 40 }
> 845f3505 Antti Palosaari 2014-04-10 41
> 845f3505 Antti Palosaari 2014-04-10 42 dev_dbg(&s->client->dev, "%s: cmd execution took %d ms\n",
> 845f3505 Antti Palosaari 2014-04-10 43 __func__,
> 845f3505 Antti Palosaari 2014-04-10 44 jiffies_to_msecs(jiffies) -
> 845f3505 Antti Palosaari 2014-04-10 45 (jiffies_to_msecs(timeout) - TIMEOUT));
> 845f3505 Antti Palosaari 2014-04-10 46
> 845f3505 Antti Palosaari 2014-04-10 @47 if (!(cmd->args[0] >> 7) & 0x01) {
>
> This should be: if (!((md->args[0] >> 7) & 0x01)) {
> Otherwise it is a precedence error where it does the negate before the
> bitwise AND.
That was already on my TODO list as daily media build test sparse warned
it already http://hverkuil.home.xs4all.nl/logs/Monday.log
I am waiting for media/master kernel upgrades from 3.15-rc1 as that
kernel will hang whole machine when em28xx driver used (em28xx driver is
USB bridge for those si2168 and si2157).
regards
Antti
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [linuxtv-samsung:for-v3.16 45/81] drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here?
2014-05-05 20:52 ` Antti Palosaari
@ 2014-05-20 12:01 ` Dan Carpenter
2014-05-20 15:10 ` Antti Palosaari
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2014-05-20 12:01 UTC (permalink / raw)
To: Antti Palosaari; +Cc: kbuild, Mauro Carvalho Chehab, linux-media
On Mon, May 05, 2014 at 11:52:46PM +0300, Antti Palosaari wrote:
> >845f3505 Antti Palosaari 2014-04-10 46
> >845f3505 Antti Palosaari 2014-04-10 @47 if (!(cmd->args[0] >> 7) & 0x01) {
> >
> >This should be: if (!((md->args[0] >> 7) & 0x01)) {
> >Otherwise it is a precedence error where it does the negate before the
> >bitwise AND.
>
> That was already on my TODO list as daily media build test sparse
> warned it already http://hverkuil.home.xs4all.nl/logs/Monday.log
>
> I am waiting for media/master kernel upgrades from 3.15-rc1 as that
> kernel will hang whole machine when em28xx driver used (em28xx
> driver is USB bridge for those si2168 and si2157).
>
Wait, what? This is a one liner. I haven't understood the connection
with 3.15-rc1?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [linuxtv-samsung:for-v3.16 45/81] drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here?
2014-05-20 12:01 ` Dan Carpenter
@ 2014-05-20 15:10 ` Antti Palosaari
0 siblings, 0 replies; 4+ messages in thread
From: Antti Palosaari @ 2014-05-20 15:10 UTC (permalink / raw)
To: Dan Carpenter; +Cc: kbuild, Mauro Carvalho Chehab, linux-media
On 05/20/2014 03:01 PM, Dan Carpenter wrote:
> On Mon, May 05, 2014 at 11:52:46PM +0300, Antti Palosaari wrote:
>>> 845f3505 Antti Palosaari 2014-04-10 46
>>> 845f3505 Antti Palosaari 2014-04-10 @47 if (!(cmd->args[0] >> 7) & 0x01) {
>>>
>>> This should be: if (!((md->args[0] >> 7) & 0x01)) {
>>> Otherwise it is a precedence error where it does the negate before the
>>> bitwise AND.
>>
>> That was already on my TODO list as daily media build test sparse
>> warned it already http://hverkuil.home.xs4all.nl/logs/Monday.log
>>
>> I am waiting for media/master kernel upgrades from 3.15-rc1 as that
>> kernel will hang whole machine when em28xx driver used (em28xx
>> driver is USB bridge for those si2168 and si2157).
>>
>
> Wait, what? This is a one liner. I haven't understood the connection
> with 3.15-rc1?
Current media master, which contains that brand new si2168 driver, is
3.15-rc1. That device is implemented as a)
em28xx driver - USB interface + remote controller
si2168 driver - DVB-T/T2/C digital TV demodulator
si2157 driver - RF tuner
For some reason em28xx freezes whole machine when that 3.15-rc1 kernel
is used. It is not only that device, but all the other em28xx devices
too what I have.
Even it is simple one liner, I tend to test all my patches before pull
requesting to media master tree. Sure, I can do it using linus latest
tree and then rebase to media master & pull request, but it is all extra
work.
regards
Antti
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-20 15:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-05 19:02 [linuxtv-samsung:for-v3.16 45/81] drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here? Dan Carpenter
2014-05-05 20:52 ` Antti Palosaari
2014-05-20 12:01 ` Dan Carpenter
2014-05-20 15:10 ` Antti Palosaari
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.