All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <jdelvare@suse.de>
Cc: Josef Gajdusek <atx@atx.name>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] drivers/hwmon/emc1403.c: add support for emc14x2
Date: Mon, 12 May 2014 18:47:27 +0000	[thread overview]
Message-ID: <20140512184727.GA9003@roeck-us.net> (raw)
In-Reply-To: <20140512190327.4f65c90a@endymion.delvare>

On Mon, May 12, 2014 at 07:03:27PM +0200, Jean Delvare wrote:
> On Mon, 12 May 2014 09:14:15 -0700, Guenter Roeck wrote:
> > On Mon, May 12, 2014 at 02:34:09PM +0200, Josef Gajdusek wrote:
> > >  static const struct i2c_device_id emc1403_idtable[] = {
> > > -	{ "emc1403", 0 },
> > > -	{ "emc1404", 1 },
> > > -	{ "emc1423", 0 },
> > > -	{ "emc1424", 1 },
> > > +	{ "emc1402", emc1402 },
> > > +	{ "emc1403", emc1403 },
> > > +	{ "emc1404", emc1404 },
> > > +	{ "emc1422", emc1402 },
> > > +	{ "emc1423", emc1403 },
> > > +	{ "emc1424", emc1404 },
> > 
> > Wonder if we should list the emc141x chips here. Jean, any thoughts ?
> 
> Yes we should, so that people can declare the right chip in platform
> files, device tree etc. We can map the additional names to existing
> types if the chips are fully compatible.
> 
The chips are not only compatible, the even have the same device IDs.
Maybe I missed it, but I did not find a difference.

I'll add another patch to my list.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <jdelvare@suse.de>
Cc: Josef Gajdusek <atx@atx.name>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/hwmon/emc1403.c: add support for emc14x2
Date: Mon, 12 May 2014 11:47:27 -0700	[thread overview]
Message-ID: <20140512184727.GA9003@roeck-us.net> (raw)
In-Reply-To: <20140512190327.4f65c90a@endymion.delvare>

On Mon, May 12, 2014 at 07:03:27PM +0200, Jean Delvare wrote:
> On Mon, 12 May 2014 09:14:15 -0700, Guenter Roeck wrote:
> > On Mon, May 12, 2014 at 02:34:09PM +0200, Josef Gajdusek wrote:
> > >  static const struct i2c_device_id emc1403_idtable[] = {
> > > -	{ "emc1403", 0 },
> > > -	{ "emc1404", 1 },
> > > -	{ "emc1423", 0 },
> > > -	{ "emc1424", 1 },
> > > +	{ "emc1402", emc1402 },
> > > +	{ "emc1403", emc1403 },
> > > +	{ "emc1404", emc1404 },
> > > +	{ "emc1422", emc1402 },
> > > +	{ "emc1423", emc1403 },
> > > +	{ "emc1424", emc1404 },
> > 
> > Wonder if we should list the emc141x chips here. Jean, any thoughts ?
> 
> Yes we should, so that people can declare the right chip in platform
> files, device tree etc. We can map the additional names to existing
> types if the chips are fully compatible.
> 
The chips are not only compatible, the even have the same device IDs.
Maybe I missed it, but I did not find a difference.

I'll add another patch to my list.

Guenter

  reply	other threads:[~2014-05-12 18:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-11 13:00 [lm-sensors] [PATCH] drivers/hwmon/emc1403.c: add support for emc1412 Josef Gajdusek
2014-05-11 13:00 ` Josef Gajdusek
2014-05-11 22:40 ` [lm-sensors] " Guenter Roeck
2014-05-11 22:40   ` Guenter Roeck
2014-05-12  2:20   ` [lm-sensors] " Guenter Roeck
2014-05-12  2:20     ` Guenter Roeck
2014-05-12  6:10   ` Jean Delvare
2014-05-12  6:10     ` Jean Delvare
2014-05-12 15:59     ` [lm-sensors] " Guenter Roeck
2014-05-12 15:59       ` Guenter Roeck
2014-05-12 16:48       ` [lm-sensors] " Jean Delvare
2014-05-12 16:48         ` Jean Delvare
2014-05-12 18:09         ` [lm-sensors] " Guenter Roeck
2014-05-12 18:09           ` Guenter Roeck
2014-05-11 22:47 ` [lm-sensors] " Guenter Roeck
2014-05-11 22:47   ` Guenter Roeck
2014-05-12 12:34 ` [lm-sensors] [PATCH] drivers/hwmon/emc1403.c: add support for emc14x2 Josef Gajdusek
2014-05-12 12:34   ` Josef Gajdusek
2014-05-12 16:14   ` [lm-sensors] " Guenter Roeck
2014-05-12 16:14     ` Guenter Roeck
2014-05-12 17:03     ` [lm-sensors] " Jean Delvare
2014-05-12 17:03       ` Jean Delvare
2014-05-12 18:47       ` Guenter Roeck [this message]
2014-05-12 18:47         ` Guenter Roeck
2014-05-12 19:55         ` [lm-sensors] " Jean Delvare
2014-05-12 19:55           ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140512184727.GA9003@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=atx@atx.name \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.