From: Guenter Roeck <linux@roeck-us.net>
To: Josef Gajdusek <atx@atx.name>, jdelvare@suse.de
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] drivers/hwmon/emc1403.c: add support for emc1412
Date: Sun, 11 May 2014 22:47:17 +0000 [thread overview]
Message-ID: <536FFDF5.5070103@roeck-us.net> (raw)
In-Reply-To: <20140511130023.GA501@dashie>
On 05/11/2014 06:00 AM, Josef Gajdusek wrote:
> Adds support for emc1412.
>
[ ... ]
> @@ -330,9 +389,9 @@ static int emc1403_detect(struct i2c_client *client,
> }
>
> id = i2c_smbus_read_byte_data(client, THERMAL_REVISION_REG);
> - if (id != 0x01)
> + if (id != 0x01 && id != 0x04) {
> return -ENODEV;
> -
> + }
Forgot: Please see Documents/CodingStyle, Chapter 3:
"Do not unnecessarily use braces where a single statement will do."
As it turns out, this change generates a checkpatch warning.
Also, you forgot to sign this patch.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Josef Gajdusek <atx@atx.name>, jdelvare@suse.de
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/hwmon/emc1403.c: add support for emc1412
Date: Sun, 11 May 2014 15:47:17 -0700 [thread overview]
Message-ID: <536FFDF5.5070103@roeck-us.net> (raw)
In-Reply-To: <20140511130023.GA501@dashie>
On 05/11/2014 06:00 AM, Josef Gajdusek wrote:
> Adds support for emc1412.
>
[ ... ]
> @@ -330,9 +389,9 @@ static int emc1403_detect(struct i2c_client *client,
> }
>
> id = i2c_smbus_read_byte_data(client, THERMAL_REVISION_REG);
> - if (id != 0x01)
> + if (id != 0x01 && id != 0x04) {
> return -ENODEV;
> -
> + }
Forgot: Please see Documents/CodingStyle, Chapter 3:
"Do not unnecessarily use braces where a single statement will do."
As it turns out, this change generates a checkpatch warning.
Also, you forgot to sign this patch.
Guenter
next prev parent reply other threads:[~2014-05-11 22:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 13:00 [lm-sensors] [PATCH] drivers/hwmon/emc1403.c: add support for emc1412 Josef Gajdusek
2014-05-11 13:00 ` Josef Gajdusek
2014-05-11 22:40 ` [lm-sensors] " Guenter Roeck
2014-05-11 22:40 ` Guenter Roeck
2014-05-12 2:20 ` [lm-sensors] " Guenter Roeck
2014-05-12 2:20 ` Guenter Roeck
2014-05-12 6:10 ` Jean Delvare
2014-05-12 6:10 ` Jean Delvare
2014-05-12 15:59 ` [lm-sensors] " Guenter Roeck
2014-05-12 15:59 ` Guenter Roeck
2014-05-12 16:48 ` [lm-sensors] " Jean Delvare
2014-05-12 16:48 ` Jean Delvare
2014-05-12 18:09 ` [lm-sensors] " Guenter Roeck
2014-05-12 18:09 ` Guenter Roeck
2014-05-11 22:47 ` Guenter Roeck [this message]
2014-05-11 22:47 ` Guenter Roeck
2014-05-12 12:34 ` [lm-sensors] [PATCH] drivers/hwmon/emc1403.c: add support for emc14x2 Josef Gajdusek
2014-05-12 12:34 ` Josef Gajdusek
2014-05-12 16:14 ` [lm-sensors] " Guenter Roeck
2014-05-12 16:14 ` Guenter Roeck
2014-05-12 17:03 ` [lm-sensors] " Jean Delvare
2014-05-12 17:03 ` Jean Delvare
2014-05-12 18:47 ` [lm-sensors] " Guenter Roeck
2014-05-12 18:47 ` Guenter Roeck
2014-05-12 19:55 ` [lm-sensors] " Jean Delvare
2014-05-12 19:55 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536FFDF5.5070103@roeck-us.net \
--to=linux@roeck-us.net \
--cc=atx@atx.name \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.