From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-mmc@vger.kernel.org, ian@mnementh.co.uk,
linux-sh@vger.kernel.org, chris@printf.net,
ulf.hansson@linaro.org
Subject: Re: [PATCH] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock()
Date: Wed, 14 May 2014 06:47:23 +0900 [thread overview]
Message-ID: <20140513214723.GC6784@verge.net.au> (raw)
In-Reply-To: <53720B95.401@cogentembedded.com>
On Tue, May 13, 2014 at 04:09:57PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 05/13/2014 05:38 AM, Simon Horman wrote:
>
> >>I've spent a couple of days with the driver just hanging due to me forgetting
> >>to specify the external crystal frequency, so that clk_get_rate() returned 0
> >>and thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an
> >>acceptable behavior, so I suggest that the minimum frequency is checked for 0
> >>in tmio_mmc_host_probe().
>
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> >My suggestion is to update tmio_mmc_host_probe() so that it always exits,
> >perhaps returning an error if appropriate.
>
> Did you mean tmio_mmc_set_clock()?
Sorry for the cut-and-paste error. Yes, that is what I meant.
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-mmc@vger.kernel.org, ian@mnementh.co.uk,
linux-sh@vger.kernel.org, chris@printf.net,
ulf.hansson@linaro.org
Subject: Re: [PATCH] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock()
Date: Tue, 13 May 2014 21:47:23 +0000 [thread overview]
Message-ID: <20140513214723.GC6784@verge.net.au> (raw)
In-Reply-To: <53720B95.401@cogentembedded.com>
On Tue, May 13, 2014 at 04:09:57PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 05/13/2014 05:38 AM, Simon Horman wrote:
>
> >>I've spent a couple of days with the driver just hanging due to me forgetting
> >>to specify the external crystal frequency, so that clk_get_rate() returned 0
> >>and thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an
> >>acceptable behavior, so I suggest that the minimum frequency is checked for 0
> >>in tmio_mmc_host_probe().
>
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> >My suggestion is to update tmio_mmc_host_probe() so that it always exits,
> >perhaps returning an error if appropriate.
>
> Did you mean tmio_mmc_set_clock()?
Sorry for the cut-and-paste error. Yes, that is what I meant.
next prev parent reply other threads:[~2014-05-13 21:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 22:19 [PATCH] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock() Sergei Shtylyov
2014-05-03 22:19 ` Sergei Shtylyov
2014-05-13 1:38 ` Simon Horman
2014-05-13 1:38 ` Simon Horman
2014-05-13 12:09 ` Sergei Shtylyov
2014-05-13 12:09 ` Sergei Shtylyov
2014-05-13 21:47 ` Simon Horman [this message]
2014-05-13 21:47 ` Simon Horman
2014-05-15 19:31 ` Sergei Shtylyov
2014-05-15 19:31 ` Sergei Shtylyov
2014-06-26 19:56 ` Sergei Shtylyov
2014-06-26 19:56 ` Sergei Shtylyov
2014-09-03 19:27 ` Sergei Shtylyov
2014-09-03 19:27 ` Sergei Shtylyov
2014-09-04 11:00 ` Ulf Hansson
2014-09-04 11:00 ` Ulf Hansson
2014-09-04 21:51 ` Sergei Shtylyov
2014-09-04 21:51 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513214723.GC6784@verge.net.au \
--to=horms@verge.net.au \
--cc=chris@printf.net \
--cc=ian@mnementh.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.