From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Ian Molton <ian@mnementh.co.uk>,
Linux-sh list <linux-sh@vger.kernel.org>,
Chris Ball <chris@printf.net>
Subject: Re: [PATCH] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock()
Date: Fri, 05 Sep 2014 01:51:07 +0400 [thread overview]
Message-ID: <5408DECB.6000102@cogentembedded.com> (raw)
In-Reply-To: <CAPDyKFoWxCiVdeqJfx1s1bOPAr-_QmfxrXBHpZfmaupD4ED_bQ@mail.gmail.com>
Hello.
On 09/04/2014 03:00 PM, Ulf Hansson wrote:
>>>> I've spent a couple of days with the driver just hanging due to me
>>>> forgetting
>>>> to specify the external crystal frequency, so that clk_get_rate()
>>>> returned 0
>>>> and thus the loop in tmio_mmc_set_clock() never ended. I don't think
>>>> that's an
>>>> acceptable behavior, so I suggest that the minimum frequency is checked
>>>> for 0
>>>> in tmio_mmc_host_probe().
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>> ---
>>>> The patch is against Chris Ball's 'mmc.git' repo's 'master' branch.
>>> I'm still not seeing this patch applied anywhere in this repo...
>>> what's
>>> the problem with it?
>> Chris, Ulf, Ian, what's the issue with this patch? Do you want me to
>> rework it?
> I guess it has been forgotten, sorry about that.
> Please rebase it towards my mmc tree, which is the one we are using
> currently and repost it.
It should still apply flawlessly to your tree, want me to repost it anyway?
> Kind regards
> Uffe
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Ian Molton <ian@mnementh.co.uk>,
Linux-sh list <linux-sh@vger.kernel.org>,
Chris Ball <chris@printf.net>
Subject: Re: [PATCH] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock()
Date: Thu, 04 Sep 2014 21:51:07 +0000 [thread overview]
Message-ID: <5408DECB.6000102@cogentembedded.com> (raw)
In-Reply-To: <CAPDyKFoWxCiVdeqJfx1s1bOPAr-_QmfxrXBHpZfmaupD4ED_bQ@mail.gmail.com>
Hello.
On 09/04/2014 03:00 PM, Ulf Hansson wrote:
>>>> I've spent a couple of days with the driver just hanging due to me
>>>> forgetting
>>>> to specify the external crystal frequency, so that clk_get_rate()
>>>> returned 0
>>>> and thus the loop in tmio_mmc_set_clock() never ended. I don't think
>>>> that's an
>>>> acceptable behavior, so I suggest that the minimum frequency is checked
>>>> for 0
>>>> in tmio_mmc_host_probe().
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>> ---
>>>> The patch is against Chris Ball's 'mmc.git' repo's 'master' branch.
>>> I'm still not seeing this patch applied anywhere in this repo...
>>> what's
>>> the problem with it?
>> Chris, Ulf, Ian, what's the issue with this patch? Do you want me to
>> rework it?
> I guess it has been forgotten, sorry about that.
> Please rebase it towards my mmc tree, which is the one we are using
> currently and repost it.
It should still apply flawlessly to your tree, want me to repost it anyway?
> Kind regards
> Uffe
WBR, Sergei
next prev parent reply other threads:[~2014-09-04 21:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 22:19 [PATCH] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock() Sergei Shtylyov
2014-05-03 22:19 ` Sergei Shtylyov
2014-05-13 1:38 ` Simon Horman
2014-05-13 1:38 ` Simon Horman
2014-05-13 12:09 ` Sergei Shtylyov
2014-05-13 12:09 ` Sergei Shtylyov
2014-05-13 21:47 ` Simon Horman
2014-05-13 21:47 ` Simon Horman
2014-05-15 19:31 ` Sergei Shtylyov
2014-05-15 19:31 ` Sergei Shtylyov
2014-06-26 19:56 ` Sergei Shtylyov
2014-06-26 19:56 ` Sergei Shtylyov
2014-09-03 19:27 ` Sergei Shtylyov
2014-09-03 19:27 ` Sergei Shtylyov
2014-09-04 11:00 ` Ulf Hansson
2014-09-04 11:00 ` Ulf Hansson
2014-09-04 21:51 ` Sergei Shtylyov [this message]
2014-09-04 21:51 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5408DECB.6000102@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=chris@printf.net \
--cc=ian@mnementh.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.