All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Alexander Graf <agraf@suse.de>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH] kvmclock: Ensure time in migration never goes backward
Date: Wed, 14 May 2014 03:47:28 -0300	[thread overview]
Message-ID: <20140514064728.GA6064@amt.cnet> (raw)
In-Reply-To: <536CC1BC.2000302@redhat.com>

On Fri, May 09, 2014 at 01:53:32PM +0200, Paolo Bonzini wrote:
> Il 09/05/2014 04:28, Marcelo Tosatti ha scritto:
> >Alex,
> >
> >Unability to upgrade systems is not an excuse to fix the bug in the
> >wrong place.
> 
> It may be an excuse to fix the bug in both places though.
> 
> Paolo

Actually, its messy to fix this in kernel, because its necessary
to read TSC MSR of a remote vcpu.

So it seems more appropriate to do this in QEMU.

Sorry for the noise. Alexander, can you resend without the printf? 

Also checking for "larger than" is not necessary as discussed because
it is always true.


WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Alexander Graf <agraf@suse.de>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward
Date: Wed, 14 May 2014 03:47:28 -0300	[thread overview]
Message-ID: <20140514064728.GA6064@amt.cnet> (raw)
In-Reply-To: <536CC1BC.2000302@redhat.com>

On Fri, May 09, 2014 at 01:53:32PM +0200, Paolo Bonzini wrote:
> Il 09/05/2014 04:28, Marcelo Tosatti ha scritto:
> >Alex,
> >
> >Unability to upgrade systems is not an excuse to fix the bug in the
> >wrong place.
> 
> It may be an excuse to fix the bug in both places though.
> 
> Paolo

Actually, its messy to fix this in kernel, because its necessary
to read TSC MSR of a remote vcpu.

So it seems more appropriate to do this in QEMU.

Sorry for the noise. Alexander, can you resend without the printf? 

Also checking for "larger than" is not necessary as discussed because
it is always true.

  parent reply	other threads:[~2014-05-14  6:47 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-05 13:51 [PATCH] kvmclock: Ensure time in migration never goes backward Alexander Graf
2014-05-05 13:51 ` [Qemu-devel] " Alexander Graf
2014-05-05 17:46 ` Marcin Gibuła
2014-05-05 18:05   ` Alexander Graf
2014-05-05 18:26     ` Marcin Gibuła
2014-05-05 23:27       ` Marcelo Tosatti
2014-05-05 23:27         ` Marcelo Tosatti
2014-05-05 23:31         ` Marcelo Tosatti
2014-05-05 23:31           ` Marcelo Tosatti
2014-05-06  8:07           ` Marcin Gibuła
2014-05-06  8:07             ` [Qemu-devel] " Marcin Gibuła
2014-05-06  7:11         ` Alexander Graf
2014-05-06  7:37         ` Marcin Gibuła
2014-05-05 23:23 ` Marcelo Tosatti
2014-05-05 23:23   ` [Qemu-devel] " Marcelo Tosatti
2014-05-05 23:31   ` Marcelo Tosatti
2014-05-05 23:31     ` [Qemu-devel] " Marcelo Tosatti
2014-05-06  7:18     ` Alexander Graf
2014-05-06  7:18       ` [Qemu-devel] " Alexander Graf
2014-05-06 19:54       ` Marcin Gibuła
2014-05-07 23:23         ` Marcelo Tosatti
2014-05-07 23:23           ` Marcelo Tosatti
2014-05-07 23:21       ` Marcelo Tosatti
2014-05-07 23:21         ` [Qemu-devel] " Marcelo Tosatti
2014-05-07 23:29         ` Alexander Graf
2014-05-07 23:29           ` [Qemu-devel] " Alexander Graf
2014-05-06  7:16   ` Alexander Graf
2014-05-06  7:16     ` [Qemu-devel] " Alexander Graf
2014-05-07 10:04     ` Nick Thomas
2014-05-07 10:04       ` [Qemu-devel] " Nick Thomas
2014-05-08  1:33 ` Marcelo Tosatti
2014-05-08  1:33   ` [Qemu-devel] " Marcelo Tosatti
2014-05-08  7:21   ` Alexander Graf
2014-05-08  7:21     ` [Qemu-devel] " Alexander Graf
2014-05-09  2:28     ` Marcelo Tosatti
2014-05-09  2:28       ` [Qemu-devel] " Marcelo Tosatti
2014-05-09 11:53       ` Paolo Bonzini
2014-05-09 11:53         ` [Qemu-devel] " Paolo Bonzini
2014-05-12 20:26         ` Alexander Graf
2014-05-12 20:26           ` [Qemu-devel] " Alexander Graf
2014-05-14  7:26           ` Marcelo Tosatti
2014-05-14  7:26             ` [Qemu-devel] " Marcelo Tosatti
2014-05-14  6:47         ` Marcelo Tosatti [this message]
2014-05-14  6:47           ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140514064728.GA6064@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=agraf@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.