From: Ralf Baechle <ralf@linux-mips.org>
To: Yong Zhang <yong.zhang@windriver.com>
Cc: Yong Zhang <yong.zhang0@gmail.com>,
linux-mips@linux-mips.org, huawei.libin@huawei.com
Subject: Re: [PATCH] MIPS: change type of asid_cache to unsigned long
Date: Wed, 21 May 2014 13:29:36 +0200 [thread overview]
Message-ID: <20140521112936.GC17197@linux-mips.org> (raw)
In-Reply-To: <20140521053853.GC19655@pek-yzhang-d1>
On Wed, May 21, 2014 at 01:38:53PM +0800, Yong Zhang wrote:
> Please check the V2 in which I add the reporter.
> And thanks libin for reporting it :)
The bug was introduced in 5636919b5c909fee54a6ef5226475ecae012ad02
[MIPS: Outline udelay and fix a few issues.] in 2009 btw. I think
the intension was to avoid holes in the structure and minimize
the bloat. I instead applied aptch which also moves another member
of the struct arond such that no hole will be created in the struct.
This is important because the strcture it accessed fairly frequently
so we want to fit the most important members into as few cache
lines as possible.
Thanks,
Ralf
next prev parent reply other threads:[~2014-05-21 11:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 8:09 [PATCH] MIPS: change type of asid_cache to unsigned long Yong Zhang
2014-05-21 5:38 ` Yong Zhang
2014-05-21 5:38 ` Yong Zhang
2014-05-21 11:29 ` Ralf Baechle [this message]
2014-05-22 2:06 ` Yong Zhang
2014-05-22 13:42 ` Ralf Baechle
2014-05-23 3:08 ` Yong Zhang
2014-08-27 22:52 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521112936.GC17197@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=huawei.libin@huawei.com \
--cc=linux-mips@linux-mips.org \
--cc=yong.zhang0@gmail.com \
--cc=yong.zhang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.