All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yong Zhang <yong.zhang0@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Yong Zhang <yong.zhang@windriver.com>,
	linux-mips@linux-mips.org, huawei.libin@huawei.com
Subject: Re: [PATCH] MIPS: change type of asid_cache to unsigned long
Date: Thu, 22 May 2014 10:06:11 +0800	[thread overview]
Message-ID: <20140522020611.GA6813@zhy> (raw)
In-Reply-To: <20140521112936.GC17197@linux-mips.org>

On Wed, May 21, 2014 at 01:29:36PM +0200, Ralf Baechle wrote:
> On Wed, May 21, 2014 at 01:38:53PM +0800, Yong Zhang wrote:
> 
> > Please check the V2 in which I add the reporter.
> > And thanks libin for reporting it :)
> 
> The bug was introduced in 5636919b5c909fee54a6ef5226475ecae012ad02
> [MIPS: Outline udelay and fix a few issues.] in 2009 btw.  I think
> the intension was to avoid holes in the structure and minimize
> the bloat.  I instead applied aptch

Could you please show the patch?

> which also moves another member
> of the struct arond such that no hole will be created in the struct.
> This is important because the strcture it accessed fairly frequently
> so we want to fit the most important members into as few cache
> lines as possible.

I have tried to move the struct member around, but I found that the
hole cann't be avoided completely because for exampe struct cache_desc
is a bit special.

Thanks,
Yong


> 
> Thanks,
> 
>   Ralf

  reply	other threads:[~2014-05-22  2:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20  8:09 [PATCH] MIPS: change type of asid_cache to unsigned long Yong Zhang
2014-05-21  5:38 ` Yong Zhang
2014-05-21  5:38   ` Yong Zhang
2014-05-21 11:29   ` Ralf Baechle
2014-05-22  2:06     ` Yong Zhang [this message]
2014-05-22 13:42       ` Ralf Baechle
2014-05-23  3:08         ` Yong Zhang
2014-08-27 22:52         ` David Daney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140522020611.GA6813@zhy \
    --to=yong.zhang0@gmail.com \
    --cc=huawei.libin@huawei.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=yong.zhang@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.