All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yong Zhang <yong.zhang0@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Yong Zhang <yong.zhang@windriver.com>,
	linux-mips@linux-mips.org, huawei.libin@huawei.com
Subject: Re: [PATCH] MIPS: change type of asid_cache to unsigned long
Date: Fri, 23 May 2014 11:08:28 +0800	[thread overview]
Message-ID: <20140523030828.GA19723@zhy> (raw)
In-Reply-To: <20140522134245.GF10287@linux-mips.org>

On Thu, May 22, 2014 at 03:42:45PM +0200, Ralf Baechle wrote:
> Yes, struct cache_desc is still a problem.  Easily solvable though -
> some of it's members are excessivly large; by using smaller data types
> both the struct and its required alignment will shrink.  But that's
> for another patch; as for this patch my goal to just not make things
> any worse.

Agree. Anyway I have done the similiar change as your patch already :)

Thanks,
Yong

> 
>   Ralf
> 
> ---
>  arch/mips/include/asm/cpu-info.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/include/asm/cpu-info.h b/arch/mips/include/asm/cpu-info.h
> index dc2135b..ff2707a 100644
> --- a/arch/mips/include/asm/cpu-info.h
> +++ b/arch/mips/include/asm/cpu-info.h
> @@ -39,14 +39,14 @@ struct cache_desc {
>  #define MIPS_CACHE_PINDEX	0x00000020	/* Physically indexed cache */
>  
>  struct cpuinfo_mips {
> -	unsigned int		udelay_val;
> -	unsigned int		asid_cache;
> +	unsigned long		asid_cache;
>  
>  	/*
>  	 * Capability and feature descriptor structure for MIPS CPU
>  	 */
>  	unsigned long		options;
>  	unsigned long		ases;
> +	unsigned int		udelay_val;
>  	unsigned int		processor_id;
>  	unsigned int		fpu_id;
>  	unsigned int		msa_id;

  reply	other threads:[~2014-05-23  3:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20  8:09 [PATCH] MIPS: change type of asid_cache to unsigned long Yong Zhang
2014-05-21  5:38 ` Yong Zhang
2014-05-21  5:38   ` Yong Zhang
2014-05-21 11:29   ` Ralf Baechle
2014-05-22  2:06     ` Yong Zhang
2014-05-22 13:42       ` Ralf Baechle
2014-05-23  3:08         ` Yong Zhang [this message]
2014-08-27 22:52         ` David Daney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140523030828.GA19723@zhy \
    --to=yong.zhang0@gmail.com \
    --cc=huawei.libin@huawei.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=yong.zhang@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.