[PATCH] drm/panel: add support for AUO B133XTN01 panel

[PATCH] drm/panel: add support for AUO B133XTN01 panel

[Stéphane Marchesin]

This panel is used by my tegra board and supported by the simple-panel
driver.

Signed-off-by: Stéphane Marchesin <marcheu@chromium.org>
---
 drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 309f29e..46dcad0 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -284,6 +284,28 @@ static const struct panel_desc auo_b101aw03 = {
 	},
 };
 
+static const struct drm_display_mode auo_b133xtn01_mode = {
+	.clock = 69500,
+	.hdisplay = 1366,
+	.hsync_start = 1366 + 48,
+	.hsync_end = 1366 + 48 + 32,
+	.htotal = 1366 + 48 + 32 + 20,
+	.vdisplay = 768,
+	.vsync_start = 768 + 3,
+	.vsync_end = 768 + 3 + 6,
+	.vtotal = 768 + 3 + 6 + 13,
+	.vrefresh = 60,
+};
+
+static const struct panel_desc auo_b133xtn01 = {
+	.modes = &auo_b133xtn01_mode,
+	.num_modes = 1,
+	.size = {
+		.width = 293,
+		.height = 164,
+	},
+};
+
 static const struct drm_display_mode chunghwa_claa101wa01a_mode = {
 	.clock = 72070,
 	.hdisplay = 1366,
@@ -377,6 +399,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "auo,b101aw03",
 		.data = &auo_b101aw03,
 	}, {
+		.compatible = "auo,b133xtn01",
+		.data = &auo_b133xtn01,
+	}, {
 		.compatible = "chunghwa,claa101wa01a",
 		.data = &chunghwa_claa101wa01a
 	}, {
-- 
1.9.1.423.g4596e3a

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/panel: add support for AUO B133XTN01 panel

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 1510 bytes --]

On Tue, May 20, 2014 at 04:36:48PM -0700, Stéphane Marchesin wrote:
> This panel is used by my tegra board and supported by the simple-panel
> driver.

One thing I like to have is some indication in the commit message about
which board this panel is used on. Of course if you can't disclose that
yet I'll still take the patch, but perhaps you can be a little more
specific than "my Tegra board".

There also seem to be different variants of this panel. I've come across
datasheets for B133XTN01.0 and B133XTN01.2. The 1.0 seems to be native
LVDS whereas it looks as if the 1.2 comes with an additional module to
connect it to eDP. Which one is it that you use? I guess independent of
the specific model the timings will still work, but device tree mandates
that the compatible for the most specific model be used. Perhaps this
panel should be:

	compatible = "auo,b133xtn01.2", "auo,b133xtn01", "simple-panel";

That would allow the panel-simple driver to match on "auo,b133xtn01" and
pick up the timing that presumably works for both.

One other nit below:

> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
[...]
> +static const struct panel_desc auo_b133xtn01 = {
> +	.modes = &auo_b133xtn01_mode,
> +	.num_modes = 1,
> +	.size = {
> +		.width = 293,
> +		.height = 164,

According to the datasheet I found this is 164.97 mm, in which case I
think it may be better to round up to get a more accurate value of the
DPI.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/panel: add support for AUO B133XTN01 panel

[Stéphane Marchesin]

[-- Attachment #1.1: Type: text/plain, Size: 2107 bytes --]

On Thu, May 22, 2014 at 4:02 AM, Thierry Reding <thierry.reding@gmail.com>wrote:

> On Tue, May 20, 2014 at 04:36:48PM -0700, Stéphane Marchesin wrote:
> > This panel is used by my tegra board and supported by the simple-panel
> > driver.
>
> One thing I like to have is some indication in the commit message about
> which board this panel is used on. Of course if you can't disclose that
> yet I'll still take the patch, but perhaps you can be a little more
> specific than "my Tegra board".
>
> There also seem to be different variants of this panel. I've come across
> datasheets for B133XTN01.0 and B133XTN01.2. The 1.0 seems to be native
> LVDS whereas it looks as if the 1.2 comes with an additional module to
> connect it to eDP. Which one is it that you use? I guess independent of
> the specific model the timings will still work, but device tree mandates
> that the compatible for the most specific model be used. Perhaps this
> panel should be:
>
>
I'm using the B133XTN01.2. The panel specs are not exactly the same (the
1.2 has a single clock, 69.5MHz while the 1.0 does 60-80MHz), but the fixed
timing that I put in the DT will work on both.

Stéphane



>         compatible = "auo,b133xtn01.2", "auo,b133xtn01", "simple-panel";
>
> That would allow the panel-simple driver to match on "auo,b133xtn01" and
> pick up the timing that presumably works for both.
>
> One other nit below:
>
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c
> [...]
> > +static const struct panel_desc auo_b133xtn01 = {
> > +     .modes = &auo_b133xtn01_mode,
> > +     .num_modes = 1,
> > +     .size = {
> > +             .width = 293,
> > +             .height = 164,
>
> According to the datasheet I found this is 164.97 mm, in which case I
> think it may be better to round up to get a more accurate value of the
> DPI.
>
> Thierry
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>

[-- Attachment #1.2: Type: text/html, Size: 3165 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/panel: add support for AUO B133XTN01 panel

[Stéphane Marchesin]

This panel is used by nyan-big and supported by the simple-panel
driver.

Signed-off-by: Stéphane Marchesin <marcheu@chromium.org>
---
 drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 309f29e..3072638b 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -284,6 +284,28 @@ static const struct panel_desc auo_b101aw03 = {
 	},
 };
 
+static const struct drm_display_mode auo_b133xtn01_mode = {
+	.clock = 69500,
+	.hdisplay = 1366,
+	.hsync_start = 1366 + 48,
+	.hsync_end = 1366 + 48 + 32,
+	.htotal = 1366 + 48 + 32 + 20,
+	.vdisplay = 768,
+	.vsync_start = 768 + 3,
+	.vsync_end = 768 + 3 + 6,
+	.vtotal = 768 + 3 + 6 + 13,
+	.vrefresh = 60,
+};
+
+static const struct panel_desc auo_b133xtn01 = {
+	.modes = &auo_b133xtn01_mode,
+	.num_modes = 1,
+	.size = {
+		.width = 293,
+		.height = 165,
+	},
+};
+
 static const struct drm_display_mode chunghwa_claa101wa01a_mode = {
 	.clock = 72070,
 	.hdisplay = 1366,
@@ -377,6 +399,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "auo,b101aw03",
 		.data = &auo_b101aw03,
 	}, {
+		.compatible = "auo,b133xtn01.2", "auo,b133xtn01.0",
+		.data = &auo_b133xtn01,
+	}, {
 		.compatible = "chunghwa,claa101wa01a",
 		.data = &chunghwa_claa101wa01a
 	}, {
-- 
1.9.1.423.g4596e3a

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel