From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/2] arm64: enable context tracking
Date: Wed, 28 May 2014 12:44:38 +0100 [thread overview]
Message-ID: <20140528114438.GF15222@arm.com> (raw)
In-Reply-To: <1401130573-7443-3-git-send-email-larry.bassel@linaro.org>
Hi Larry,
On Mon, May 26, 2014 at 07:56:13PM +0100, Larry Bassel wrote:
> Make calls to ct_user_enter when the kernel is exited
> and ct_user_exit when the kernel is entered (in el0_da,
> el0_ia, el0_svc, el0_irq and all of the "error" paths).
>
> These macros expand to function calls which will only work
> properly if el0_sync and related code has been rearranged
> (in a previous patch of this series).
>
> The calls to ct_user_exit are made after hw debugging has been
> enabled (enable_dbg_and_irq).
>
> The call to ct_user_enter is made at the beginning of the
> kernel_exit macro.
>
> This patch is based on earlier work by Kevin Hilman.
> Save/restore optimizations were also done by Kevin.
Apologies if we've discussed this before (it rings a bell), but why are we
penalising the fast syscall path with this? Shouldn't TIF_NOHZ contribute to
out _TIF_WORK_MASK, then we could do the tracking on the syscall slow path?
I think that would tidy up your mov into x19 too.
Also -- how do you track ret_from_fork in the child with these patches?
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Larry Bassel <larry.bassel@linaro.org>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
"khilman@linaro.org" <khilman@linaro.org>
Subject: Re: [PATCH v5 2/2] arm64: enable context tracking
Date: Wed, 28 May 2014 12:44:38 +0100 [thread overview]
Message-ID: <20140528114438.GF15222@arm.com> (raw)
In-Reply-To: <1401130573-7443-3-git-send-email-larry.bassel@linaro.org>
Hi Larry,
On Mon, May 26, 2014 at 07:56:13PM +0100, Larry Bassel wrote:
> Make calls to ct_user_enter when the kernel is exited
> and ct_user_exit when the kernel is entered (in el0_da,
> el0_ia, el0_svc, el0_irq and all of the "error" paths).
>
> These macros expand to function calls which will only work
> properly if el0_sync and related code has been rearranged
> (in a previous patch of this series).
>
> The calls to ct_user_exit are made after hw debugging has been
> enabled (enable_dbg_and_irq).
>
> The call to ct_user_enter is made at the beginning of the
> kernel_exit macro.
>
> This patch is based on earlier work by Kevin Hilman.
> Save/restore optimizations were also done by Kevin.
Apologies if we've discussed this before (it rings a bell), but why are we
penalising the fast syscall path with this? Shouldn't TIF_NOHZ contribute to
out _TIF_WORK_MASK, then we could do the tracking on the syscall slow path?
I think that would tidy up your mov into x19 too.
Also -- how do you track ret_from_fork in the child with these patches?
Will
next prev parent reply other threads:[~2014-05-28 11:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 18:56 [PATCH v5 0/2] context tracker support for arm64 Larry Bassel
2014-05-26 18:56 ` Larry Bassel
2014-05-26 18:56 ` [PATCH v5 1/2] arm64: adjust el0_sync so that a function can be called Larry Bassel
2014-05-26 18:56 ` Larry Bassel
2014-05-28 11:27 ` Will Deacon
2014-05-28 11:27 ` Will Deacon
2014-05-28 19:35 ` Larry Bassel
2014-05-28 19:35 ` Larry Bassel
2014-05-29 17:52 ` Will Deacon
2014-05-29 17:52 ` Will Deacon
2014-05-26 18:56 ` [PATCH v5 2/2] arm64: enable context tracking Larry Bassel
2014-05-26 18:56 ` Larry Bassel
2014-05-28 11:44 ` Will Deacon [this message]
2014-05-28 11:44 ` Will Deacon
2014-05-28 15:55 ` Kevin Hilman
2014-05-28 15:55 ` Kevin Hilman
2014-05-28 18:49 ` Will Deacon
2014-05-28 18:49 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528114438.GF15222@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.