From: Amos Kong <akong@redhat.com>
To: Wang Weidong <wangweidong1@huawei.com>
Cc: stephen@networkplumber.org, netdev <netdev@vger.kernel.org>,
bridge@lists.linux-foundation.org, vyasevic@redhat.com,
David Miller <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net-next] bridge: fix the unbalanced promiscuous count when add_if failed
Date: Thu, 29 May 2014 11:51:31 +0800 [thread overview]
Message-ID: <20140529035131.GA12648@z.redhat.com> (raw)
In-Reply-To: <53869842.4060202@huawei.com>
On Thu, May 29, 2014 at 10:15:30AM +0800, Wang Weidong wrote:
> As commit 2796d0c648c94("bridge: Automatically manage port
> promiscuous mode."), make the add_if use dev_set_allmulti
> instead of dev_set_promiscuous, so when add_if failed, we
> should do dev_set_allmulti(dev, -1).
>
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
> ---
> net/bridge/br_if.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
> index 104a811..a08d2b8 100644
> --- a/net/bridge/br_if.c
> +++ b/net/bridge/br_if.c
> @@ -528,7 +528,7 @@ err2:
> kobject_put(&p->kobj);
> p = NULL; /* kobject_put frees */
> err1:
> - dev_set_promiscuity(dev, -1);
> + dev_set_allmulti(dev, -1);
Right fix.
Reviewed-by: Amos Kong <akong@redhat.com>
> put_back:
> dev_put(dev);
> kfree(p);
> --
> 1.8.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Amos.
WARNING: multiple messages have this Message-ID (diff)
From: Amos Kong <akong@redhat.com>
To: Wang Weidong <wangweidong1@huawei.com>
Cc: David Miller <davem@davemloft.net>,
stephen@networkplumber.org, bridge@lists.linux-foundation.org,
netdev <netdev@vger.kernel.org>,
vyasevic@redhat.com
Subject: Re: [PATCH net-next] bridge: fix the unbalanced promiscuous count when add_if failed
Date: Thu, 29 May 2014 11:51:31 +0800 [thread overview]
Message-ID: <20140529035131.GA12648@z.redhat.com> (raw)
In-Reply-To: <53869842.4060202@huawei.com>
On Thu, May 29, 2014 at 10:15:30AM +0800, Wang Weidong wrote:
> As commit 2796d0c648c94("bridge: Automatically manage port
> promiscuous mode."), make the add_if use dev_set_allmulti
> instead of dev_set_promiscuous, so when add_if failed, we
> should do dev_set_allmulti(dev, -1).
>
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
> ---
> net/bridge/br_if.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
> index 104a811..a08d2b8 100644
> --- a/net/bridge/br_if.c
> +++ b/net/bridge/br_if.c
> @@ -528,7 +528,7 @@ err2:
> kobject_put(&p->kobj);
> p = NULL; /* kobject_put frees */
> err1:
> - dev_set_promiscuity(dev, -1);
> + dev_set_allmulti(dev, -1);
Right fix.
Reviewed-by: Amos Kong <akong@redhat.com>
> put_back:
> dev_put(dev);
> kfree(p);
> --
> 1.8.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Amos.
next prev parent reply other threads:[~2014-05-29 3:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 2:15 [Bridge] [PATCH net-next] bridge: fix the unbalanced promiscuous count when add_if failed Wang Weidong
2014-05-29 2:15 ` Wang Weidong
2014-05-29 3:51 ` Amos Kong [this message]
2014-05-29 3:51 ` Amos Kong
2014-05-29 13:30 ` [Bridge] " Vlad Yasevich
2014-05-29 13:30 ` Vlad Yasevich
2014-05-30 14:34 ` [Bridge] " Stephen Hemminger
2014-05-30 14:34 ` Stephen Hemminger
2014-06-02 5:05 ` [Bridge] " David Miller
2014-06-02 5:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140529035131.GA12648@z.redhat.com \
--to=akong@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vyasevic@redhat.com \
--cc=wangweidong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.